[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538020#comment-16538020 ] Sankar Hariappan commented on HIVE-19970: - Test failures are irrelevant, 02-branch-3.patch is committed to branch-3. > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-19970.01.patch, HIVE-19970.02-branch-3.patch, > HIVE-19970.02.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[
https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536729#comment-16536729
]
Hive QA commented on HIVE-19970:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12930795/HIVE-19970.02-branch-3.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 14400 tests
executed
*Failed tests:*
{noformat}
TestBeeLineDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=257)
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=257)
TestMiniDruidCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=257)
TestMiniDruidKafkaCliDriver - did not produce a TEST-*.xml file (likely timed
out) (batchId=257)
TestTezPerfCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=257)
org.apache.hadoop.hive.ql.TestWarehouseExternalDir.testManagedPaths
(batchId=234)
org.apache.hive.jdbc.TestTriggersWorkloadManager.testTriggerHighShuffleBytes
(batchId=246)
org.apache.hive.service.TestHS2ImpersonationWithRemoteMS.testImpersonation
(batchId=242)
org.apache.hive.spark.client.rpc.TestRpc.testServerPort (batchId=309)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12484/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12484/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12484/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 9 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12930795 - PreCommit-HIVE-Build
> Replication dump has a NPE when table is empty
> --
>
> Key: HIVE-19970
> URL: https://issues.apache.org/jira/browse/HIVE-19970
> Project: Hive
> Issue Type: Task
> Components: repl
>Affects Versions: 3.1.0, 4.0.0
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-19970.01.patch, HIVE-19970.02-branch-3.patch,
> HIVE-19970.02.patch
>
>
> if table directory or partition directory is missing ..dump is throwing NPE
> instead of file missing exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[
https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1653#comment-1653
]
Hive QA commented on HIVE-19970:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 15s{color}
| {color:red}
/data/hiveptest/logs/PreCommit-HIVE-Build-12484/patches/PreCommit-HIVE-Build-12484.patch
does not apply to master. Rebase required? Wrong Branch? See
http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12484/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Replication dump has a NPE when table is empty
> --
>
> Key: HIVE-19970
> URL: https://issues.apache.org/jira/browse/HIVE-19970
> Project: Hive
> Issue Type: Task
> Components: repl
>Affects Versions: 3.1.0, 4.0.0
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-19970.01.patch, HIVE-19970.02-branch-3.patch,
> HIVE-19970.02.patch
>
>
> if table directory or partition directory is missing ..dump is throwing NPE
> instead of file missing exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528972#comment-16528972 ] Sankar Hariappan commented on HIVE-19970: - 02.patch is committed to master. Thanks [~maheshk114] for the contribution! > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-19970.01.patch, HIVE-19970.02.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[
https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528749#comment-16528749
]
Hive QA commented on HIVE-19970:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12929584/HIVE-19970.02.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14635 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12275/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12275/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12275/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12929584 - PreCommit-HIVE-Build
> Replication dump has a NPE when table is empty
> --
>
> Key: HIVE-19970
> URL: https://issues.apache.org/jira/browse/HIVE-19970
> Project: Hive
> Issue Type: Task
> Components: repl
>Affects Versions: 3.1.0, 4.0.0
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0
>
> Attachments: HIVE-19970.01.patch, HIVE-19970.02.patch
>
>
> if table directory or partition directory is missing ..dump is throwing NPE
> instead of file missing exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[
https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528741#comment-16528741
]
Hive QA commented on HIVE-19970:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
3s{color} | {color:blue} standalone-metastore in master has 228 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
48s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
38s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
23s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
22s{color} | {color:red} itests/hive-unit: The patch generated 5 new + 654
unchanged - 1 fixed = 659 total (was 655) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12275/dev-support/hive-personality.sh
|
| git revision | master / 8f57e25 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12275/yetus/diff-checkstyle-itests_hive-unit.txt
|
| modules | C: standalone-metastore ql itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12275/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Replication dump has a NPE when table is empty
> --
>
> Key: HIVE-19970
> URL: https://issues.apache.org/jira/browse/HIVE-19970
> Project: Hive
> Issue Type: Task
> Components: repl
>Affects Versions: 3.1.0, 4.0.0
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.2.0
>
> Attachments: HIVE-19970.01.patch, HIVE-19970.02.patch
>
>
> if table directory or partition directory is missing ..dump is throwing NPE
> instead of file missing exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526517#comment-16526517 ] Sankar Hariappan commented on HIVE-19970: - +1 for 02.patch, pending tests > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-19970.01.patch, HIVE-19970.02.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526086#comment-16526086 ] Peter Vary commented on HIVE-19970: --- [~maheshk114]: I think it is ok, to leave out the changes regarding [TestTablesCreateDropAlterTruncate.java|https://github.com/apache/hive/pull/379/files/a1ad4c1d068ad1cd5ce6b8ec7170bff1b1a4f1b1#diff-b61dca08c674ae7d39ef003beba3661c]. Still waiting for response the guys who did the change. > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-19970.01.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526068#comment-16526068 ] mahesh kumar behera commented on HIVE-19970: [~pvary] do we need the changes done in [TestTablesCreateDropAlterTruncate.java|https://github.com/apache/hive/pull/379/files/a1ad4c1d068ad1cd5ce6b8ec7170bff1b1a4f1b1#diff-b61dca08c674ae7d39ef003beba3661c] ? as this change is just reverted the changes from some other commit > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-19970.01.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525444#comment-16525444 ] Vineet Garg commented on HIVE-19970: Deferring this to 3.2.0 since the branch for 3.1.0 has been cut off. > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-19970.01.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[
https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521983#comment-16521983
]
Peter Vary commented on HIVE-19970:
---
[~maheshk114]: Thanks for fixing the test
Not an expert on replication but a few comments anyway on coding style which
might be worth to fix:
* If you have to change the patch, it would be good to take care of the
checkstyle errors shown by yetus results:
{code}
./itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcrossInstances.java:1103:
CommandProcessorResponse ret = replica.runCommand("REPL LOAD " +
replicatedDbName + " FROM '" + tuple2.dumpLocation + "'");: warning: Line is
longer than 120 characters (found 127).
./itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java:3195:
Path path = new Path(System.getProperty("test.warehouse.dir",""));:66:
warning: ',' is not followed by whitespace.
./standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:4991:
throw new InvalidOperationException("Unable to alter table" + dbname
+ "." + name + " as new db name is null");: warning: Line is longer than 120
characters (found 122).
{code}
* Changes in {{HiveAlterHandler.java}} - these are not necessary, and I usually
try to avoid them if I do not change the code anyway. When someone cherry-picks
a change these changes can make ones life a misery.
* I see several cases when we log something in error, but immediately rethrow
the exception. If the rethrown exceptions are logged later then this extra log
line is unnecessary, and makes reading the log harder. Since I am not an expert
of the code here I do not know if this is the case or not.
* Also I usually try to avoid cramming two changes in one fix (Repl fix, and
unrelated test fix) - The reason behind is again that if we have to cherry-pick
the change we might want only one of the changes and not both
As mentioned above, I am not an expert on Replication, so if the other
reviewers suggest changes, the it would be nice to fix these as well.
Thanks,
Peter
PS: Rechecked the {{TestTablesCreateDropAlterTruncate.
testAlterTableNullDatabaseInNew}} one step deeper, and the "funny" thing is
that your change in HIVE-19569 actually reverted the change caused by
HIVE-19418. I will ask the developers of that patch about the reasoning.
> Replication dump has a NPE when table is empty
> --
>
> Key: HIVE-19970
> URL: https://issues.apache.org/jira/browse/HIVE-19970
> Project: Hive
> Issue Type: Task
> Components: repl
>Affects Versions: 3.1.0, 4.0.0
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.1.0, 4.0.0
>
> Attachments: HIVE-19970.01.patch
>
>
> if table directory or partition directory is missing ..dump is throwing NPE
> instead of file missing exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[
https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521747#comment-16521747
]
Hive QA commented on HIVE-19970:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928907/HIVE-19970.01.patch
{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14604 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12065/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12065/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12065/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12928907 - PreCommit-HIVE-Build
> Replication dump has a NPE when table is empty
> --
>
> Key: HIVE-19970
> URL: https://issues.apache.org/jira/browse/HIVE-19970
> Project: Hive
> Issue Type: Task
> Components: repl
>Affects Versions: 3.1.0, 4.0.0
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.1.0, 4.0.0
>
> Attachments: HIVE-19970.01.patch
>
>
> if table directory or partition directory is missing ..dump is throwing NPE
> instead of file missing exception.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[
https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521738#comment-16521738
]
Hive QA commented on HIVE-19970:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
38s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
59s{color} | {color:blue} ql in master has 2282 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
8s{color} | {color:blue} standalone-metastore in master has 228 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
23s{color} | {color:red} itests/hive-unit: The patch generated 2 new + 631
unchanged - 0 fixed = 633 total (was 631) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
22s{color} | {color:red} standalone-metastore: The patch generated 1 new + 467
unchanged - 0 fixed = 468 total (was 467) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12065/dev-support/hive-personality.sh
|
| git revision | master / be1955f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12065/yetus/diff-checkstyle-itests_hive-unit.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12065/yetus/diff-checkstyle-standalone-metastore.txt
|
| modules | C: itests/hive-unit ql standalone-metastore U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12065/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Replication dump has a NPE when table is empty
> --
>
> Key: HIVE-19970
> URL: https://issues.apache.org/jira/browse/HIVE-19970
> Project: Hive
> Issue Type: Task
> Components: repl
>Affects Versions: 3.1.0, 4.0.0
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.1.0, 4.0.0
>
>
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521410#comment-16521410 ] mahesh kumar behera commented on HIVE-19970: [~pvary] I have added the [TestTablesCreateDropAlterTruncate.java|https://github.com/apache/hive/pull/379/files#diff-b61dca08c674ae7d39ef003beba3661c] changes in this patch > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-19970.01.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521408#comment-16521408 ] ASF GitHub Bot commented on HIVE-19970: --- GitHub user maheshk114 opened a pull request: https://github.com/apache/hive/pull/379 HIVE-19970 : Replication dump has a NPE when table is empty You can merge this pull request into a Git repository by running: $ git pull https://github.com/maheshk114/hive BUG-105903 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hive/pull/379.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #379 commit a1ad4c1d068ad1cd5ce6b8ec7170bff1b1a4f1b1 Author: Mahesh Kumar Behera Date: 2018-06-22T20:04:15Z HIVE-19970 : Replication dump has a NPE when table is empty > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-19970.01.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19970) Replication dump has a NPE when table is empty
[ https://issues.apache.org/jira/browse/HIVE-19970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521407#comment-16521407 ] mahesh kumar behera commented on HIVE-19970: [~pvary] [~sankarh] please review the patch > Replication dump has a NPE when table is empty > -- > > Key: HIVE-19970 > URL: https://issues.apache.org/jira/browse/HIVE-19970 > Project: Hive > Issue Type: Task > Components: repl >Affects Versions: 3.1.0, 4.0.0 >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Fix For: 3.1.0, 4.0.0 > > Attachments: HIVE-19970.01.patch > > > if table directory or partition directory is missing ..dump is throwing NPE > instead of file missing exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
