[jira] [Comment Edited] (HIVE-17468) Shade and package appropriate jackson version for druid storage handler
[ https://issues.apache.org/jira/browse/HIVE-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157149#comment-16157149 ] Jesus Camacho Rodriguez edited comment on HIVE-17468 at 9/7/17 4:13 PM: [~bslim], yes, the problem will be in a distributed environment, e.g., in Tez, when you have to send the jar around, right? In your local machine or if you run in a single node mode, Calcite will be indeed available. https://github.com/apache/hive/blob/master/druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidRecordWriter.java#L44 was (Author: jcamachorodriguez): [~bslim], yes, the problem will be in a distributed environment, e.g., in Tez, when you have to send the jar around, right? In your local machine or if you run in a single node mode, Calcite will be indeed available. > Shade and package appropriate jackson version for druid storage handler > --- > > Key: HIVE-17468 > URL: https://issues.apache.org/jira/browse/HIVE-17468 > Project: Hive > Issue Type: Bug >Reporter: slim bouguerra >Assignee: Jesus Camacho Rodriguez > Fix For: 3.0.0 > > Attachments: HIVE-17468.2.patch, HIVE-17468.patch, hive-druid-deps.txt > > > Currently we are excluding all the jackson core dependencies coming from > druid. This is wrong in my opinion since this will lead to the packaging of > unwanted jackson library from other projects. > As you can see the file hive-druid-deps.txt currently jacskon core is coming > from calcite and the version is 2.6.3 which is very different from 2.4.6 used > by druid. This patch exclude the unwanted jars and make sure to bring in > druid jackson dependency from druid it self. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HIVE-17468) Shade and package appropriate jackson version for druid storage handler
[
https://issues.apache.org/jira/browse/HIVE-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156170#comment-16156170
]
Jesus Camacho Rodriguez edited comment on HIVE-17468 at 9/6/17 11:04 PM:
-
{quote}
if we exclude all the druid stuff then what is left is not what we want is
going to be either hive jackson ones or from other transitive dependency.
{quote}
[~bslim], before we pulled the calcite-druid package, were we packing then the
hive jackson dependencies into the uber jar? How was that ever working?
was (Author: jcamachorodriguez):
{quote}
if we exclude all the druid stuff then what is left is not what we want is
going to be either hive jackson ones or from other transitive dependency.
{quote}
[~bslim], before we pulled the calcite-druid package, were we packing then the
hive jackson dependencies into the uber jar? How was that working?
> Shade and package appropriate jackson version for druid storage handler
> ---
>
> Key: HIVE-17468
> URL: https://issues.apache.org/jira/browse/HIVE-17468
> Project: Hive
> Issue Type: Bug
>Reporter: slim bouguerra
>Assignee: Jesus Camacho Rodriguez
> Fix For: 3.0.0
>
> Attachments: HIVE-17468.patch, hive-druid-deps.txt
>
>
> Currently we are excluding all the jackson core dependencies coming from
> druid. This is wrong in my opinion since this will lead to the packaging of
> unwanted jackson library from other projects.
> As you can see the file hive-druid-deps.txt currently jacskon core is coming
> from calcite and the version is 2.6.3 which is very different from 2.4.6 used
> by druid. This patch exclude the unwanted jars and make sure to bring in
> druid jackson dependency from druid it self.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
