[jira] [Comment Edited] (HIVE-18052) Run p-tests on mm tables
[ https://issues.apache.org/jira/browse/HIVE-18052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466566#comment-16466566 ] Sergey Shelukhin edited comment on HIVE-18052 at 5/7/18 10:45 PM: -- After the recent fixes and changes to MM tables, we can do another iteration. Most of the changes above are irrelevant, or have since been fixed. One major item remaining is stats for ACID and MM tables; that is tracked separately. I also removed the out file changes from .19 patch from this iteration for now. They create confusing conflicts and we don't know if out file diffs are still the old irrelevant diffs, or there are some new relevant diffs after so many changes to MM tables and to the tests themselves. was (Author: sershe): After the recent fixes and changes to MM tables, we can do another iteration. I also removed the out file changes from .19 patch from this iteration for now. > Run p-tests on mm tables > > > Key: HIVE-18052 > URL: https://issues.apache.org/jira/browse/HIVE-18052 > Project: Hive > Issue Type: Task >Reporter: Steve Yeom >Assignee: Sergey Shelukhin >Priority: Major > Attachments: HIVE-18052.1.patch, HIVE-18052.10.patch, > HIVE-18052.11.patch, HIVE-18052.12.patch, HIVE-18052.13.patch, > HIVE-18052.14.patch, HIVE-18052.15.patch, HIVE-18052.16.patch, > HIVE-18052.17.patch, HIVE-18052.18.patch, HIVE-18052.19.patch, > HIVE-18052.2.patch, HIVE-18052.20.patch, HIVE-18052.3.patch, > HIVE-18052.4.patch, HIVE-18052.5.patch, HIVE-18052.6.patch, > HIVE-18052.7.patch, HIVE-18052.8.patch, HIVE-18052.9.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HIVE-18052) Run p-tests on mm tables
[ https://issues.apache.org/jira/browse/HIVE-18052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416589#comment-16416589 ] Sergey Shelukhin edited comment on HIVE-18052 at 3/28/18 2:02 AM: -- Attached the patch. I was assuming during initial process above that this is test only patch but there are actually some fixes and changes there. Some of these got lost because of conflicts with master in my upload. [~steveyeom2017] we urgently need to get these fixes that already exist on master... maintaining them in some floating patches is not sustainable. Also there were many out files conflicts that I've ignored (it's easier to look at files again than to resolve out file conflicts). I think at this point we should 1) Get existing fixes in. 2) Do a quick check on failures from this run and identify basic blocking issues and missing functionality. 3) Make new fixes, repeat from (1). For the first iteration we can do 1 and 2 in parallel, I'll take a look at failures from this run, or whenever we get a sane run. Throughout this process we can determine when this is shippable, ie when remaining gaps are small/trivial/obscure and we can just disable them and fix them later via the same process. Otherwise attempt to make one epic fix patch will take too long. [~steveyeom2017] also do you know if the patch/some other jira has full load overwrite implementation? I'm not sure about the state of that. cc [~ekoifman] [~hagleitn] was (Author: sershe): Attached the patch. I was assuming during initial process above that this is test only patch but there are actually some fixes and changes there. Some of these got lost because of conflicts with master in my upload. [~steveyeom2017] we urgently need to get these fixes that already exist on master... maintaining them in some floating patches is not sustainable. Also there were many out files conflicts that I've ignored (it's easier to look at files again than to resolve out file conflicts). I think at this point we should 1) Get existing fixes in. 2) Do a quick check on failures from this run and identify basic blocking issues and missing functionality. 3) Make new fixes, repeat from (1). Throughout this process we can determine when this is shippable, ie when remaining gaps are small/trivial/obscure and we can just disable them and fix them later via the same process. Otherwise attempt to make one epic fix patch will take too long. [~steveyeom2017] also do you know if the patch/some other jira has full load overwrite implementation? I'm not sure about the state of that. > Run p-tests on mm tables > > > Key: HIVE-18052 > URL: https://issues.apache.org/jira/browse/HIVE-18052 > Project: Hive > Issue Type: Task >Reporter: Steve Yeom >Assignee: Steve Yeom >Priority: Major > Attachments: HIVE-18052.1.patch, HIVE-18052.10.patch, > HIVE-18052.11.patch, HIVE-18052.12.patch, HIVE-18052.13.patch, > HIVE-18052.14.patch, HIVE-18052.15.patch, HIVE-18052.16.patch, > HIVE-18052.17.patch, HIVE-18052.18.patch, HIVE-18052.2.patch, > HIVE-18052.3.patch, HIVE-18052.4.patch, HIVE-18052.5.patch, > HIVE-18052.6.patch, HIVE-18052.7.patch, HIVE-18052.8.patch, HIVE-18052.9.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HIVE-18052) Run p-tests on mm tables
[ https://issues.apache.org/jira/browse/HIVE-18052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312174#comment-16312174 ] Steve Yeom edited comment on HIVE-18052 at 1/4/18 11:22 PM: patch 16 is the same as patch 156. Adding this since patch 15 is not run by the p-test system. was (Author: steveyeom2017): patch 16 is the same as patch 156. Adding this since patch 15 is not tested. > Run p-tests on mm tables > > > Key: HIVE-18052 > URL: https://issues.apache.org/jira/browse/HIVE-18052 > Project: Hive > Issue Type: Task >Reporter: Steve Yeom >Assignee: Steve Yeom > Attachments: HIVE-18052.1.patch, HIVE-18052.10.patch, > HIVE-18052.11.patch, HIVE-18052.12.patch, HIVE-18052.13.patch, > HIVE-18052.14.patch, HIVE-18052.15.patch, HIVE-18052.16.patch, > HIVE-18052.2.patch, HIVE-18052.3.patch, HIVE-18052.4.patch, > HIVE-18052.5.patch, HIVE-18052.6.patch, HIVE-18052.7.patch, > HIVE-18052.8.patch, HIVE-18052.9.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HIVE-18052) Run p-tests on mm tables
[ https://issues.apache.org/jira/browse/HIVE-18052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312174#comment-16312174 ] Steve Yeom edited comment on HIVE-18052 at 1/4/18 11:22 PM: patch 16 is the same as patch 15. Adding this since patch 15 is not run by the p-test system. was (Author: steveyeom2017): patch 16 is the same as patch 156. Adding this since patch 15 is not run by the p-test system. > Run p-tests on mm tables > > > Key: HIVE-18052 > URL: https://issues.apache.org/jira/browse/HIVE-18052 > Project: Hive > Issue Type: Task >Reporter: Steve Yeom >Assignee: Steve Yeom > Attachments: HIVE-18052.1.patch, HIVE-18052.10.patch, > HIVE-18052.11.patch, HIVE-18052.12.patch, HIVE-18052.13.patch, > HIVE-18052.14.patch, HIVE-18052.15.patch, HIVE-18052.16.patch, > HIVE-18052.2.patch, HIVE-18052.3.patch, HIVE-18052.4.patch, > HIVE-18052.5.patch, HIVE-18052.6.patch, HIVE-18052.7.patch, > HIVE-18052.8.patch, HIVE-18052.9.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
