[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[ https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549874#comment-16549874 ] Sergey Shelukhin edited comment on HIVE-19532 at 7/19/18 9:13 PM: -- All the q test failures are trivial updates, except acid_stats4 - rename partition doesn't actually work, not sure how I didn't notice it before. The non q test failure is a test setup issue. I will fix and commit all the test fixes/updates together. was (Author: sershe): All the failures are trivial, except acid_stats4 - rename partition doesn't actually work, not sure how I didn't notice it before. I will fix and commit all the test fixes/updates together > fix tests for master-txnstats branch > > > Key: HIVE-19532 > URL: https://issues.apache.org/jira/browse/HIVE-19532 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Steve Yeom >Assignee: Sergey Shelukhin >Priority: Major > Fix For: 3.2.0 > > Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch, > HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch, > HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.07.patch, > HIVE-19532.08.patch, HIVE-19532.09.patch, HIVE-19532.10.patch, > HIVE-19532.11.patch, HIVE-19532.12.patch, HIVE-19532.13.patch, > HIVE-19532.14.patch, HIVE-19532.15.patch, HIVE-19532.16.patch, > HIVE-19532.17.patch, HIVE-19532.18.patch, HIVE-19532.19.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[ https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540900#comment-16540900 ] Eugene Koifman edited comment on HIVE-19532 at 7/11/18 11:44 PM: - vector_delete_orig_table.q - is a test issue - fixed in HIVE-20145 - rather in addendum to HIVE-20076 was (Author: ekoifman): vector_delete_orig_table.q - is a test issue - fixed in https://issues.apache.org/jira/browse/HIVE-20145 > fix tests for master-txnstats branch > > > Key: HIVE-19532 > URL: https://issues.apache.org/jira/browse/HIVE-19532 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Steve Yeom >Assignee: Sergey Shelukhin >Priority: Major > Fix For: 3.2.0 > > Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch, > HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch, > HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.07.patch, > HIVE-19532.08.patch, HIVE-19532.09.patch, HIVE-19532.10.patch, > HIVE-19532.11.patch, HIVE-19532.12.patch, HIVE-19532.13.patch, > HIVE-19532.14.patch, HIVE-19532.15.patch, HIVE-19532.16.patch, > HIVE-19532.17.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[
https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540882#comment-16540882
]
Sergey Shelukhin edited comment on HIVE-19532 at 7/11/18 11:29 PM:
---
acid_no_buckets is a known bad one.
A concerning one (might be dup of acid_no_bucket; or might be caused by
HIVE-20076 somehow being merged wrong):
{noformat}
java.lang.AssertionError:
Client Execution succeeded but contained differences (error code = 1) after
executing vector_delete_orig_table.q
151c151
< 12280
---
> 12192
{noformat}
The error from TestCompactionTxnHandler looks weird, DBS table doesn't exist,
not sure why. Might require a local repro.
The rest look trivial.
was (Author: sershe):
acid_no_buckets is a known bad one.
A concerning one (might be dup of acid_no_bucket; or might be caused by
HIVE-20076):
{noformat}
java.lang.AssertionError:
Client Execution succeeded but contained differences (error code = 1) after
executing vector_delete_orig_table.q
151c151
< 12280
---
> 12192
{noformat}
The error from TestCompactionTxnHandler looks weird, DBS table doesn't exist,
not sure why. Might require a local repro.
The rest look trivial.
> fix tests for master-txnstats branch
>
>
> Key: HIVE-19532
> URL: https://issues.apache.org/jira/browse/HIVE-19532
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
>Affects Versions: 3.0.0
>Reporter: Steve Yeom
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch,
> HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch,
> HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.07.patch,
> HIVE-19532.08.patch, HIVE-19532.09.patch, HIVE-19532.10.patch,
> HIVE-19532.11.patch, HIVE-19532.12.patch, HIVE-19532.13.patch,
> HIVE-19532.14.patch, HIVE-19532.15.patch, HIVE-19532.16.patch,
> HIVE-19532.17.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[
https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540882#comment-16540882
]
Sergey Shelukhin edited comment on HIVE-19532 at 7/11/18 11:28 PM:
---
acid_no_buckets is a known bad one.
A concerning one (might be dup of acid_no_bucket; or might be caused by
HIVE-20076):
{noformat}
java.lang.AssertionError:
Client Execution succeeded but contained differences (error code = 1) after
executing vector_delete_orig_table.q
151c151
< 12280
---
> 12192
{noformat}
The error from TestCompactionTxnHandler looks weird, DBS table doesn't exist,
not sure why. Might require a local repro.
The rest look trivial.
was (Author: sershe):
acid_no_buckets is a known bad one.
A concerning one (might be dup of acid_no_bucket; or might be caused by master
change for row IDs that somehow got merged wrong):
{noformat}
java.lang.AssertionError:
Client Execution succeeded but contained differences (error code = 1) after
executing vector_delete_orig_table.q
151c151
< 12280
---
> 12192
{noformat}
The error from TestCompactionTxnHandler looks weird, DBS table doesn't exist,
not sure why. Might require a local repro.
The rest look trivial.
> fix tests for master-txnstats branch
>
>
> Key: HIVE-19532
> URL: https://issues.apache.org/jira/browse/HIVE-19532
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
>Affects Versions: 3.0.0
>Reporter: Steve Yeom
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch,
> HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch,
> HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.07.patch,
> HIVE-19532.08.patch, HIVE-19532.09.patch, HIVE-19532.10.patch,
> HIVE-19532.11.patch, HIVE-19532.12.patch, HIVE-19532.13.patch,
> HIVE-19532.14.patch, HIVE-19532.15.patch, HIVE-19532.16.patch,
> HIVE-19532.17.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[
https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540882#comment-16540882
]
Sergey Shelukhin edited comment on HIVE-19532 at 7/11/18 11:25 PM:
---
acid_no_buckets is a known bad one.
A concerning one (might be dup of acid_no_bucket; or might be caused by master
change for row IDs that somehow got merged wrong):
{noformat}
java.lang.AssertionError:
Client Execution succeeded but contained differences (error code = 1) after
executing vector_delete_orig_table.q
151c151
< 12280
---
> 12192
{noformat}
The error from TestCompactionTxnHandler looks weird, DBS table doesn't exist,
not sure why. Might require a local repro.
The rest look trivial.
was (Author: sershe):
A concerning one (might be dup of acid_no_bucket; or might be caused by master
change for row IDs that somehow got merged wrong):
{noformat}
java.lang.AssertionError:
Client Execution succeeded but contained differences (error code = 1) after
executing vector_delete_orig_table.q
151c151
< 12280
---
> 12192
{noformat}
> fix tests for master-txnstats branch
>
>
> Key: HIVE-19532
> URL: https://issues.apache.org/jira/browse/HIVE-19532
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
>Affects Versions: 3.0.0
>Reporter: Steve Yeom
>Assignee: Sergey Shelukhin
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch,
> HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch,
> HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.07.patch,
> HIVE-19532.08.patch, HIVE-19532.09.patch, HIVE-19532.10.patch,
> HIVE-19532.11.patch, HIVE-19532.12.patch, HIVE-19532.13.patch,
> HIVE-19532.14.patch, HIVE-19532.15.patch, HIVE-19532.16.patch,
> HIVE-19532.17.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[ https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524460#comment-16524460 ] Sergey Shelukhin edited comment on HIVE-19532 at 6/27/18 2:07 AM: -- Fixed some more tests, updated a bunch of out files, filed a bug for a couple result changes that look invalid. Committed all of that to the branch. was (Author: sershe): Fixed some more tests, updated a bunch of out files, filed a bug for a couple result changes that look invalid. > fix tests for master-txnstats branch > > > Key: HIVE-19532 > URL: https://issues.apache.org/jira/browse/HIVE-19532 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Steve Yeom >Assignee: Sergey Shelukhin >Priority: Major > Fix For: 3.1.0 > > Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch, > HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch, > HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.06.patch, > HIVE-19532.07.patch, HIVE-19532.08.patch, HIVE-19532.09.patch, > HIVE-19532.10.patch, HIVE-19532.11.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[ https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523289#comment-16523289 ] Steve Yeom edited comment on HIVE-19532 at 6/26/18 6:36 AM: Hey [~sershe] Do you think you can send me the differences? I mean code changes you made? Thanks, Steve. was (Author: steveyeom2017): Hey [~sershe] Do you think you can send me the differences? Thanks, Steve. > fix tests for master-txnstats branch > > > Key: HIVE-19532 > URL: https://issues.apache.org/jira/browse/HIVE-19532 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Steve Yeom >Assignee: Steve Yeom >Priority: Major > Fix For: 3.1.0 > > Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch, > HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch, > HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.06.patch, > HIVE-19532.07.patch, HIVE-19532.08.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[ https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516503#comment-16516503 ] Steve Yeom edited comment on HIVE-19532 at 6/19/18 1:03 AM: 1. pre-commit tests run results for patch 04 is not yet available. We have to wait. 2. I have checked several tests that failed for patch 03 but most (all out of sampled tests) of the sampled tests of non-explain.out-difference ran successfully in my environment. Also maybe the unwanted MetastoreConf.java changes for CachedStore testing may have caused metadata related tests or more to fail. The following tests came clean without an error in my environment: mvn test -Dtest=TestSparkPerfCliDriver -Dqfile=query18.q mvn test -Dtest=TestReplicationScenarios#testConcatenatePartitionedTable mvn test -Dtest=TestTezPerfCliDriver -Dqfile=query14.q mvn test -Dtest=TestUpdateDeleteSemanticAnalyzer#testInsertValuesPartitioned was (Author: steveyeom2017): 1. pre-commit tests run results for patch 04 is not yet available. We have to wait. 2. I have checked several tests that failed for patch 03 but most (all out of sampled tests) of the sampled tests of non-explain.out-difference ran successfully in my environment. So maybe the unwanted MetastoreConf.java changes for CachedStore testing may be related. > fix tests for master-txnstats branch > > > Key: HIVE-19532 > URL: https://issues.apache.org/jira/browse/HIVE-19532 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Steve Yeom >Assignee: Steve Yeom >Priority: Major > Fix For: 3.1.0 > > Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch, > HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch, > HIVE-19532.04.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (HIVE-19532) fix tests for master-txnstats branch
[ https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514299#comment-16514299 ] Sergey Shelukhin edited comment on HIVE-19532 at 6/15/18 8:19 PM: -- I've committed the 03 patch to master-txnstats branch for now. I will keep the JIRA open to 1) Run the tests. 2) Address the feedback on 03 patch. Please do all future work for transactional stats ON TOP OF master-txnstats branch, in separate patches. The epic patch to run the tests here should be made by diffing master with master-txnstats. I will periodically merge master to make sure it stays up to date; one can also merge locally just to produce a patch for tests. Given that the branch was just created, the 03 patch is good for now for a test run. The fix version for commits to the branch should be txnstats. We will bulk change it to 4.0/3.1 when we merge the branch. I'm going to clean up existing jiras and file smaller scope items. cc [~steveyeom2017] [~ekoifman] [~hagleitn] was (Author: sershe): I've committed the 03 patch to master-txnstats branch for now. I will keep the JIRA open to 1) Run the tests. 2) Address the feedback on 03 patch. Please do all future work for transactional stats ON TOP OF master-txnstats branch, in separate patches. The epic patch to run the tests here should be made by diffing master with master-txnstats. I will periodically merge master to make sure it stays up to date; one can also merge locally just to produce a patch for tests. Given that the branch was just created, the 03 patch is good for now for a test run. I'm going to clean up existing jiras and file smaller scope items. cc [~steveyeom2017] [~ekoifman] [~hagleitn] > fix tests for master-txnstats branch > > > Key: HIVE-19532 > URL: https://issues.apache.org/jira/browse/HIVE-19532 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Steve Yeom >Assignee: Steve Yeom >Priority: Major > Fix For: 3.1.0 > > Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch, > HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
