[ https://issues.apache.org/jira/browse/HIVE-23965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176406#comment-17176406 ]
Jesus Camacho Rodriguez edited comment on HIVE-23965 at 8/13/20, 3:57 PM: -------------------------------------------------------------------------- +1 on removing old driver, since the new one fixes issues with the existing one. I do not think having the old one around adds much value and updating all those q files will be a pain. [~zabetak], [~kgyrtkirk], if this PR is ready to be merged, I think the removal can be done in a follow-up. was (Author: jcamachorodriguez): +1 on removing old driver, since it fixes issues with the existing one. I do not think having the old one around adds much value and updating all those q files will be a pain. [~zabetak], [~kgyrtkirk], if this PR is ready to be merged, I think the removal can be done in a follow-up. > Improve plan regression tests using TPCDS30TB metastore dump and custom > configs > ------------------------------------------------------------------------------- > > Key: HIVE-23965 > URL: https://issues.apache.org/jira/browse/HIVE-23965 > Project: Hive > Issue Type: Improvement > Reporter: Stamatis Zampetakis > Assignee: Stamatis Zampetakis > Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > The existing regression tests (HIVE-12586) based on TPC-DS have certain > shortcomings: > The table statistics do not reflect cardinalities from a specific TPC-DS > scale factor (SF). Some tables are from a 30TB dataset, others from 200GB > dataset, and others from a 3GB dataset. This mix leads to plans that may > never appear when using an actual TPC-DS dataset. > The existing statistics do not contain information about partitions something > that can have a big impact on the resulting plans. > The existing regression tests rely on more or less on the default > configuration (hive-site.xml). In real-life scenarios though some of the > configurations differ and may impact the choices of the optimizer. > This issue aims to address the above shortcomings by using a curated > TPCDS30TB metastore dump along with some custom hive configurations. -- This message was sent by Atlassian Jira (v8.3.4#803005)