[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[ https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14585725#comment-14585725 ] Goun Na commented on HIVE-10542: No patch available for Hive 1.1? Full outer joins in tez produce incorrect results in certain cases -- Key: HIVE-10542 URL: https://issues.apache.org/jira/browse/HIVE-10542 Project: Hive Issue Type: Bug Components: Tez Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0 Reporter: Vikram Dixit K Assignee: Vikram Dixit K Priority: Blocker Fix For: 1.3.0, 2.0.0 Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch, HIVE-10542.3.patch, HIVE-10542.4.patch, HIVE-10542.5.patch, HIVE-10542.6.patch, HIVE-10542.7.patch, HIVE-10542.8.patch, HIVE-10542.9.patch If there is no records for one of the tables in the full outer join, we do not read the other input and end up not producing rows which we should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[
https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531968#comment-14531968
]
Hive QA commented on HIVE-10542:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12730893/HIVE-10542.9.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 8906 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.TestSQLStdHiveAccessControllerHS2.testConfigProcessing
org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.TestSQLStdHiveAccessControllerHS2.testConfigProcessingCustomSetWhitelistAppend
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3789/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3789/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3789/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12730893 - PreCommit-HIVE-TRUNK-Build
Full outer joins in tez produce incorrect results in certain cases
--
Key: HIVE-10542
URL: https://issues.apache.org/jira/browse/HIVE-10542
Project: Hive
Issue Type: Bug
Components: Tez
Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0
Reporter: Vikram Dixit K
Assignee: Vikram Dixit K
Priority: Blocker
Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch,
HIVE-10542.3.patch, HIVE-10542.4.patch, HIVE-10542.5.patch,
HIVE-10542.6.patch, HIVE-10542.7.patch, HIVE-10542.8.patch, HIVE-10542.9.patch
If there is no records for one of the tables in the full outer join, we do
not read the other input and end up not producing rows which we should be.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[
https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528253#comment-14528253
]
Hive QA commented on HIVE-10542:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12730374/HIVE-10542.5.patch
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 8894 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.TestSQLStdHiveAccessControllerHS2.testConfigProcessing
org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.TestSQLStdHiveAccessControllerHS2.testConfigProcessingCustomSetWhitelistAppend
org.apache.hive.jdbc.TestSSL.testSSLConnectionWithProperty
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3730/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3730/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3730/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12730374 - PreCommit-HIVE-TRUNK-Build
Full outer joins in tez produce incorrect results in certain cases
--
Key: HIVE-10542
URL: https://issues.apache.org/jira/browse/HIVE-10542
Project: Hive
Issue Type: Bug
Components: Tez
Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0
Reporter: Vikram Dixit K
Assignee: Vikram Dixit K
Priority: Blocker
Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch,
HIVE-10542.3.patch, HIVE-10542.4.patch, HIVE-10542.5.patch
If there is no records for one of the tables in the full outer join, we do
not read the other input and end up not producing rows which we should be.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[ https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527388#comment-14527388 ] Sushanth Sowmyan commented on HIVE-10542: - Added to precommit queue (we lost a bunch over the weekend). Assuming this passes, is this patch good to go? Full outer joins in tez produce incorrect results in certain cases -- Key: HIVE-10542 URL: https://issues.apache.org/jira/browse/HIVE-10542 Project: Hive Issue Type: Bug Components: Tez Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0 Reporter: Vikram Dixit K Assignee: Vikram Dixit K Priority: Blocker Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch, HIVE-10542.3.patch If there is no records for one of the tables in the full outer join, we do not read the other input and end up not producing rows which we should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[ https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527396#comment-14527396 ] Vikram Dixit K commented on HIVE-10542: --- Thanks! Yes. If it passes, it is good to go. Full outer joins in tez produce incorrect results in certain cases -- Key: HIVE-10542 URL: https://issues.apache.org/jira/browse/HIVE-10542 Project: Hive Issue Type: Bug Components: Tez Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0 Reporter: Vikram Dixit K Assignee: Vikram Dixit K Priority: Blocker Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch, HIVE-10542.3.patch If there is no records for one of the tables in the full outer join, we do not read the other input and end up not producing rows which we should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[ https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520414#comment-14520414 ] Gunther Hagleitner commented on HIVE-10542: --- Might make sense to add a test case for this too (a outer b inner c outer d - or something like that). Full outer joins in tez produce incorrect results in certain cases -- Key: HIVE-10542 URL: https://issues.apache.org/jira/browse/HIVE-10542 Project: Hive Issue Type: Bug Components: Tez Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0 Reporter: Vikram Dixit K Assignee: Vikram Dixit K Priority: Blocker Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch If there is no records for one of the tables in the full outer join, we do not read the other input and end up not producing rows which we should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[ https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520413#comment-14520413 ] Gunther Hagleitner commented on HIVE-10542: --- If you do it afterwards you also don't need the nothingTodDo flag. Full outer joins in tez produce incorrect results in certain cases -- Key: HIVE-10542 URL: https://issues.apache.org/jira/browse/HIVE-10542 Project: Hive Issue Type: Bug Components: Tez Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0 Reporter: Vikram Dixit K Assignee: Vikram Dixit K Priority: Blocker Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch If there is no records for one of the tables in the full outer join, we do not read the other input and end up not producing rows which we should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10542) Full outer joins in tez produce incorrect results in certain cases
[
https://issues.apache.org/jira/browse/HIVE-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520409#comment-14520409
]
Gunther Hagleitner commented on HIVE-10542:
---
{noformat}
boolean nothingToDo = false;
441 for (int i = 0; i fetchDone.length; i++) {
442 if (i == posBigTable) {
443 continue;
444 }
445 if (fetchInputAtClose.contains(i)) {
446 if (fetchDone[i] == false) {
447 fetchNextGroup((byte) i);
448 }
449 } else {
450 if (ret == null || ret.size() == 0) {
451 nothingToDo = true;
452 break;
453 }
454 }
455 }
456 if (nothingToDo) {
{noformat}
This loop seems wrong. I think you probably want to check all aliases. Right
now if you ever hit the else branch you might bail out of the loop not
considering the aliases after it.
Full outer joins in tez produce incorrect results in certain cases
--
Key: HIVE-10542
URL: https://issues.apache.org/jira/browse/HIVE-10542
Project: Hive
Issue Type: Bug
Components: Tez
Affects Versions: 1.0.0, 1.2.0, 1.1.0, 1.3.0
Reporter: Vikram Dixit K
Assignee: Vikram Dixit K
Priority: Blocker
Attachments: HIVE-10542.1.patch, HIVE-10542.2.patch
If there is no records for one of the tables in the full outer join, we do
not read the other input and end up not producing rows which we should be.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
