[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653305#comment-14653305
]
ASF GitHub Bot commented on HIVE-11190:
---
Github user sundapeng closed the pull reque
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624240#comment-14624240
]
Dapeng Sun commented on HIVE-11190:
---
Thank [~thejas] and [~Ferd] for your review.
> No
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622589#comment-14622589
]
Thejas M Nair commented on HIVE-11190:
--
+1
> No prompting info or warning provided w
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622237#comment-14622237
]
Hive QA commented on HIVE-11190:
{color:green}Overall{color}: +1 all checks pass
Here a
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621744#comment-14621744
]
Dapeng Sun commented on HIVE-11190:
---
Update patch according [~thejas] 's comments.
> No
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621665#comment-14621665
]
Thejas M Nair commented on HIVE-11190:
--
I didn't realize the config description alrea
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621655#comment-14621655
]
Dapeng Sun commented on HIVE-11190:
---
Thank you for your comments, [~thejas] .
{quote}
r
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620901#comment-14620901
]
Thejas M Nair commented on HIVE-11190:
--
[~dapengsun] Thanks for the patch, this makes
[
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620648#comment-14620648
]
Hive QA commented on HIVE-11190:
{color:green}Overall{color}: +1 all checks pass
Here a