[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-31 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308845#comment-15308845 ] Ashutosh Chauhan commented on HIVE-13149: - I think this is pretty useful improvement.

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-26 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302103#comment-15302103 ] Aihua Xu commented on HIVE-13149: - Target version is removed. It's an improvement so not necessary for

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-25 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300677#comment-15300677 ] Jimmy Xiang commented on HIVE-13149: Thanks for the explanation. +1 > Remove some unnecessary HMS

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-25 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300366#comment-15300366 ] Aihua Xu commented on HIVE-13149: - The setup method would create a connection for each test while for some

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-25 Thread Jimmy Xiang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300328#comment-15300328 ] Jimmy Xiang commented on HIVE-13149: In your fix to TestJdbcWithMiniHS2, you removed the setup method,

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-24 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298923#comment-15298923 ] Aihua Xu commented on HIVE-13149: - Those tests don't seem to be related. [~ctang.ma] I just fixed the

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-24 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298910#comment-15298910 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-05-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283749#comment-15283749 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-13 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239170#comment-15239170 ] Aihua Xu commented on HIVE-13149: - [~thejas] I can't think of the reason why it gets affected. I remember

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-13 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238788#comment-15238788 ] Thejas M Nair commented on HIVE-13149: -- Created HIVE-13499 for the test hanging issue. [~aihuaxu]

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-12 Thread Thejas M Nair (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238342#comment-15238342 ] Thejas M Nair commented on HIVE-13149: -- This is causing the timeouts seen in last few says with

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-11 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235268#comment-15235268 ] Chaoyu Tang commented on HIVE-13149: Thanks [~aihuaxu] for the explanation, the change looks good to

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-06 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229070#comment-15229070 ] Aihua Xu commented on HIVE-13149: - Those tests actually are not related. Will reattach the same patch to

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227965#comment-15227965 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-05 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227466#comment-15227466 ] Aihua Xu commented on HIVE-13149: - [~ctang.ma] Agree that making copy of HiveConf is expensive so this

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-05 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227197#comment-15227197 ] Chaoyu Tang commented on HIVE-13149: Yeah, I also think the HiveConf copying is not necessary since

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-05 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227087#comment-15227087 ] Szehon Ho commented on HIVE-13149: -- +1. Was chatting with Aihua , the copying of the hiveconf to get it

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-05 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226333#comment-15226333 ] Aihua Xu commented on HIVE-13149: - [~szehon] I uploaded a new patch which breaks the line into two lines

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-04-04 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15225190#comment-15225190 ] Szehon Ho commented on HIVE-13149: -- Seems good to me. Just a nit, for this line 'this.conf = conf =

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-29 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217428#comment-15217428 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214055#comment-15214055 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-22 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207731#comment-15207731 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-20 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203622#comment-15203622 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-19 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201454#comment-15201454 ] Aihua Xu commented on HIVE-13149: - Attached patch-5: hbase test case failed because the conf was not

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-15 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195622#comment-15195622 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-08 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184987#comment-15184987 ] Aihua Xu commented on HIVE-13149: - I will investigate those test failures. They are related to the change.

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-07 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183097#comment-15183097 ] Aihua Xu commented on HIVE-13149: - >From the failed unit tests, I think we need such fix to do the real

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-06 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182049#comment-15182049 ] Szehon Ho commented on HIVE-13149: -- +1 latest patch. Just curious why the QTestUtil changed? > Remove

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-03 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178548#comment-15178548 ] Aihua Xu commented on HIVE-13149: - 1. Sure. I will change it back. 2. Even if the tasks are on the same

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-03 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178414#comment-15178414 ] Szehon Ho commented on HIVE-13149: -- 1. Yea I think the right fix would be to not have the method 'get'

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-03 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177892#comment-15177892 ] Aihua Xu commented on HIVE-13149: - Thanks [~szehon] to review the code. 1. get(Conf) and setConf(Conf)

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-02 Thread Szehon Ho (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176744#comment-15176744 ] Szehon Ho commented on HIVE-13149: -- Hey Aihua the fix looks good.. I'm just wondering some questions..

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-02 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176692#comment-15176692 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-03-01 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174452#comment-15174452 ] Aihua Xu commented on HIVE-13149: - Attached the patch-2: to fix the issue observed from the unit tests. We

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170733#comment-15170733 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-26 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169974#comment-15169974 ] Aihua Xu commented on HIVE-13149: - You mean HMS connections? Yeah, they will be closed. Session one is

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-26 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169902#comment-15169902 ] Chaoyu Tang commented on HIVE-13149: It might not be proper to share the HMS connection opened in HS2

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-26 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169492#comment-15169492 ] Aihua Xu commented on HIVE-13149: - That's is about performance. We actually can share one HMS connection

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-26 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169350#comment-15169350 ] Chaoyu Tang commented on HIVE-13149: [~aihuaxu] Why not to pass the connection to taskRunner so that

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-26 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169089#comment-15169089 ] Aihua Xu commented on HIVE-13149: - Those tests don't fail locally. I will reattach the patch to see how it

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-25 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168060#comment-15168060 ] Hive QA commented on HIVE-13149: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-13149) Remove some unnecessary HMS connections from HS2

2016-02-25 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167695#comment-15167695 ] Aihua Xu commented on HIVE-13149: - [~jxiang], [~ctang.ma], [~ngangam] You have worked on the leaking