[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-19 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589285#comment-15589285 ] Xuefu Zhang commented on HIVE-13423: +1 > Handle the overflow case for decimal dataty

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-19 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589253#comment-15589253 ] Chaoyu Tang commented on HIVE-13423: Sound good to me as well. > Handle the overflow

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-19 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589243#comment-15589243 ] Xuefu Zhang commented on HIVE-13423: This sounds good to me. I'd +1 on this unless [~c

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-19 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589241#comment-15589241 ] Xuefu Zhang commented on HIVE-13423: This sounds good to me. I'd +1 on this unless [~c

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-19 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589113#comment-15589113 ] Aihua Xu commented on HIVE-13423: - Doesn't seem to have standard for that. I feel we can

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-17 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583055#comment-15583055 ] Xuefu Zhang commented on HIVE-13423: [~ctang.ma]/[~aihuaxu], as to sacrificing scale f

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-17 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582953#comment-15582953 ] Aihua Xu commented on HIVE-13423: - Does Oracle truncate? Seems hive follows more on Oracle

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-17 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582946#comment-15582946 ] Aihua Xu commented on HIVE-13423: - Yes. ArrayIndexOutOfBoundsException is because of the o

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-17 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582931#comment-15582931 ] Xuefu Zhang commented on HIVE-13423: [~aihuaxu], thanks for looking into this. Do we k

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-17 Thread Chaoyu Tang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582911#comment-15582911 ] Chaoyu Tang commented on HIVE-13423: [~aihuaxu] The patch looks good. The issue might

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-17 Thread Aihua Xu (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582458#comment-15582458 ] Aihua Xu commented on HIVE-13423: - [~xuefuz] and [~ctang.ma] Initially I remember we had i

[jira] [Commented] (HIVE-13423) Handle the overflow case for decimal datatype for sum()

2016-10-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577232#comment-15577232 ] Hive QA commented on HIVE-13423: Here are the results of testing the latest attachment: