[jira] [Commented] (HIVE-13604) Do not log AlreadyExistsException when "IF NOT EXISTS" is used.
[ https://issues.apache.org/jira/browse/HIVE-13604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400683#comment-15400683 ] Hive QA commented on HIVE-13604: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12820724/HIVE-13604.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10386 tests executed *Failed tests:* {noformat} TestMsgBusConnection - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_nullable_union org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_database org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_12 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_subquery_multiinsert org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_avro_non_nullable_union org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.stringifyValidTxns org.apache.hadoop.hive.metastore.TestHiveMetaStoreTxns.testTxnRange {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/697/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/697/console Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-697/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12820724 - PreCommit-HIVE-MASTER-Build > Do not log AlreadyExistsException when "IF NOT EXISTS" is used. > --- > > Key: HIVE-13604 > URL: https://issues.apache.org/jira/browse/HIVE-13604 > Project: Hive > Issue Type: Bug > Components: Logging >Affects Versions: 2.0.0 >Reporter: Yuriy Plysyuk >Assignee: Chinna Rao Lalam >Priority: Trivial > Attachments: HIVE-13604.1.patch, HIVE-13604.2.patch, HIVE-13604.patch > > > When trying to create view that exists with statement: > CREATE VIEW IF NOT EXISTS dummy_table ... > Next error is logged: > ERROR RetryingHMSHandler:190 - AlreadyExistsException(message:Table > dummy_view already exists) > at > org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.create_table_core(HiveMetaStore.java:1296) > ... > The same when creating schema using: > CREATE SCHEMA IF NOT EXISTS ... > Error should not be logged as it confuses. > For > CREATE TABLE IF NOT EXISTS ... > it works fine. I checked that there is code to handle this in: > org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeCreateTable > // check for existence of table > if (ifNotExists) { > try { > Table table = getTable(qualifiedTabName, false); > if (table != null) { // table exists > return null; > } > could you please add similar check for creating views and schema? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-13604) Do not log AlreadyExistsException when "IF NOT EXISTS" is used.
[ https://issues.apache.org/jira/browse/HIVE-13604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392822#comment-15392822 ] Hive QA commented on HIVE-13604: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12819930/HIVE-13604.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 306 failed/errored test(s), 10337 tests executed *Failed tests:* {noformat} TestMsgBusConnection - did not produce a TEST-*.xml file TestSessionCleanup - did not produce a TEST-*.xml file TestSessionManagerMetrics - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_acid_globallimit org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_add_part_exist org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_change_db_location org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_char1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_db_owner org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_partition_coltype org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_table org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_skewed_table org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_invalidate_column_stats org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_varchar1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_view_as_select org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_view_rename org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_union org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_archive_multi org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_owner_actions_db org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cbo_rp_insert org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_func1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_or_replace_view org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_with_constraints org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ctas_uses_database_location org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cteViews org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cte_mat_5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_database org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_database_drop org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_database_location org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_database_properties org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_dbtxnmgr_compact3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_dbtxnmgr_ddl1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_dbtxnmgr_query5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_database org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_database_json org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_syntax org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_display_colstats_tbllvl org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_drop_database_removes_partition_dirs org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_drop_multi_partitions org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exchange_partition org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_00_nonpart_empty org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_01_nonpart org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_02_00_part_empty org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_02_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_03_nonpart_over_compat org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_04_all_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_04_evolved_parts org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_05_some_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_06_one_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_07_all_part_over_nonoverlap org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_08_nonpart_rename org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_09_part_spec_nonoverlap org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_10_external_managed org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_11_managed_external org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_12_external_location