[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307803#comment-16307803
]
Peter Vary commented on HIVE-14146:
---
[~trinevo]: This is fixed only in 2.3.0 and not backported to 1.x
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300051#comment-16300051
]
Marcin Łuczyński commented on HIVE-14146:
-
I got a customer with Hive 1.2.1.2.4 who has the same
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549184#comment-15549184
]
Peter Vary commented on HIVE-14146:
---
[~aihuaxu] I have checked those lines you mentioned.
The difference
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546066#comment-15546066
]
Aihua Xu commented on HIVE-14146:
-
[~pvary] I was about to commit the patch. But I noticed that in some
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533280#comment-15533280
]
Aihua Xu commented on HIVE-14146:
-
+1. The patch looks good to me.
> Column comments with "\n" character
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526568#comment-15526568
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523506#comment-15523506
]
Aihua Xu commented on HIVE-14146:
-
[~pvary] Do you have the latest patch for reviewing? Can you attach a
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429068#comment-15429068
]
Peter Vary commented on HIVE-14146:
---
It might be confusing, but here is what the patch changes:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406674#comment-15406674
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404997#comment-15404997
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403267#comment-15403267
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402337#comment-15402337
]
Aihua Xu commented on HIVE-14146:
-
I see. Sure. Seems reasonable to make such change.
> Column comments
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402245#comment-15402245
]
Peter Vary commented on HIVE-14146:
---
I rebased and run the qtests. It seems ok now - we will see the
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402216#comment-15402216
]
Aihua Xu commented on HIVE-14146:
-
[~pvary] Yeah. You may need to rebase to the latest change. Do you need
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15401055#comment-15401055
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400036#comment-15400036
]
Peter Vary commented on HIVE-14146:
---
[~aihuaxu] Checked, and found the following:
- Beeline - when using
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399610#comment-15399610
]
Aihua Xu commented on HIVE-14146:
-
>From the test case result. seems we still have some comments not
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399532#comment-15399532
]
Sergio Peña commented on HIVE-14146:
Latest patch looks good.
+1
Wait for HiveQa before commit.
>
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370453#comment-15370453
]
Peter Vary commented on HIVE-14146:
---
Review request created: https://reviews.apache.org/r/49882/
>
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370422#comment-15370422
]
Peter Vary commented on HIVE-14146:
---
Checked the test results and these are not related.
> Column
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368241#comment-15368241
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367757#comment-15367757
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366154#comment-15366154
]
Aihua Xu commented on HIVE-14146:
-
[~pvary] I notice that we are calling
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15364329#comment-15364329
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363417#comment-15363417
]
Hive QA commented on HIVE-14146:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362693#comment-15362693
]
Peter Vary commented on HIVE-14146:
---
Good catch [~aihuaxu]. I realised that myself, and in the process
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362648#comment-15362648
]
Aihua Xu commented on HIVE-14146:
-
[~pvary] Seems "show create table" output doesn't escape the "\n" in
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362599#comment-15362599
]
Peter Vary commented on HIVE-14146:
---
Thanks [~niklaus.xiao].
For human use, your solution is perfect,
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362446#comment-15362446
]
niklaus xiao commented on HIVE-14146:
-
You can try this:
{code}
desc pretty commtest;
[
https://issues.apache.org/jira/browse/HIVE-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358959#comment-15358959
]
Peter Vary commented on HIVE-14146:
---
Solution depends on the HIVE-14013 patch, since I think it would be
30 matches
Mail list logo
