[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566958#comment-15566958
]
Daniel Dai commented on HIVE-14690:
---
Need to mention there is no way to add unit test. The exception
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15564081#comment-15564081
]
Thejas M Nair commented on HIVE-14690:
--
I think setting isStarted=true in beginning of function is
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494772#comment-15494772
]
Daniel Dai commented on HIVE-14690:
---
Agree, but seems it is a trivial savings, and I'd like to trade in
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475480#comment-15475480
]
Tao Li commented on HIVE-14690:
---
bq.The code outside the synchronization block will be trivial, right?
This
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475261#comment-15475261
]
Daniel Dai commented on HIVE-14690:
---
Tao,
1. The problem is there is multiple exits in the code and it
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469584#comment-15469584
]
Tao Li commented on HIVE-14690:
---
I have 2 more comments:
1. Should we set startSs.isStarted to true by the
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469314#comment-15469314
]
Hive QA commented on HIVE-14690:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469182#comment-15469182
]
Daniel Dai commented on HIVE-14690:
---
I want to start the session only once. Yes start will be invoked
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469031#comment-15469031
]
Tao Li commented on HIVE-14690:
---
Are we trying to avoid concurrent start() calls from multiple threads? If
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457659#comment-15457659
]
Daniel Dai commented on HIVE-14690:
---
Yes, seems to be. But that needs more test to verify everything is
[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457607#comment-15457607
]
Thejas M Nair commented on HIVE-14690:
--
It seems like we shouldn't be doing what is done in
11 matches
Mail list logo
