[jira] [Commented] (HIVE-14960) Improve the stability of TestNotificationListener
[
https://issues.apache.org/jira/browse/HIVE-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751515#comment-15751515
]
Marta Kuczora commented on HIVE-14960:
--
Thanks a lot for committing the patch.
> Improve the stability of TestNotificationListener
> -
>
> Key: HIVE-14960
> URL: https://issues.apache.org/jira/browse/HIVE-14960
> Project: Hive
> Issue Type: Bug
> Components: Test
>Affects Versions: 2.1.0
>Reporter: Marta Kuczora
>Assignee: Marta Kuczora
>Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-14960.2.patch, HIVE-14960.patch
>
>
> The TestNotificationListener.testAMQListener test case fails occasionally
> with the following error:
> {noformat}
> Error Message
> expected:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE, DROP_DATABASE]> but
> was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> Stacktrace
> java.lang.AssertionError: expected:<[CREATE_DATABASE, CREATE_TABLE,
> ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE,
> DROP_DATABASE]> but was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION,
> ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hive.hcatalog.listener.TestNotificationListener.tearDown(TestNotificationListener.java:114)
> {noformat}
> This error can happen if the testAMQListener method is completed before the
> last DROP_TABLE message got processed and put to the actualMessages list by
> the onMessage method. This can happen if there is a small delay in receiving
> the message, since the message receiving is not synchronized with the
> testAMQListener method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14960) Improve the stability of TestNotificationListener
[
https://issues.apache.org/jira/browse/HIVE-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742035#comment-15742035
]
Aihua Xu commented on HIVE-14960:
-
Seems I forgot to +1 although reviewed a week ago.
> Improve the stability of TestNotificationListener
> -
>
> Key: HIVE-14960
> URL: https://issues.apache.org/jira/browse/HIVE-14960
> Project: Hive
> Issue Type: Bug
> Components: Test
>Affects Versions: 2.1.0
>Reporter: Marta Kuczora
>Assignee: Marta Kuczora
>Priority: Minor
> Attachments: HIVE-14960.2.patch, HIVE-14960.patch
>
>
> The TestNotificationListener.testAMQListener test case fails occasionally
> with the following error:
> {noformat}
> Error Message
> expected:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE, DROP_DATABASE]> but
> was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> Stacktrace
> java.lang.AssertionError: expected:<[CREATE_DATABASE, CREATE_TABLE,
> ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE,
> DROP_DATABASE]> but was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION,
> ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hive.hcatalog.listener.TestNotificationListener.tearDown(TestNotificationListener.java:114)
> {noformat}
> This error can happen if the testAMQListener method is completed before the
> last DROP_TABLE message got processed and put to the actualMessages list by
> the onMessage method. This can happen if there is a small delay in receiving
> the message, since the message receiving is not synchronized with the
> testAMQListener method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14960) Improve the stability of TestNotificationListener
[
https://issues.apache.org/jira/browse/HIVE-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643910#comment-15643910
]
Marta Kuczora commented on HIVE-14960:
--
The failing tests are not related to the changes in the patch, since it only
affects the TestNotificationListener test.
> Improve the stability of TestNotificationListener
> -
>
> Key: HIVE-14960
> URL: https://issues.apache.org/jira/browse/HIVE-14960
> Project: Hive
> Issue Type: Bug
> Components: Test
>Affects Versions: 2.1.0
>Reporter: Marta Kuczora
>Assignee: Marta Kuczora
>Priority: Minor
> Attachments: HIVE-14960.2.patch, HIVE-14960.patch
>
>
> The TestNotificationListener.testAMQListener test case fails occasionally
> with the following error:
> {noformat}
> Error Message
> expected:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE, DROP_DATABASE]> but
> was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> Stacktrace
> java.lang.AssertionError: expected:<[CREATE_DATABASE, CREATE_TABLE,
> ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE,
> DROP_DATABASE]> but was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION,
> ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hive.hcatalog.listener.TestNotificationListener.tearDown(TestNotificationListener.java:114)
> {noformat}
> This error can happen if the testAMQListener method is completed before the
> last DROP_TABLE message got processed and put to the actualMessages list by
> the onMessage method. This can happen if there is a small delay in receiving
> the message, since the message receiving is not synchronized with the
> testAMQListener method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14960) Improve the stability of TestNotificationListener
[
https://issues.apache.org/jira/browse/HIVE-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643901#comment-15643901
]
Hive QA commented on HIVE-14960:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12837713/HIVE-14960.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10628 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[index_auto_mult_tables]
(batchId=77)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats]
(batchId=145)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1997/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1997/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1997/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12837713 - PreCommit-HIVE-Build
> Improve the stability of TestNotificationListener
> -
>
> Key: HIVE-14960
> URL: https://issues.apache.org/jira/browse/HIVE-14960
> Project: Hive
> Issue Type: Bug
> Components: Test
>Affects Versions: 2.1.0
>Reporter: Marta Kuczora
>Assignee: Marta Kuczora
>Priority: Minor
> Attachments: HIVE-14960.2.patch, HIVE-14960.patch
>
>
> The TestNotificationListener.testAMQListener test case fails occasionally
> with the following error:
> {noformat}
> Error Message
> expected:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE, DROP_DATABASE]> but
> was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> Stacktrace
> java.lang.AssertionError: expected:<[CREATE_DATABASE, CREATE_TABLE,
> ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE,
> DROP_DATABASE]> but was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION,
> ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hive.hcatalog.listener.TestNotificationListener.tearDown(TestNotificationListener.java:114)
> {noformat}
> This error can happen if the testAMQListener method is completed before the
> last DROP_TABLE message got processed and put to the actualMessages list by
> the onMessage method. This can happen if there is a small delay in receiving
> the message, since the message receiving is not synchronized with the
> testAMQListener method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14960) Improve the stability of TestNotificationListener
[
https://issues.apache.org/jira/browse/HIVE-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633187#comment-15633187
]
Hive QA commented on HIVE-14960:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12836865/HIVE-14960.2.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1947/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1947/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1947/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2016-11-03 15:39:07.827
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
+ MAVEN_OPTS='-Xmx1g -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-1947/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2016-11-03 15:39:07.829
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 345353c HIVE-15039: A better job monitor console output for HoS
(Rui reviewed by Xuefu and Ferdinand)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 345353c HIVE-15039: A better job monitor console output for HoS
(Rui reviewed by Xuefu and Ferdinand)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2016-11-03 15:39:08.703
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
Going to apply patch with: patch -p0
patching file
hcatalog/server-extensions/src/test/java/org/apache/hive/hcatalog/listener/TestNotificationListener.java
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
ANTLR Parser Generator Version 3.4
org/apache/hadoop/hive/metastore/parser/Filter.g
DataNucleus Enhancer (version 4.1.6) for API "JDO"
DataNucleus Enhancer : Classpath
>> /usr/share/maven/boot/plexus-classworlds-2.x.jar
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDatabase
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MFieldSchema
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MType
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTable
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MConstraint
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MSerDeInfo
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MOrder
ENHANCED (Persistable) :
org.apache.hadoop.hive.metastore.model.MColumnDescriptor
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MStringList
ENHANCED (Persistable) :
org.apache.hadoop.hive.metastore.model.MStorageDescriptor
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartition
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MIndex
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MRole
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MRoleMap
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MGlobalPrivilege
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDBPrivilege
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTablePrivilege
ENHANCED (Persistable) :
org.apache.hadoop.hive.metastore.model.MPartitionPrivilege
ENHANCED (Persistable) :
org.apache.hadoop.hive.metastore.model.MTableColumnPrivilege
ENHANCED (Persistable) :
org.apache.hadoop.hive.metastore.model.MPartitionColumnPrivilege
ENHANCED (Persistable) :
[jira] [Commented] (HIVE-14960) Improve the stability of TestNotificationListener
[
https://issues.apache.org/jira/browse/HIVE-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15614992#comment-15614992
]
Marta Kuczora commented on HIVE-14960:
--
The patch is attached.
Created review on Review Board.
> Improve the stability of TestNotificationListener
> -
>
> Key: HIVE-14960
> URL: https://issues.apache.org/jira/browse/HIVE-14960
> Project: Hive
> Issue Type: Bug
> Components: Test
>Affects Versions: 2.1.0
>Reporter: Marta Kuczora
>Assignee: Marta Kuczora
>Priority: Minor
> Attachments: HIVE-14960.patch
>
>
> The TestNotificationListener.testAMQListener test case fails occasionally
> with the following error:
> {noformat}
> Error Message
> expected:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE, DROP_DATABASE]> but
> was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION, ALTER_PARTITION,
> DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> Stacktrace
> java.lang.AssertionError: expected:<[CREATE_DATABASE, CREATE_TABLE,
> ADD_PARTITION, ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE,
> DROP_DATABASE]> but was:<[CREATE_DATABASE, CREATE_TABLE, ADD_PARTITION,
> ALTER_PARTITION, DROP_PARTITION, ALTER_TABLE, DROP_TABLE]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.hive.hcatalog.listener.TestNotificationListener.tearDown(TestNotificationListener.java:114)
> {noformat}
> This error can happen if the testAMQListener method is completed before the
> last DROP_TABLE message got processed and put to the actualMessages list by
> the onMessage method. This can happen if there is a small delay in receiving
> the message, since the message receiving is not synchronized with the
> testAMQListener method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
