[jira] [Commented] (HIVE-15096) hplsql registerUDF conflicts with pom.xml

2016-11-01 Thread Dmitry Tolpeko (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624802#comment-15624802
 ] 

Dmitry Tolpeko commented on HIVE-15096:
---

+1 looks good, thanks.

> hplsql registerUDF conflicts with pom.xml
> -
>
> Key: HIVE-15096
> URL: https://issues.apache.org/jira/browse/HIVE-15096
> Project: Hive
>  Issue Type: Bug
>  Components: hpl/sql
>Affects Versions: 2.0.0, 2.1.0, 2.0.1
>Reporter: Fei Hui
> Fix For: 2.2.0
>
> Attachments: HIVE-15096.1.patch, HIVE-15096.patch
>
>
> in hplsql code, registerUDF code is
> sql.add("ADD JAR " + dir + "hplsql.jar");
> sql.add("ADD JAR " + dir + "antlr-runtime-4.5.jar");
> sql.add("ADD FILE " + dir + Conf.SITE_XML);
> but pom configufation is
>   
> org.apache.hive
> hive
> 2.2.0-SNAPSHOT
> ../pom.xml
>   
>   hive-hplsql
>   jar
>   Hive HPL/SQL
> 
>org.antlr
>antlr4-runtime
>4.5
> 
> when run hplsql , errors occur as below
>  Error while processing statement: 
> /opt/apps/apache-hive-2.0.0-bin/lib/hplsql.jar does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15096) hplsql registerUDF conflicts with pom.xml

2016-10-31 Thread Fei Hui (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624446#comment-15624446
 ] 

Fei Hui commented on HIVE-15096:


update the patch, remove the hardcode version 2.2.0-SNAPSHOT.
can you review it again? give suggestions

> hplsql registerUDF conflicts with pom.xml
> -
>
> Key: HIVE-15096
> URL: https://issues.apache.org/jira/browse/HIVE-15096
> Project: Hive
>  Issue Type: Bug
>  Components: hpl/sql
>Affects Versions: 2.0.0, 2.1.0, 2.0.1
>Reporter: Fei Hui
> Fix For: 2.2.0
>
> Attachments: HIVE-15096.1.patch, HIVE-15096.patch
>
>
> in hplsql code, registerUDF code is
> sql.add("ADD JAR " + dir + "hplsql.jar");
> sql.add("ADD JAR " + dir + "antlr-runtime-4.5.jar");
> sql.add("ADD FILE " + dir + Conf.SITE_XML);
> but pom configufation is
>   
> org.apache.hive
> hive
> 2.2.0-SNAPSHOT
> ../pom.xml
>   
>   hive-hplsql
>   jar
>   Hive HPL/SQL
> 
>org.antlr
>antlr4-runtime
>4.5
> 
> when run hplsql , errors occur as below
>  Error while processing statement: 
> /opt/apps/apache-hive-2.0.0-bin/lib/hplsql.jar does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15096) hplsql registerUDF conflicts with pom.xml

2016-10-31 Thread Fei Hui (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624107#comment-15624107
 ] 

Fei Hui commented on HIVE-15096:


there is no hplsql.jar with hive release. users do not change this file if they 
have no source code

> hplsql registerUDF conflicts with pom.xml
> -
>
> Key: HIVE-15096
> URL: https://issues.apache.org/jira/browse/HIVE-15096
> Project: Hive
>  Issue Type: Bug
>  Components: hpl/sql
>Affects Versions: 2.0.0, 2.1.0, 2.0.1
>Reporter: Fei Hui
> Fix For: 2.2.0
>
> Attachments: HIVE-15096.patch
>
>
> in hplsql code, registerUDF code is
> sql.add("ADD JAR " + dir + "hplsql.jar");
> sql.add("ADD JAR " + dir + "antlr-runtime-4.5.jar");
> sql.add("ADD FILE " + dir + Conf.SITE_XML);
> but pom configufation is
>   
> org.apache.hive
> hive
> 2.2.0-SNAPSHOT
> ../pom.xml
>   
>   hive-hplsql
>   jar
>   Hive HPL/SQL
> 
>org.antlr
>antlr4-runtime
>4.5
> 
> when run hplsql , errors occur as below
>  Error while processing statement: 
> /opt/apps/apache-hive-2.0.0-bin/lib/hplsql.jar does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15096) hplsql registerUDF conflicts with pom.xml

2016-10-31 Thread Fei Hui (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624106#comment-15624106
 ] 

Fei Hui commented on HIVE-15096:


there is no hplsql.jar with hive release. users do not change this file if they 
have no source code

> hplsql registerUDF conflicts with pom.xml
> -
>
> Key: HIVE-15096
> URL: https://issues.apache.org/jira/browse/HIVE-15096
> Project: Hive
>  Issue Type: Bug
>  Components: hpl/sql
>Affects Versions: 2.0.0, 2.1.0, 2.0.1
>Reporter: Fei Hui
> Fix For: 2.2.0
>
> Attachments: HIVE-15096.patch
>
>
> in hplsql code, registerUDF code is
> sql.add("ADD JAR " + dir + "hplsql.jar");
> sql.add("ADD JAR " + dir + "antlr-runtime-4.5.jar");
> sql.add("ADD FILE " + dir + Conf.SITE_XML);
> but pom configufation is
>   
> org.apache.hive
> hive
> 2.2.0-SNAPSHOT
> ../pom.xml
>   
>   hive-hplsql
>   jar
>   Hive HPL/SQL
> 
>org.antlr
>antlr4-runtime
>4.5
> 
> when run hplsql , errors occur as below
>  Error while processing statement: 
> /opt/apps/apache-hive-2.0.0-bin/lib/hplsql.jar does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15096) hplsql registerUDF conflicts with pom.xml

2016-10-31 Thread Dmitry Tolpeko (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621622#comment-15621622
 ] 

Dmitry Tolpeko commented on HIVE-15096:
---

-1 why to hardcode the version hive-hplsql-2.2.0-SNAPSHOT.jar 
you will need to change this file with every Hive realease.

> hplsql registerUDF conflicts with pom.xml
> -
>
> Key: HIVE-15096
> URL: https://issues.apache.org/jira/browse/HIVE-15096
> Project: Hive
>  Issue Type: Bug
>  Components: hpl/sql
>Affects Versions: 2.0.0, 2.1.0, 2.0.1
>Reporter: Fei Hui
> Fix For: 2.2.0
>
> Attachments: HIVE-15096.patch
>
>
> in hplsql code, registerUDF code is
> sql.add("ADD JAR " + dir + "hplsql.jar");
> sql.add("ADD JAR " + dir + "antlr-runtime-4.5.jar");
> sql.add("ADD FILE " + dir + Conf.SITE_XML);
> but pom configufation is
>   
> org.apache.hive
> hive
> 2.2.0-SNAPSHOT
> ../pom.xml
>   
>   hive-hplsql
>   jar
>   Hive HPL/SQL
> 
>org.antlr
>antlr4-runtime
>4.5
> 
> when run hplsql , errors occur as below
>  Error while processing statement: 
> /opt/apps/apache-hive-2.0.0-bin/lib/hplsql.jar does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15096) hplsql registerUDF conflicts with pom.xml

2016-10-31 Thread Ferdinand Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621397#comment-15621397
 ] 

Ferdinand Xu commented on HIVE-15096:
-

LGTM +1 pending to the test.

> hplsql registerUDF conflicts with pom.xml
> -
>
> Key: HIVE-15096
> URL: https://issues.apache.org/jira/browse/HIVE-15096
> Project: Hive
>  Issue Type: Bug
>  Components: hpl/sql
>Affects Versions: 2.0.0, 2.1.0, 2.0.1
>Reporter: Fei Hui
> Fix For: 2.2.0
>
> Attachments: HIVE-15096.patch
>
>
> in hplsql code, registerUDF code is
> sql.add("ADD JAR " + dir + "hplsql.jar");
> sql.add("ADD JAR " + dir + "antlr-runtime-4.5.jar");
> sql.add("ADD FILE " + dir + Conf.SITE_XML);
> but pom configufation is
>   
> org.apache.hive
> hive
> 2.2.0-SNAPSHOT
> ../pom.xml
>   
>   hive-hplsql
>   jar
>   Hive HPL/SQL
> 
>org.antlr
>antlr4-runtime
>4.5
> 
> when run hplsql , errors occur as below
>  Error while processing statement: 
> /opt/apps/apache-hive-2.0.0-bin/lib/hplsql.jar does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15096) hplsql registerUDF conflicts with pom.xml

2016-10-28 Thread Fei Hui (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617292#comment-15617292
 ] 

Fei Hui commented on HIVE-15096:


anyone review it？

> hplsql registerUDF conflicts with pom.xml
> -
>
> Key: HIVE-15096
> URL: https://issues.apache.org/jira/browse/HIVE-15096
> Project: Hive
>  Issue Type: Bug
>  Components: hpl/sql
>Affects Versions: 2.0.0, 2.1.0, 2.0.1
>Reporter: Fei Hui
>Assignee: Fei Hui
> Fix For: 2.2.0
>
>
> in hplsql code, registerUDF code is
> sql.add("ADD JAR " + dir + "hplsql.jar");
> sql.add("ADD JAR " + dir + "antlr-runtime-4.5.jar");
> sql.add("ADD FILE " + dir + Conf.SITE_XML);
> but pom configufation is
>   
> org.apache.hive
> hive
> 2.2.0-SNAPSHOT
> ../pom.xml
>   
>   hive-hplsql
>   jar
>   Hive HPL/SQL
> 
>org.antlr
>antlr4-runtime
>4.5
> 
> when run hplsql , errors occur as below
>  Error while processing statement: 
> /opt/apps/apache-hive-2.0.0-bin/lib/hplsql.jar does not exist



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)