[jira] [Commented] (HIVE-15099) PTFOperator.PTFInvocation didn't properly reset the input partition

2016-10-31 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623870#comment-15623870
 ] 

Ashutosh Chauhan commented on HIVE-15099:
-

+1

> PTFOperator.PTFInvocation didn't properly reset the input partition
> ---
>
> Key: HIVE-15099
> URL: https://issues.apache.org/jira/browse/HIVE-15099
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, PTF-Windowing
>Affects Versions: 1.3.0, 1.2.1, 2.1.0, 2.2.0
>Reporter: Wei Zheng
>Assignee: Wei Zheng
> Attachments: HIVE-15099.1.patch
>
>
> There is an issue with PTFOperator.PTFInvocation where the inputPart is not 
> reset properly. The inputPart has been closed and its content (member 
> variables) has been cleaned up, but since itself is not nullified, it's 
> reused in the next round and caused NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15099) PTFOperator.PTFInvocation didn't properly reset the input partition

2016-10-31 Thread Wei Zheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623868#comment-15623868
 ] 

Wei Zheng commented on HIVE-15099:
--

The problematic plan can only be reproduced with specific environment and 
dataset

> PTFOperator.PTFInvocation didn't properly reset the input partition
> ---
>
> Key: HIVE-15099
> URL: https://issues.apache.org/jira/browse/HIVE-15099
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, PTF-Windowing
>Affects Versions: 1.3.0, 1.2.1, 2.1.0, 2.2.0
>Reporter: Wei Zheng
>Assignee: Wei Zheng
> Attachments: HIVE-15099.1.patch
>
>
> There is an issue with PTFOperator.PTFInvocation where the inputPart is not 
> reset properly. The inputPart has been closed and its content (member 
> variables) has been cleaned up, but since itself is not nullified, it's 
> reused in the next round and caused NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15099) PTFOperator.PTFInvocation didn't properly reset the input partition

2016-10-31 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623742#comment-15623742
 ] 

Ashutosh Chauhan commented on HIVE-15099:
-

Patch looks good to me. [~wzheng] Can you add a test case for it as well?

> PTFOperator.PTFInvocation didn't properly reset the input partition
> ---
>
> Key: HIVE-15099
> URL: https://issues.apache.org/jira/browse/HIVE-15099
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, PTF-Windowing
>Affects Versions: 1.3.0, 1.2.1, 2.1.0, 2.2.0
>Reporter: Wei Zheng
>Assignee: Wei Zheng
> Attachments: HIVE-15099.1.patch
>
>
> There is an issue with PTFOperator.PTFInvocation where the inputPart is not 
> reset properly. The inputPart has been closed and its content (member 
> variables) has been cleaned up, but since itself is not nullified, it's 
> reused in the next round and caused NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15099) PTFOperator.PTFInvocation didn't properly reset the input partition

2016-10-31 Thread Wei Zheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623430#comment-15623430
 ] 

Wei Zheng commented on HIVE-15099:
--

[~ashutoshc] Can you take a look please?

> PTFOperator.PTFInvocation didn't properly reset the input partition
> ---
>
> Key: HIVE-15099
> URL: https://issues.apache.org/jira/browse/HIVE-15099
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, PTF-Windowing
>Affects Versions: 1.3.0, 1.2.1, 2.1.0, 2.2.0
>Reporter: Wei Zheng
>Assignee: Wei Zheng
> Attachments: HIVE-15099.1.patch
>
>
> There is an issue with PTFOperator.PTFInvocation where the inputPart is not 
> reset properly. The inputPart has been closed and its content (member 
> variables) has been cleaned up, but since itself is not nullified, it's 
> reused in the next round and caused NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15099) PTFOperator.PTFInvocation didn't properly reset the input partition

2016-10-31 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623153#comment-15623153
 ] 

Hive QA commented on HIVE-15099:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12836191/HIVE-15099.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 10627 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1888/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1888/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-1888/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12836191 - PreCommit-HIVE-Build

> PTFOperator.PTFInvocation didn't properly reset the input partition
> ---
>
> Key: HIVE-15099
> URL: https://issues.apache.org/jira/browse/HIVE-15099
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, PTF-Windowing
>Affects Versions: 1.3.0, 1.2.1, 2.1.0, 2.2.0
>Reporter: Wei Zheng
>Assignee: Wei Zheng
> Attachments: HIVE-15099.1.patch
>
>
> There is an issue with PTFOperator.PTFInvocation where the inputPart is not 
> reset properly. The inputPart has been closed and its content (member 
> variables) has been cleaned up, but since itself is not nullified, it's 
> reused in the next round and caused NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15099) PTFOperator.PTFInvocation didn't properly reset the input partition

2016-10-31 Thread Wei Zheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622899#comment-15622899
 ] 

Wei Zheng commented on HIVE-15099:
--

Sample query that can reproduce the issue
{code}
SELECT 1
FROM ( 
  SELECT   a,
   b, 
   row_number() OVER ( partition BY a ORDER BY c DESC ) AS rank
  FROM t1) x 
JOIN 
 ( 
  SELECT   a, 
   row_number() OVER ( partition BY a ORDER BY c DESC ) AS rank
  FROM t2) y 
ON y.a=x.a
LEFT OUTER JOIN 
 ( 
  SELECT   a, 
   row_number() OVER ( partition BY a ORDER BY c DESC ) AS rank
  FROM t3) z
ON y.a=z.a
WHERE x.rank = 1 
AND y.rank=1 
{code}

> PTFOperator.PTFInvocation didn't properly reset the input partition
> ---
>
> Key: HIVE-15099
> URL: https://issues.apache.org/jira/browse/HIVE-15099
> Project: Hive
>  Issue Type: Bug
>  Components: Hive, PTF-Windowing
>Affects Versions: 1.3.0, 1.2.1, 2.1.0, 2.2.0
>Reporter: Wei Zheng
>Assignee: Wei Zheng
>
> There is an issue with PTFOperator.PTFInvocation where the inputPart is not 
> reset properly. The inputPart has been closed and its content (member 
> variables) has been cleaned up, but since itself is not nullified, it's 
> reused in the next round and caused NPE issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)