[
https://issues.apache.org/jira/browse/HIVE-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725751#comment-15725751
]
Yongzhi Chen commented on HIVE-15275:
-
The fix LGTM +1
> "beeline -f " will throw NPE
>
[
https://issues.apache.org/jira/browse/HIVE-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722599#comment-15722599
]
Aihua Xu commented on HIVE-15275:
-
There is a max_size setting there default to 500 and jLine handles such
[
https://issues.apache.org/jira/browse/HIVE-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722530#comment-15722530
]
Aihua Xu commented on HIVE-15275:
-
I guess it should be handled by jLine already, but let me confirm.
>
[
https://issues.apache.org/jira/browse/HIVE-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722522#comment-15722522
]
Yongzhi Chen commented on HIVE-15275:
-
[~aihuaxu], Does this history buffer only written to a file
[
https://issues.apache.org/jira/browse/HIVE-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713072#comment-15713072
]
Vihang Karajgaonkar commented on HIVE-15275:
Thanks for the changes. Patch looks good to me.
[
https://issues.apache.org/jira/browse/HIVE-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712727#comment-15712727
]
Hive QA commented on HIVE-15275:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712596#comment-15712596
]
Aihua Xu commented on HIVE-15275:
-
[~ychena] [~ctang.ma] and [~vihangk1] Can you help review the patch?
>
