[jira] [Commented] (HIVE-15324) Enable round() function to accept scale argument as non-constants
[
https://issues.apache.org/jira/browse/HIVE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822231#comment-15822231
]
Xuefu Zhang commented on HIVE-15324:
Result type needs to determined statically. Scale impacts the returned type, so
different scales for different rows will make result type undeterministic.
> Enable round() function to accept scale argument as non-constants
> -
>
> Key: HIVE-15324
> URL: https://issues.apache.org/jira/browse/HIVE-15324
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-15324.1.patch, HIVE-15324.2.patch, HIVE-15324.patch
>
>
> round() function should accept scale argument as non-constants, it will
> enable queries like:
> {quote}
> create table sampletable(c double, d int);
> select round(c,d) from sampletable;
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15324) Enable round() function to accept scale argument as non-constants
[
https://issues.apache.org/jira/browse/HIVE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15820400#comment-15820400
]
Chinna Rao Lalam commented on HIVE-15324:
-
Hi [~xuefuz],
Thanks for the review. I will check this scenario. I have one doubt please
correct me if i am wrong.
Initialize() evaluated "outputIO" for all instances based on the input type
irrespective of the scale is constant or non-constant. Will this handle result
type?
> Enable round() function to accept scale argument as non-constants
> -
>
> Key: HIVE-15324
> URL: https://issues.apache.org/jira/browse/HIVE-15324
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-15324.1.patch, HIVE-15324.2.patch, HIVE-15324.patch
>
>
> round() function should accept scale argument as non-constants, it will
> enable queries like:
> {quote}
> create table sampletable(c double, d int);
> select round(c,d) from sampletable;
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15324) Enable round() function to accept scale argument as non-constants
[
https://issues.apache.org/jira/browse/HIVE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789811#comment-15789811
]
Xuefu Zhang commented on HIVE-15324:
It's at lease unclear to me if such a change makes sense. UDF round() is to
adjust decimal point and it should have a definitive return type. If the given
scale is variable, we don't even know the return type. For example,
round(decimal(10, 4), x) gives return type as decimal (8, 2) when x=2,
decimal(9, 3) when x = 1. If each row produces a different type, then what's
the result type?
> Enable round() function to accept scale argument as non-constants
> -
>
> Key: HIVE-15324
> URL: https://issues.apache.org/jira/browse/HIVE-15324
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-15324.1.patch, HIVE-15324.2.patch, HIVE-15324.patch
>
>
> round() function should accept scale argument as non-constants, it will
> enable queries like:
> {quote}
> create table sampletable(c double, d int);
> select round(c,d) from sampletable;
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15324) Enable round() function to accept scale argument as non-constants
[
https://issues.apache.org/jira/browse/HIVE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778618#comment-15778618
]
Chinna Rao Lalam commented on HIVE-15324:
-
Failed tests are not related to this patch.
RB request link : https://reviews.apache.org/r/55045/
> Enable round() function to accept scale argument as non-constants
> -
>
> Key: HIVE-15324
> URL: https://issues.apache.org/jira/browse/HIVE-15324
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-15324.1.patch, HIVE-15324.2.patch, HIVE-15324.patch
>
>
> round() function should accept scale argument as non-constants, it will
> enable queries like:
> {quote}
> create table sampletable(c double, d int);
> select round(c,d) from sampletable;
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15324) Enable round() function to accept scale argument as non-constants
[
https://issues.apache.org/jira/browse/HIVE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778142#comment-15778142
]
Hive QA commented on HIVE-15324:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12844667/HIVE-15324.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10866 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=234)
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed
out) (batchId=151)
[smb_mapjoin_15.q,insert_values_partitioned.q,selectDistinctStar.q,bucket4.q,vectorized_distinct_gby.q,vector_groupby_mapjoin.q,insert_values_dynamic_partitioned.q,vector_nvl.q,join_nullsafe.q,vectorized_mapjoin.q,schema_evol_orc_vec_part_all_primitive.q,vectorized_shufflejoin.q,tez_smb_1.q,cbo_union.q,tez_vector_dynpart_hashjoin_1.q,filter_join_breaktask2.q,table_access_keys_stats.q,vector_data_types.q,multiMapJoin2.q,filter_join_breaktask.q,schema_evol_orc_nonvec_part.q,alter_merge_2_orc.q,vectorization_3.q,union4.q,auto_sortmerge_join_8.q,stats_based_fetch_decision.q,vectorized_date_funcs.q,auto_sortmerge_join_10.q,vector_varchar_simple.q,vector_decimal_udf2.q]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a]
(batchId=135)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[offset_limit_ppd_optimizer]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=93)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_4]
(batchId=93)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2726/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2726/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2726/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12844667 - PreCommit-HIVE-Build
> Enable round() function to accept scale argument as non-constants
> -
>
> Key: HIVE-15324
> URL: https://issues.apache.org/jira/browse/HIVE-15324
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-15324.1.patch, HIVE-15324.2.patch, HIVE-15324.patch
>
>
> round() function should accept scale argument as non-constants, it will
> enable queries like:
> {quote}
> create table sampletable(c double, d int);
> select round(c,d) from sampletable;
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15324) Enable round() function to accept scale argument as non-constants
[
https://issues.apache.org/jira/browse/HIVE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770057#comment-15770057
]
Hive QA commented on HIVE-15324:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12844382/HIVE-15324.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10895 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=234)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dbtxnmgr_showlocks]
(batchId=71)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_round] (batchId=70)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=134)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2]
(batchId=93)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2696/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2696/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2696/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12844382 - PreCommit-HIVE-Build
> Enable round() function to accept scale argument as non-constants
> -
>
> Key: HIVE-15324
> URL: https://issues.apache.org/jira/browse/HIVE-15324
> Project: Hive
> Issue Type: Bug
> Components: UDF
>Reporter: Chinna Rao Lalam
>Assignee: Chinna Rao Lalam
> Attachments: HIVE-15324.1.patch, HIVE-15324.patch
>
>
> round() function should accept scale argument as non-constants, it will
> enable queries like:
> {quote}
> create table sampletable(c double, d int);
> select round(c,d) from sampletable;
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
