[jira] [Commented] (HIVE-15428) HoS DPP doesn't remove cyclic dependency
[ https://issues.apache.org/jira/browse/HIVE-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755343#comment-15755343 ] Chao Sun commented on HIVE-15428: - +1 > HoS DPP doesn't remove cyclic dependency > > > Key: HIVE-15428 > URL: https://issues.apache.org/jira/browse/HIVE-15428 > Project: Hive > Issue Type: Bug >Reporter: Rui Li >Assignee: Rui Li > Attachments: HIVE-15428.1.patch > > > More details in HIVE-15357 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15428) HoS DPP doesn't remove cyclic dependency
[ https://issues.apache.org/jira/browse/HIVE-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755226#comment-15755226 ] Chao Sun commented on HIVE-15428: - [~lirui] I agree - removing the smaller one doesn't make sense to me either. I'll take a look at the patch. > HoS DPP doesn't remove cyclic dependency > > > Key: HIVE-15428 > URL: https://issues.apache.org/jira/browse/HIVE-15428 > Project: Hive > Issue Type: Bug >Reporter: Rui Li >Assignee: Rui Li > Attachments: HIVE-15428.1.patch > > > More details in HIVE-15357 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15428) HoS DPP doesn't remove cyclic dependency
[ https://issues.apache.org/jira/browse/HIVE-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753161#comment-15753161 ] Rui Li commented on HIVE-15428: --- Test failures are not related. > HoS DPP doesn't remove cyclic dependency > > > Key: HIVE-15428 > URL: https://issues.apache.org/jira/browse/HIVE-15428 > Project: Hive > Issue Type: Bug >Reporter: Rui Li >Assignee: Rui Li > Attachments: HIVE-15428.1.patch > > > More details in HIVE-15357 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15428) HoS DPP doesn't remove cyclic dependency
[
https://issues.apache.org/jira/browse/HIVE-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751414#comment-15751414
]
Hive QA commented on HIVE-15428:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12843384/HIVE-15428.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 10815 tests
executed
*Failed tests:*
{noformat}
TestVectorizedColumnReaderBase - did not produce a TEST-*.xml file (likely
timed out) (batchId=251)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample2] (batchId=5)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample4] (batchId=15)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=61)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample7] (batchId=60)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample9] (batchId=38)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2]
(batchId=135)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[metadataonly1]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[stats_based_fetch_decision]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_5]
(batchId=92)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2588/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2588/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2588/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12843384 - PreCommit-HIVE-Build
> HoS DPP doesn't remove cyclic dependency
>
>
> Key: HIVE-15428
> URL: https://issues.apache.org/jira/browse/HIVE-15428
> Project: Hive
> Issue Type: Bug
>Reporter: Rui Li
>Assignee: Rui Li
> Attachments: HIVE-15428.1.patch
>
>
> More details in HIVE-15357
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-15428) HoS DPP doesn't remove cyclic dependency
[
https://issues.apache.org/jira/browse/HIVE-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748659#comment-15748659
]
Rui Li commented on HIVE-15428:
---
The reason why we didn't see this before is related to how we generate the
GenericUDFIn. DPP is created for UDF like {noformat}GenericUDFIn(Column[ds],
RS[12]){noformat} and is not created if the joining column is resolved to
constant like {noformat}GenericUDFIn(Const string 2008-04-08, RS[11]){noformat}
Previously we had one UDF resolved like above, so we only created one DPP.
Anyway our code needs to be robust to handle both cases. I'll upload a patch to
add cycle detection.
> HoS DPP doesn't remove cyclic dependency
>
>
> Key: HIVE-15428
> URL: https://issues.apache.org/jira/browse/HIVE-15428
> Project: Hive
> Issue Type: Bug
>Reporter: Rui Li
>Assignee: Rui Li
>
> More details in HIVE-15357
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
