[jira] [Commented] (HIVE-15703) HiveSubQRemoveRelBuilder should use Hive's own factories

2017-01-31 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847862#comment-15847862
 ] 

Ashutosh Chauhan commented on HIVE-15703:
-

+1

> HiveSubQRemoveRelBuilder should use Hive's own factories
> 
>
> Key: HIVE-15703
> URL: https://issues.apache.org/jira/browse/HIVE-15703
> Project: Hive
>  Issue Type: Bug
>Reporter: Pengcheng Xiong
>Assignee: Vineet Garg
> Attachments: HIVE-15703.01.patch, HIVE-15703.2.patch, 
> HIVE-15703.3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15703) HiveSubQRemoveRelBuilder should use Hive's own factories

2017-01-31 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847783#comment-15847783
 ] 

Hive QA commented on HIVE-15703:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12850333/HIVE-15703.3.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 11015 tests 
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) 
(batchId=235)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[index_auto_mult_tables] 
(batchId=78)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
 (batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple]
 (batchId=153)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] 
(batchId=223)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3289/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3289/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3289/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12850333 - PreCommit-HIVE-Build

> HiveSubQRemoveRelBuilder should use Hive's own factories
> 
>
> Key: HIVE-15703
> URL: https://issues.apache.org/jira/browse/HIVE-15703
> Project: Hive
>  Issue Type: Bug
>Reporter: Pengcheng Xiong
>Assignee: Vineet Garg
> Attachments: HIVE-15703.01.patch, HIVE-15703.2.patch, 
> HIVE-15703.3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15703) HiveSubQRemoveRelBuilder should use Hive's own factories

2017-01-26 Thread Pengcheng Xiong (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840792#comment-15840792
 ] 

Pengcheng Xiong commented on HIVE-15703:


OK. then i will continue to investigate the failing tests.

> HiveSubQRemoveRelBuilder should use Hive's own factories
> 
>
> Key: HIVE-15703
> URL: https://issues.apache.org/jira/browse/HIVE-15703
> Project: Hive
>  Issue Type: Bug
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-15703.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15703) HiveSubQRemoveRelBuilder should use Hive's own factories

2017-01-26 Thread Ashutosh Chauhan (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840467#comment-15840467
 ] 

Ashutosh Chauhan commented on HIVE-15703:
-

HIVE-15737 will need HIVE-15708 which may not arrive soon. So, its good to get 
this in meanwhile. 

> HiveSubQRemoveRelBuilder should use Hive's own factories
> 
>
> Key: HIVE-15703
> URL: https://issues.apache.org/jira/browse/HIVE-15703
> Project: Hive
>  Issue Type: Bug
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-15703.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15703) HiveSubQRemoveRelBuilder should use Hive's own factories

2017-01-26 Thread Vineet Garg (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840416#comment-15840416
 ] 

Vineet Garg commented on HIVE-15703:


HIVE-15737 will get rid of {{HiveSubQRemoveRelBuilder}}

> HiveSubQRemoveRelBuilder should use Hive's own factories
> 
>
> Key: HIVE-15703
> URL: https://issues.apache.org/jira/browse/HIVE-15703
> Project: Hive
>  Issue Type: Bug
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-15703.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-15703) HiveSubQRemoveRelBuilder should use Hive's own factories

2017-01-26 Thread Vineet Garg (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-15703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840408#comment-15840408
 ] 

Vineet Garg commented on HIVE-15703:


HiveSubQRemoveRelBuilder kept default factories instead of Hive factories for a 
reason. I don't recall the exact reason but I remember wrong plans because of 
this.
Anyway we plan to get rid of this and replace with RelBuilder so I don't think 
it's worth the change.

> HiveSubQRemoveRelBuilder should use Hive's own factories
> 
>
> Key: HIVE-15703
> URL: https://issues.apache.org/jira/browse/HIVE-15703
> Project: Hive
>  Issue Type: Bug
>Reporter: Pengcheng Xiong
>Assignee: Pengcheng Xiong
> Attachments: HIVE-15703.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)