[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[ https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860676#comment-15860676 ] Shannon Ladymon commented on HIVE-15797: The new parameters (*hive.groupby.position.alias* and *hive.orderby.position.alias*) have been added to the wiki: * [Configuration Properties - hive.groupby.position.alias | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.groupby.position.alias] * [Configuration Properties - hive.orderby.position.alias | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.orderby.position.alias] The description for the original parameter (*hive.groupby.orderby.position.alias*) has been updated as well: * [Configuration Properties - hive.groupby.orderby.position.alias | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.groupby.orderby.position.alias] Lefty, thank you for doing the documentation for the changes in the [Group By Syntax | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+GroupBy#LanguageManualGroupBy-GroupBySyntax] and [Syntax of Order By | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+SortBy#LanguageManualSortBy-SyntaxofOrderBy] sections. > separate the configs for gby and oby position alias usage > - > > Key: HIVE-15797 > URL: https://issues.apache.org/jira/browse/HIVE-15797 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Labels: TODOC2.2 > Fix For: 2.2.0 > > Attachments: HIVE-15797.01.patch, HIVE-15797.02.patch, > HIVE-15797.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[ https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855369#comment-15855369 ] Lefty Leverenz commented on HIVE-15797: --- Doc note: This adds *hive.groupby.position.alias* and *hive.orderby.position.alias* to HiveConf.java, and changes the description of *hive.groupby.orderby.position.alias*. They need to be documented in Configuration Properties, and the Group By and Order By docs need to be updated where they mention *hive.groupby.orderby.position.alias*. * [Configuration Properties -- hive.groupby.orderby.position.alias | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.groupby.orderby.position.alias] * [Group By Syntax | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+GroupBy#LanguageManualGroupBy-GroupBySyntax] * [Syntax of Order By | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+SortBy#LanguageManualSortBy-SyntaxofOrderBy] Added a TODOC2.2 label. > separate the configs for gby and oby position alias usage > - > > Key: HIVE-15797 > URL: https://issues.apache.org/jira/browse/HIVE-15797 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Labels: TODOC2.2 > Fix For: 2.2.0 > > Attachments: HIVE-15797.01.patch, HIVE-15797.02.patch, > HIVE-15797.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[ https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855045#comment-15855045 ] Sergey Shelukhin commented on HIVE-15797: - Test failures look unrelated based on the errors, and they do not repro. > separate the configs for gby and oby position alias usage > - > > Key: HIVE-15797 > URL: https://issues.apache.org/jira/browse/HIVE-15797 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-15797.01.patch, HIVE-15797.02.patch, > HIVE-15797.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[
https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852690#comment-15852690
]
Hive QA commented on HIVE-15797:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12850950/HIVE-15797.02.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10226 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_simple]
(batchId=147)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple]
(batchId=153)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testWaitQueuePreemption
(batchId=277)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testSyntheticComplexSchema[0]
(batchId=173)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testSyntheticComplexSchema[1]
(batchId=173)
org.apache.hive.hcatalog.pig.TestHCatLoaderComplexSchema.testTupleInBagInTupleInBag[0]
(batchId=173)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteDate (batchId=173)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteDate3 (batchId=173)
org.apache.hive.jdbc.TestJdbcDriver2.testSelectExecAsync2 (batchId=215)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3372/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3372/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3372/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 12 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12850950 - PreCommit-HIVE-Build
> separate the configs for gby and oby position alias usage
> -
>
> Key: HIVE-15797
> URL: https://issues.apache.org/jira/browse/HIVE-15797
> Project: Hive
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-15797.01.patch, HIVE-15797.02.patch,
> HIVE-15797.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[
https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851161#comment-15851161
]
Hive QA commented on HIVE-15797:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12850743/HIVE-15797.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 11012 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=122)
[auto_sortmerge_join_13.q,join4.q,join35.q,udf_percentile.q,join_reorder3.q,subquery_in.q,auto_join19.q,stats14.q,vectorization_15.q,union7.q,vectorization_nested_udf.q,vector_groupby_3.q,vectorized_ptf.q,auto_join2.q,groupby1_map_skew.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cp_sel] (batchId=57)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_stats]
(batchId=76)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_groupby]
(batchId=154)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=223)
org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testWaitQueuePreemption
(batchId=282)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3345/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3345/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3345/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12850743 - PreCommit-HIVE-Build
> separate the configs for gby and oby position alias usage
> -
>
> Key: HIVE-15797
> URL: https://issues.apache.org/jira/browse/HIVE-15797
> Project: Hive
> Issue Type: Bug
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-15797.01.patch, HIVE-15797.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[
https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850942#comment-15850942
]
Hive QA commented on HIVE-15797:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12850726/HIVE-15797.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3340/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3340/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3340/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2017-02-03 02:18:54.724
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-3340/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2017-02-03 02:18:54.727
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at feaa65f HIVE-15765: Support bracketed comments (Gunther
Hagleitner, reviewed by Pengcheng Xiong)
+ git clean -f -d
Removing
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/VectorizerReason.java
Removing ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g.orig
Removing
ql/src/java/org/apache/hadoop/hive/ql/plan/OperatorExplainVectorization.java
Removing
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorAppMasterEventDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorFileSinkDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorFilterDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorLimitDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorMapJoinInfo.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSMBJoinDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSelectDesc.java
Removing
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSparkHashTableSinkDesc.java
Removing
ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSparkPartitionPruningSinkDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorTableScanDesc.java
Removing ql/src/java/org/apache/hadoop/hive/ql/plan/VectorizationCondition.java
Removing ql/src/test/results/clientpositive/llap/vector_const.q.out
Removing ql/src/test/results/clientpositive/llap/vector_empty_where.q.out
Removing ql/src/test/results/clientpositive/llap/vector_join.q.out
Removing
ql/src/test/results/clientpositive/llap/vector_non_constant_in_expr.q.out
Removing
ql/src/test/results/clientpositive/llap/vector_orc_string_reader_empty_dict.q.out
Removing ql/src/test/results/clientpositive/llap/vector_string_decimal.q.out
Removing ql/src/test/results/clientpositive/llap/vector_tablesample_rows.q.out
Removing ql/src/test/results/clientpositive/llap/vector_udf2.q.out
Removing
ql/src/test/results/clientpositive/llap/vectorization_offset_limit.q.out
Removing ql/src/test/results/clientpositive/llap/vectorized_mapjoin2.q.out
Removing ql/src/test/results/clientpositive/tez/vector_acid3.q.out
Removing ql/src/test/results/clientpositive/tez/vector_adaptor_usage_mode.q.out
Removing ql/src/test/results/clientpositive/tez/vector_aggregate_9.q.out
Removing
ql/src/test/results/clientpositive/tez/vector_aggregate_without_gby.q.out
Removing ql/src/test/results/clientpositive/tez/vector_auto_smb_mapjoin_14.q.out
Removing ql/src/test/results/clientpositive/tez/vector_between_columns.q.out
Removing ql/src/test/results/clientpositive/tez/vector_between_in.q.out
Removing ql/src/test/results/clientpositive/tez/vector_binary_join_groupby.q.out
Removing ql/src/test/results/clientpositive/tez/vector_bround.q.out
Removing ql/src/test/results/clientpositive/tez/vector_bucket.q.out
Removing ql/src/test/results/clientpositive/tez/vector_cast_constant.q.out
Removing ql/src/test/results/clientpositive/tez/vector_char_2.q.out
Removing ql/src/test/results/clientpositive/tez/vector_char_4.q.out
Removing ql/src/test/results/clientpositive/tez/vector_char_cast.q.out
Removing
[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[ https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850936#comment-15850936 ] Lefty Leverenz commented on HIVE-15797: --- Typo alert: "(deprecacted)" -> "(deprecated)" in the description for hive.groupby.orderby.position.alias. Also, why does the deprecation advice for hive.groupby.orderby.position.alias refer to HIVE_ORDERBY_POSITION_ALIAS.varname and HIVE_GROUPBY_POSITION_ALIAS.varname rather than simply hive.orderby.position.alias and hive.groupby.position.alias? Do you expect those varnames to change? > separate the configs for gby and oby position alias usage > - > > Key: HIVE-15797 > URL: https://issues.apache.org/jira/browse/HIVE-15797 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-15797.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15797) separate the configs for gby and oby position alias usage
[ https://issues.apache.org/jira/browse/HIVE-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850876#comment-15850876 ] Ashutosh Chauhan commented on HIVE-15797: - LGTM. My guess it should result in update of few golden files. > separate the configs for gby and oby position alias usage > - > > Key: HIVE-15797 > URL: https://issues.apache.org/jira/browse/HIVE-15797 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-15797.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
