[jira] [Commented] (HIVE-15975) Support the MOD function
[ https://issues.apache.org/jira/browse/HIVE-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904109#comment-15904109 ] Lefty Leverenz commented on HIVE-15975: --- Doc note: This needs to be documented in the wiki. * [Hive Operators and UDFs -- Mathematical Functions | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-MathematicalFunctions] This section should also be updated (perhaps with version information): * [Hive Operators and UDFs -- Operators Precedences | https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-Operatorsprecedences] Added a TODOC2.2 label. > Support the MOD function > > > Key: HIVE-15975 > URL: https://issues.apache.org/jira/browse/HIVE-15975 > Project: Hive > Issue Type: Sub-task > Components: SQL >Reporter: Carter Shanklin >Assignee: Teddy Choi > Labels: TODOC2.2 > Fix For: 2.2.0 > > Attachments: HIVE-15975.1.patch, HIVE-15975.2.patch, > HIVE-15975.3.patch, HIVE-15975.4.patch > > > SQL defines the mod expression as a function allowing 2 numeric value > expressions. Hive allows the infix notation using %. It would be good for > Hive to support the standard approach as well. SQL standard reference T441 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15975) Support the MOD function
[ https://issues.apache.org/jira/browse/HIVE-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903012#comment-15903012 ] Hive QA commented on HIVE-15975: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854761/HIVE-15975.4.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10335 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=141) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_without_localtask] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_3] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[date_join1] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby6_noskew] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapjoin_test_outer] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[merge2] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[smb_mapjoin_11] (batchId=96) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_9] (batchId=96) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4048/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4048/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4048/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12854761 - PreCommit-HIVE-Build > Support the MOD function > > > Key: HIVE-15975 > URL: https://issues.apache.org/jira/browse/HIVE-15975 > Project: Hive > Issue Type: Sub-task > Components: SQL >Reporter: Carter Shanklin >Assignee: Teddy Choi > Attachments: HIVE-15975.1.patch, HIVE-15975.2.patch, > HIVE-15975.3.patch, HIVE-15975.4.patch > > > SQL defines the mod expression as a function allowing 2 numeric value > expressions. Hive allows the infix notation using %. It would be good for > Hive to support the standard approach as well. SQL standard reference T441 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15975) Support the MOD function
[ https://issues.apache.org/jira/browse/HIVE-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888270#comment-15888270 ] Ashutosh Chauhan commented on HIVE-15975: - Ah, I see. +1 pending tests > Support the MOD function > > > Key: HIVE-15975 > URL: https://issues.apache.org/jira/browse/HIVE-15975 > Project: Hive > Issue Type: Sub-task > Components: SQL >Reporter: Carter Shanklin >Assignee: Teddy Choi > Attachments: HIVE-15975.1.patch, HIVE-15975.2.patch, > HIVE-15975.3.patch, HIVE-15975.4.patch > > > SQL defines the mod expression as a function allowing 2 numeric value > expressions. Hive allows the infix notation using %. It would be good for > Hive to support the standard approach as well. SQL standard reference T441 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15975) Support the MOD function
[ https://issues.apache.org/jira/browse/HIVE-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887861#comment-15887861 ] Teddy Choi commented on HIVE-15975: --- [~ashutoshc], this patch just gives a new name for the UDF as "MOD(a, b)". So it doesn't need a new UDF file. Thanks for feedback. > Support the MOD function > > > Key: HIVE-15975 > URL: https://issues.apache.org/jira/browse/HIVE-15975 > Project: Hive > Issue Type: Sub-task > Components: SQL >Reporter: Carter Shanklin >Assignee: Teddy Choi > Attachments: HIVE-15975.1.patch, HIVE-15975.2.patch, > HIVE-15975.3.patch, HIVE-15975.4.patch > > > SQL defines the mod expression as a function allowing 2 numeric value > expressions. Hive allows the infix notation using %. It would be good for > Hive to support the standard approach as well. SQL standard reference T441 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15975) Support the MOD function
[ https://issues.apache.org/jira/browse/HIVE-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884708#comment-15884708 ] Hive QA commented on HIVE-15975: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854761/HIVE-15975.4.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3794/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3794/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3794/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Tests exited with: ExecutionException: java.util.concurrent.ExecutionException: java.io.IOException: Could not create /data/hiveptest/logs/PreCommit-HIVE-Build-3794/succeeded/204_TestAcidOnTez {noformat} This message is automatically generated. ATTACHMENT ID: 12854761 - PreCommit-HIVE-Build > Support the MOD function > > > Key: HIVE-15975 > URL: https://issues.apache.org/jira/browse/HIVE-15975 > Project: Hive > Issue Type: Sub-task > Components: SQL >Reporter: Carter Shanklin >Assignee: Teddy Choi > Attachments: HIVE-15975.1.patch, HIVE-15975.2.patch, > HIVE-15975.3.patch, HIVE-15975.4.patch > > > SQL defines the mod expression as a function allowing 2 numeric value > expressions. Hive allows the infix notation using %. It would be good for > Hive to support the standard approach as well. SQL standard reference T441 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15975) Support the MOD function
[ https://issues.apache.org/jira/browse/HIVE-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884680#comment-15884680 ] Hive QA commented on HIVE-15975: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854697/HIVE-15975.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10267 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[show_functions] (batchId=67) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_length] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_modulo] (batchId=68) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=140) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgress (batchId=211) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3793/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3793/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3793/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12854697 - PreCommit-HIVE-Build > Support the MOD function > > > Key: HIVE-15975 > URL: https://issues.apache.org/jira/browse/HIVE-15975 > Project: Hive > Issue Type: Sub-task > Components: SQL >Reporter: Carter Shanklin >Assignee: Teddy Choi > Attachments: HIVE-15975.1.patch, HIVE-15975.2.patch, > HIVE-15975.3.patch > > > SQL defines the mod expression as a function allowing 2 numeric value > expressions. Hive allows the infix notation using %. It would be good for > Hive to support the standard approach as well. SQL standard reference T441 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15975) Support the MOD function
[ https://issues.apache.org/jira/browse/HIVE-15975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884581#comment-15884581 ] Hive QA commented on HIVE-15975: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854693/HIVE-15975.2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3791/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3791/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3791/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Tests exited with: ExecutionException: java.util.concurrent.ExecutionException: java.io.IOException: Could not create /data/hiveptest/logs/PreCommit-HIVE-Build-3791/succeeded/16-TestCliDriver-skewjoin_noskew.q-alter_table_add_partition.q-udaf_number_format.q-and-27-more {noformat} This message is automatically generated. ATTACHMENT ID: 12854693 - PreCommit-HIVE-Build > Support the MOD function > > > Key: HIVE-15975 > URL: https://issues.apache.org/jira/browse/HIVE-15975 > Project: Hive > Issue Type: Sub-task > Components: SQL >Reporter: Carter Shanklin >Assignee: Teddy Choi > Attachments: HIVE-15975.1.patch, HIVE-15975.2.patch > > > SQL defines the mod expression as a function allowing 2 numeric value > expressions. Hive allows the infix notation using %. It would be good for > Hive to support the standard approach as well. SQL standard reference T441 -- This message was sent by Atlassian JIRA (v6.3.15#6346)