[jira] [Commented] (HIVE-16876) RpcServer should be re-created when Rpc configs change
[ https://issues.apache.org/jira/browse/HIVE-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049986#comment-16049986 ] Xuefu Zhang commented on HIVE-16876: +1 > RpcServer should be re-created when Rpc configs change > -- > > Key: HIVE-16876 > URL: https://issues.apache.org/jira/browse/HIVE-16876 > Project: Hive > Issue Type: Bug > Components: Spark >Reporter: Rui Li >Assignee: Rui Li > Attachments: HIVE-16876.1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16876) RpcServer should be re-created when Rpc configs change
[
https://issues.apache.org/jira/browse/HIVE-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048890#comment-16048890
]
Hive QA commented on HIVE-16876:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12872937/HIVE-16876.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10831 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[insert_overwrite_local_directory_1]
(batchId=237)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=140)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=145)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
(batchId=232)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query16]
(batchId=232)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query94]
(batchId=232)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testBootstrapFunctionReplication
(batchId=216)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionIncrementalReplication
(batchId=216)
org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcrossInstances.testCreateFunctionWithFunctionBinaryJarsOnHDFS
(batchId=216)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
(batchId=177)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
(batchId=177)
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
(batchId=177)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/5641/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/5641/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-5641/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 12 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12872937 - PreCommit-HIVE-Build
> RpcServer should be re-created when Rpc configs change
> --
>
> Key: HIVE-16876
> URL: https://issues.apache.org/jira/browse/HIVE-16876
> Project: Hive
> Issue Type: Bug
> Components: Spark
>Reporter: Rui Li
>Assignee: Rui Li
> Attachments: HIVE-16876.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-16876) RpcServer should be re-created when Rpc configs change
[ https://issues.apache.org/jira/browse/HIVE-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047316#comment-16047316 ] Xuefu Zhang commented on HIVE-16876: Yeah. Documentation is good to have. > RpcServer should be re-created when Rpc configs change > -- > > Key: HIVE-16876 > URL: https://issues.apache.org/jira/browse/HIVE-16876 > Project: Hive > Issue Type: Bug > Components: Spark >Reporter: Rui Li >Assignee: Rui Li > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16876) RpcServer should be re-created when Rpc configs change
[ https://issues.apache.org/jira/browse/HIVE-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047315#comment-16047315 ] Rui Li commented on HIVE-16876: --- [~xuefuz], examples are the server side connect timeout, and number of threads to be used for the event loop group. I agree not to have an RpcServer for each driver. Shall we document these configs cannot be changed at runtime? > RpcServer should be re-created when Rpc configs change > -- > > Key: HIVE-16876 > URL: https://issues.apache.org/jira/browse/HIVE-16876 > Project: Hive > Issue Type: Bug > Components: Spark >Reporter: Rui Li >Assignee: Rui Li > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16876) RpcServer should be re-created when Rpc configs change
[ https://issues.apache.org/jira/browse/HIVE-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046891#comment-16046891 ] Xuefu Zhang commented on HIVE-16876: [~lirui], I'm wondering what kind of configuration changes are in question. Overall, I think RPCServer configuration should be global to HS2, which are effective only upon HS2 restart. In addition, it doesn't seem ideal to have one RPCServer instance for each remote Spark driver. Thoughts! > RpcServer should be re-created when Rpc configs change > -- > > Key: HIVE-16876 > URL: https://issues.apache.org/jira/browse/HIVE-16876 > Project: Hive > Issue Type: Bug > Components: Spark >Reporter: Rui Li >Assignee: Rui Li > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-16876) RpcServer should be re-created when Rpc configs change
[ https://issues.apache.org/jira/browse/HIVE-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046452#comment-16046452 ] Rui Li commented on HIVE-16876: --- At the moment RpcServer is a singleton. If we allow users to configure it at runtime, we have to give each session a dedicated RpcServer. I'm not sure if that's a good idea - seems strange that each server serves only one client. [~xuefuz], any ideas? Thanks. > RpcServer should be re-created when Rpc configs change > -- > > Key: HIVE-16876 > URL: https://issues.apache.org/jira/browse/HIVE-16876 > Project: Hive > Issue Type: Bug > Components: Spark >Reporter: Rui Li >Assignee: Rui Li > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
