[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089953#comment-16089953
]
Ashutosh Chauhan commented on HIVE-16922:
-
+1 LGTM
> Typo in serde.thrift: COLLECTION_DELIM =
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089608#comment-16089608
]
Bing Li commented on HIVE-16922:
Thank you for the reviewing, [~lirui]. The latest test failures should
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089588#comment-16089588
]
Rui Li commented on HIVE-16922:
---
+1. [~ashutoshc], would you mind also take a look? Thanks.
> Typo in
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089317#comment-16089317
]
Hive QA commented on HIVE-16922:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088935#comment-16088935
]
Bing Li commented on HIVE-16922:
[~lirui] I checked the latest build results, the failures should NOT
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087491#comment-16087491
]
Hive QA commented on HIVE-16922:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085090#comment-16085090
]
Rui Li commented on HIVE-16922:
---
Hi [~libing], I guess we also need metastore upgrade scripts to update the
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085069#comment-16085069
]
Bing Li commented on HIVE-16922:
[~lirui], I can't reproduce TestMiniLlapLocalCliDriver[vector_if_expr] in
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084566#comment-16084566
]
Hive QA commented on HIVE-16922:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084183#comment-16084183
]
Bing Li commented on HIVE-16922:
Thank you, [~lirui]. Seems that the result page has been expired. Just
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083365#comment-16083365
]
Rui Li commented on HIVE-16922:
---
I'm +1 to fix the typo, though it needs to be marked as "breaking" change.
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079866#comment-16079866
]
Hive QA commented on HIVE-16922:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079841#comment-16079841
]
Bing Li commented on HIVE-16922:
Hi, [~ashutoshc]
I updated the patch based on the testing results.
Could
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076574#comment-16076574
]
Bing Li commented on HIVE-16922:
There is one failure caused by the fix, wil take a look at it tomorrow.
[
https://issues.apache.org/jira/browse/HIVE-16922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076135#comment-16076135
]
Hive QA commented on HIVE-16922:
Here are the results of testing the latest attachment:
15 matches
Mail list logo
