[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117503#comment-16117503
]
Prasanth Jayachandran commented on HIVE-17172:
--
+1
> add ordering checks to DiskRangeList
>
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117442#comment-16117442
]
Sergey Shelukhin commented on HIVE-17172:
-
[~q79969786] thanks for catching this!
> add ordering
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117226#comment-16117226
]
Sergey Shelukhin commented on HIVE-17172:
-
Hmm, I forgot the special case of the mutation helper.
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116339#comment-16116339
]
Yuming Wang commented on HIVE-17172:
Seems this patch cause {{llap_uncompressed}} test failed:
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110257#comment-16110257
]
Deepak Jaiswal commented on HIVE-17172:
---
Thanks for adding comments. As far as I understand it looks
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109974#comment-16109974
]
Hive QA commented on HIVE-17172:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109606#comment-16109606
]
Deepak Jaiswal commented on HIVE-17172:
---
[~sershe] Can you please put the next patch in RB? It is
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109604#comment-16109604
]
Deepak Jaiswal commented on HIVE-17172:
---
+1 Lgtm.
> add ordering checks to DiskRangeList
>
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109593#comment-16109593
]
Sergey Shelukhin commented on HIVE-17172:
-
actually there's a bug in the test :) will update it
>
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109572#comment-16109572
]
Prasanth Jayachandran commented on HIVE-17172:
--
+1
> add ordering checks to DiskRangeList
>
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109553#comment-16109553
]
Sergey Shelukhin commented on HIVE-17172:
-
[~prasanth_j] [~owen.omalley] [~djaiswal] ping
> add
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108422#comment-16108422
]
Hive QA commented on HIVE-17172:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101076#comment-16101076
]
Hive QA commented on HIVE-17172:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100635#comment-16100635
]
Owen O'Malley commented on HIVE-17172:
--
This looks reasonable, but you need to add some unit tests.
14 matches
Mail list logo
