[jira] [Commented] (HIVE-17209) ObjectCacheFactory should return null when tez shared object registry is not setup
[
https://issues.apache.org/jira/browse/HIVE-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108161#comment-16108161
]
Rajesh Balamohan commented on HIVE-17209:
-
Thanks [~sershe]. This would also need a fix in ORC
(https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java#L554).
Since {{getLiteralList()}} would be empty, it needs to check for empty
structure to avoid IndexOutOfBoundsException.
> ObjectCacheFactory should return null when tez shared object registry is not
> setup
> --
>
> Key: HIVE-17209
> URL: https://issues.apache.org/jira/browse/HIVE-17209
> Project: Hive
> Issue Type: Bug
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Attachments: HIVE-17209.1.patch
>
>
> HIVE-15269 introduced dynamic min/max bloom filter
> ("hive.tez.dynamic.semijoin.reduction=true"). This needs to access
> ObjectCache and in tez, ObjectCache can only be created by {{TezProcessor}}.
> In the following case {{AM --> splits -->
> OrcInputFormat.pickStripes::evaluatePredicateMinMax -->
> DynamicValue.getLiteral --> objectCache access}}, AM ends up throwing lots of
> NPE since AM has not created ObjectCache.
> Orc reader catches these exceptions, skips PPD and proceeds further. For e.g,
> in Q95 it ends up throwing ~30,000 NPE before completing split information.
> ObjectCacheFactory should return null when tez shared object registry is not
> setup.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17209) ObjectCacheFactory should return null when tez shared object registry is not setup
[
https://issues.apache.org/jira/browse/HIVE-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107746#comment-16107746
]
Sergey Shelukhin commented on HIVE-17209:
-
+1
> ObjectCacheFactory should return null when tez shared object registry is not
> setup
> --
>
> Key: HIVE-17209
> URL: https://issues.apache.org/jira/browse/HIVE-17209
> Project: Hive
> Issue Type: Bug
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Attachments: HIVE-17209.1.patch
>
>
> HIVE-15269 introduced dynamic min/max bloom filter
> ("hive.tez.dynamic.semijoin.reduction=true"). This needs to access
> ObjectCache and in tez, ObjectCache can only be created by {{TezProcessor}}.
> In the following case {{AM --> splits -->
> OrcInputFormat.pickStripes::evaluatePredicateMinMax -->
> DynamicValue.getLiteral --> objectCache access}}, AM ends up throwing lots of
> NPE since AM has not created ObjectCache.
> Orc reader catches these exceptions, skips PPD and proceeds further. For e.g,
> in Q95 it ends up throwing ~30,000 NPE before completing split information.
> ObjectCacheFactory should return null when tez shared object registry is not
> setup.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-17209) ObjectCacheFactory should return null when tez shared object registry is not setup
[
https://issues.apache.org/jira/browse/HIVE-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106764#comment-16106764
]
Hive QA commented on HIVE-17209:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12879552/HIVE-17209.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 11018 tests
executed
*Failed tests:*
{noformat}
TestPerfCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[create_merge_compressed]
(batchId=240)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite]
(batchId=240)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning]
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
(batchId=99)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
(batchId=179)
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
(batchId=179)
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
(batchId=179)
org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testConnection (batchId=241)
org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testIsValid (batchId=241)
org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testIsValidNeg (batchId=241)
org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testNegativeProxyAuth
(batchId=241)
org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testNegativeTokenAuth
(batchId=241)
org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testProxyAuth (batchId=241)
org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testTokenAuth (batchId=241)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6193/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6193/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6193/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12879552 - PreCommit-HIVE-Build
> ObjectCacheFactory should return null when tez shared object registry is not
> setup
> --
>
> Key: HIVE-17209
> URL: https://issues.apache.org/jira/browse/HIVE-17209
> Project: Hive
> Issue Type: Bug
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Attachments: HIVE-17209.1.patch
>
>
> HIVE-15269 introduced dynamic min/max bloom filter
> ("hive.tez.dynamic.semijoin.reduction=true"). This needs to access
> ObjectCache and in tez, ObjectCache can only be created by {{TezProcessor}}.
> In the following case {{AM --> splits -->
> OrcInputFormat.pickStripes::evaluatePredicateMinMax -->
> DynamicValue.getLiteral --> objectCache access}}, AM ends up throwing lots of
> NPE since AM has not created ObjectCache.
> Orc reader catches these exceptions, skips PPD and proceeds further. For e.g,
> in Q95 it ends up throwing ~30,000 NPE before completing split information.
> ObjectCacheFactory should return null when tez shared object registry is not
> setup.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
