[jira] [Commented] (HIVE-17549) Use SHA-256 for RowContainer to improve security
[ https://issues.apache.org/jira/browse/HIVE-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172650#comment-16172650 ] Rui Li commented on HIVE-17549: --- Thanks for the explanations [~txhsj]. It seems row container doesn't make efforts to secure the rows written to disk. That's why I'm not sure whether we need a stronger digest for the file name. [~taoli-hwx] what's your opinions about this? > Use SHA-256 for RowContainer to improve security > > > Key: HIVE-17549 > URL: https://issues.apache.org/jira/browse/HIVE-17549 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang > Attachments: HIVE-17549.1.patch > > > Use SHA-256 to replace md5 for RowContainer to improve security -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17549) Use SHA-256 for RowContainer to improve security
[ https://issues.apache.org/jira/browse/HIVE-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171577#comment-16171577 ] Saijin Huang commented on HIVE-17549: - Thanks for reply![~lirui].As we konw,MD5 is weaker than sha-256.it is necessary to replace md5 hash by sha-256.Also,RowContainer is used for SkewJoin.So in rowcontainer.java,the function "copyToDFSDirecory" is defined to copy tmpfile to hdfs path.However,the temp path generated by sha-256 is more security than md5 which help to hold the tmppath unique and security > Use SHA-256 for RowContainer to improve security > > > Key: HIVE-17549 > URL: https://issues.apache.org/jira/browse/HIVE-17549 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang > Attachments: HIVE-17549.1.patch > > > Use SHA-256 to replace md5 for RowContainer to improve security -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17549) Use SHA-256 for RowContainer to improve security
[ https://issues.apache.org/jira/browse/HIVE-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171233#comment-16171233 ] Rui Li commented on HIVE-17549: --- Hi [~txhsj], could you explain how the hash is used here and why we need a stronger implementation? Thanks. > Use SHA-256 for RowContainer to improve security > > > Key: HIVE-17549 > URL: https://issues.apache.org/jira/browse/HIVE-17549 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang > Attachments: HIVE-17549.1.patch > > > Use SHA-256 to replace md5 for RowContainer to improve security -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17549) Use SHA-256 for RowContainer to improve security
[ https://issues.apache.org/jira/browse/HIVE-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171051#comment-16171051 ] Saijin Huang commented on HIVE-17549: - [~lirui],can you take a review? > Use SHA-256 for RowContainer to improve security > > > Key: HIVE-17549 > URL: https://issues.apache.org/jira/browse/HIVE-17549 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang > Attachments: HIVE-17549.1.patch > > > Use SHA-256 to replace md5 for RowContainer to improve security -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17549) Use SHA-256 for RowContainer to improve security
[
https://issues.apache.org/jira/browse/HIVE-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170150#comment-16170150
]
Hive QA commented on HIVE-17549:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12887649/HIVE-17549.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 11041 tests
executed
*Failed tests:*
{noformat}
TestAccumuloCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=230)
TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=230)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_view] (batchId=39)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_hash]
(batchId=28)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats]
(batchId=156)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[drop_table_failure2]
(batchId=89)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
(batchId=234)
org.apache.hadoop.hive.ql.TestAcidOnTez.testCtasTezUnion (batchId=215)
org.apache.hadoop.hive.ql.TestAcidOnTez.testNonStandardConversion01
(batchId=215)
org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testMergeUnpartitioned01
(batchId=282)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6867/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6867/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6867/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 10 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12887649 - PreCommit-HIVE-Build
> Use SHA-256 for RowContainer to improve security
>
>
> Key: HIVE-17549
> URL: https://issues.apache.org/jira/browse/HIVE-17549
> Project: Hive
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Saijin Huang
>Assignee: Saijin Huang
> Attachments: HIVE-17549.1.patch
>
>
> Use SHA-256 to replace md5 for RowContainer to improve security
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
