[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244842#comment-16244842
]
Andrew Sherman commented on HIVE-17635:
---
Thanks for the push
> Add unit tests to
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225602#comment-16225602
]
Sahil Takiar commented on HIVE-17635:
-
+1
> Add unit tests to CompactionTxnHandler and use
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215468#comment-16215468
]
Andrew Sherman commented on HIVE-17635:
---
Test failures are unconnected with this change. So this is
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213870#comment-16213870
]
Hive QA commented on HIVE-17635:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204647#comment-16204647
]
Hive QA commented on HIVE-17635:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201122#comment-16201122
]
Andrew Sherman commented on HIVE-17635:
---
There is already a [review board review
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201077#comment-16201077
]
Sahil Takiar commented on HIVE-17635:
-
[~asherman] can you create an RB for this? There seem to be
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200529#comment-16200529
]
Andrew Sherman commented on HIVE-17635:
---
Assuming original reviewers are happy, can I maybe get a
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16197514#comment-16197514
]
Andrew Sherman commented on HIVE-17635:
---
Do the reviewers need any other information? [~alangates]
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192239#comment-16192239
]
Andrew Sherman commented on HIVE-17635:
---
Thanks [~alangates] for looking at the change
{quote}Why
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188458#comment-16188458
]
Alan Gates commented on HIVE-17635:
---
Why is it better to use PreparedStatements in cases where the query
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186072#comment-16186072
]
Andrew Sherman commented on HIVE-17635:
---
The test failures are not related to this change.
Please
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185305#comment-16185305
]
Hive QA commented on HIVE-17635:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185215#comment-16185215
]
Hive QA commented on HIVE-17635:
Here are the results of testing the latest attachment:
14 matches
Mail list logo