[jira] [Commented] (HIVE-17850) can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done?
[ https://issues.apache.org/jira/browse/HIVE-17850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213612#comment-16213612 ] Eugene Koifman commented on HIVE-17850: --- OrcInputFormat.getRecordReader() does some checks based on whether it has OrcSplit or just FileSplit. So does VectorizedOrcAcidRowBatchReader.canCreateVectorizedAcidRowBatchReaderOnSplit(). Under what circumstances would getRecordReader() see FileSplit which is not OrcSplit? VectorizedOrcAcidRowReader is used w/o HIVE-17458. Even with HIVE-17458 it will be used if the split is not OrcSplit. I'm trying to understand if that is actually possible. > can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done? > -- > > Key: HIVE-17850 > URL: https://issues.apache.org/jira/browse/HIVE-17850 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > > I don't think it will ever even be created once HIVE-17458 is done -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17850) can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done?
[ https://issues.apache.org/jira/browse/HIVE-17850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213592#comment-16213592 ] Sergey Shelukhin commented on HIVE-17850: - Oh, ic. Anyway, I guess it's never used then? I've little context on this > can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done? > -- > > Key: HIVE-17850 > URL: https://issues.apache.org/jira/browse/HIVE-17850 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > > I don't think it will ever even be created once HIVE-17458 is done -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17850) can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done?
[ https://issues.apache.org/jira/browse/HIVE-17850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213589#comment-16213589 ] Eugene Koifman commented on HIVE-17850: --- FileSplit is not OrcSplit > can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done? > -- > > Key: HIVE-17850 > URL: https://issues.apache.org/jira/browse/HIVE-17850 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > > I don't think it will ever even be created once HIVE-17458 is done -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17850) can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done?
[ https://issues.apache.org/jira/browse/HIVE-17850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213587#comment-16213587 ] Sergey Shelukhin commented on HIVE-17850: - OrcSplit is FileSplit > can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done? > -- > > Key: HIVE-17850 > URL: https://issues.apache.org/jira/browse/HIVE-17850 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > > I don't think it will ever even be created once HIVE-17458 is done -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-17850) can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done?
[ https://issues.apache.org/jira/browse/HIVE-17850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213579#comment-16213579 ] Eugene Koifman commented on HIVE-17850: --- OrcInputFormat uses this when the split is FileSplit but not OrcSplit - when does this even happen? > can VectorizedOrcAcidRowReader be removed once HIVE-17458 is done? > -- > > Key: HIVE-17850 > URL: https://issues.apache.org/jira/browse/HIVE-17850 > Project: Hive > Issue Type: Sub-task > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Minor > > I don't think it will ever even be created once HIVE-17458 is done -- This message was sent by Atlassian JIRA (v6.4.14#64029)
