[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277062#comment-16277062
]
Daniel Voros commented on HIVE-17988:
-
Thank you all for your review!
> Replace patch utility usage
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277057#comment-16277057
]
Sergio Peña commented on HIVE-17988:
Thanks [~dvoros]
> Replace patch utility usage with git apply in
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276032#comment-16276032
]
Daniel Voros commented on HIVE-17988:
-
[~spena] I did some testing with binary files and it seems to
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275171#comment-16275171
]
Sergio Peña commented on HIVE-17988:
+1
Please just make sure that you can use the patch utility to
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274161#comment-16274161
]
Daniel Voros commented on HIVE-17988:
-
[~spena] thank you for taking a look! That file is part of the
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273429#comment-16273429
]
Sergio Peña commented on HIVE-17988:
It looks good.
Btw, there is another smart-apply-patch.py file
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268682#comment-16268682
]
Zoltan Haindrich commented on HIVE-17988:
-
+1 looks good to me
[~spena], [~pvary] could you please
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257816#comment-16257816
]
Hive QA commented on HIVE-17988:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257574#comment-16257574
]
Hive QA commented on HIVE-17988:
Here are the results of testing the latest attachment:
