[jira] [Commented] (HIVE-18004) investigate deriving app name from JDBC connection for pool mapping
[ https://issues.apache.org/jira/browse/HIVE-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319387#comment-16319387 ] Prasanth Jayachandran commented on HIVE-18004: -- +1 > investigate deriving app name from JDBC connection for pool mapping > --- > > Key: HIVE-18004 > URL: https://issues.apache.org/jira/browse/HIVE-18004 > Project: Hive > Issue Type: Sub-task >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-18004.patch > > > There are some client info fields that popular apps (Tableau, etc) might > populate; this might allow us to map queries to pools based on an application > used. Need to take a look (see the doc for an example API we might look into) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18004) investigate deriving app name from JDBC connection for pool mapping
[ https://issues.apache.org/jira/browse/HIVE-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315667#comment-16315667 ] Harish Jaiprakash commented on HIVE-18004: -- Thanks [~sershe]. +1 for all the changes. > investigate deriving app name from JDBC connection for pool mapping > --- > > Key: HIVE-18004 > URL: https://issues.apache.org/jira/browse/HIVE-18004 > Project: Hive > Issue Type: Sub-task >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-18004.patch > > > There are some client info fields that popular apps (Tableau, etc) might > populate; this might allow us to map queries to pools based on an application > used. Need to take a look (see the doc for an example API we might look into) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18004) investigate deriving app name from JDBC connection for pool mapping
[
https://issues.apache.org/jira/browse/HIVE-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314875#comment-16314875
]
Hive QA commented on HIVE-18004:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12904879/HIVE-18004.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 11549 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2]
(batchId=48)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_2]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=159)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part]
(batchId=93)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[materialized_view_authorization_create_no_grant]
(batchId=93)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[stats_publisher_error_1]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=120)
org.apache.hadoop.hive.metastore.TestEmbeddedHiveMetaStore.testTransactionalValidation
(batchId=213)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=253)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=225)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=231)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=231)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=231)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8486/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8486/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8486/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 20 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12904879 - PreCommit-HIVE-Build
> investigate deriving app name from JDBC connection for pool mapping
> ---
>
> Key: HIVE-18004
> URL: https://issues.apache.org/jira/browse/HIVE-18004
> Project: Hive
> Issue Type: Sub-task
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-18004.patch
>
>
> There are some client info fields that popular apps (Tableau, etc) might
> populate; this might allow us to map queries to pools based on an application
> used. Need to take a look (see the doc for an example API we might look into)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18004) investigate deriving app name from JDBC connection for pool mapping
[
https://issues.apache.org/jira/browse/HIVE-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314844#comment-16314844
]
Hive QA commented on HIVE-18004:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
30s{color} | {color:red} ql: The patch generated 1 new + 42 unchanged - 1 fixed
= 43 total (was 43) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} jdbc: The patch generated 3 new + 63 unchanged - 0
fixed = 66 total (was 63) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / a6b88d9 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8486/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8486/yetus/diff-checkstyle-jdbc.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8486/yetus/whitespace-eol.txt
|
| modules | C: standalone-metastore metastore ql service jdbc U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8486/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> investigate deriving app name from JDBC connection for pool mapping
> ---
>
> Key: HIVE-18004
> URL: https://issues.apache.org/jira/browse/HIVE-18004
> Project: Hive
> Issue Type: Sub-task
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HIVE-18004.patch
>
>
> There are some client info fields that popular apps (Tableau, etc) might
> populate; this might allow us to map queries to pools based on an application
> used. Need to take a look (see the doc for an example API we might look into)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18004) investigate deriving app name from JDBC connection for pool mapping
[ https://issues.apache.org/jira/browse/HIVE-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312276#comment-16312276 ] Sergey Shelukhin commented on HIVE-18004: - We will go with (2) - url arguments > investigate deriving app name from JDBC connection for pool mapping > --- > > Key: HIVE-18004 > URL: https://issues.apache.org/jira/browse/HIVE-18004 > Project: Hive > Issue Type: Sub-task >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > > There are some client info fields that popular apps (Tableau, etc) might > populate; this might allow us to map queries to pools based on an application > used. Need to take a look (see the doc for an example API we might look into) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HIVE-18004) investigate deriving app name from JDBC connection for pool mapping
[ https://issues.apache.org/jira/browse/HIVE-18004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281179#comment-16281179 ] Sergey Shelukhin commented on HIVE-18004: - Looking at Tableau connecting via ODBC, I cannot see any identifying information. The properties map Tableau/ODBC passes to HS2 is an empty map. It is possible that some information is given to the ODBC driver, but not to HS2 via that... However, 1) JDBC setClientInfo and getClientInfo are not implemented in Hive JDBC driver and that seems to work just fine, so I assume not many people use these; we might implement them anyway in case someone does and catches the exception. 2) Judging by e.g. https://help.sap.com/doc/52715f71adba4aaeb480d946c742d1f6/2.0.00/en-US/e90fa1f0e06e4840aa3ee2278afae16b.html it looks like other tools rely on JDBC url arguments for this stuff, not on JDBC (or ODBC) API. So, we might do the same. cc [~hagleitn] [~cartershanklin] > investigate deriving app name from JDBC connection for pool mapping > --- > > Key: HIVE-18004 > URL: https://issues.apache.org/jira/browse/HIVE-18004 > Project: Hive > Issue Type: Sub-task >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > > There are some client info fields that popular apps (Tableau, etc) might > populate; this might allow us to map queries to pools based on an application > used. Need to take a look (see the doc for an example API we might look into) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
