[jira] [Commented] (HIVE-18808) Make compaction more robust when stats update fails
[ https://issues.apache.org/jira/browse/HIVE-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378977#comment-16378977 ] Alan Gates commented on HIVE-18808: --- +1. This looks like a reasonable compromise, as the next compaction should still recalculate the stats. > Make compaction more robust when stats update fails > --- > > Key: HIVE-18808 > URL: https://issues.apache.org/jira/browse/HIVE-18808 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 1.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-18808.01.patch > > > > Worker.gatherStats() runs a "analyze table..." command to update stats which > requires SessionState. SessionState objects are cached in ThreadLocal. If > for some reason Session init fails, it may still get attached to the thread > which then causes a subsequent request that uses the same tread to gather > stats fail because it has a bad session object. HIVE-15658 describes the > same issue in a different context. > There is currently no way to recycle a session from outside HMS. > Failure to gather stats should not kill a compaction job which then prevents > Cleaner from running. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18808) Make compaction more robust when stats update fails
[ https://issues.apache.org/jira/browse/HIVE-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377981#comment-16377981 ] Eugene Koifman commented on HIVE-18808: --- no related failures [~alangates] could you review please > Make compaction more robust when stats update fails > --- > > Key: HIVE-18808 > URL: https://issues.apache.org/jira/browse/HIVE-18808 > Project: Hive > Issue Type: Improvement > Components: Transactions >Affects Versions: 1.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-18808.01.patch > > > > Worker.gatherStats() runs a "analyze table..." command to update stats which > requires SessionState. SessionState objects are cached in ThreadLocal. If > for some reason Session init fails, it may still get attached to the thread > which then causes a subsequent request that uses the same tread to gather > stats fail because it has a bad session object. HIVE-15658 describes the > same issue in a different context. > There is currently no way to recycle a session from outside HMS. > Failure to gather stats should not kill a compaction job which then prevents > Cleaner from running. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18808) Make compaction more robust when stats update fails
[
https://issues.apache.org/jira/browse/HIVE-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377922#comment-16377922
]
Hive QA commented on HIVE-18808:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12912149/HIVE-18808.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 34 failed/errored test(s), 13014 tests
executed
*Failed tests:*
{noformat}
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=93)
[jira] [Commented] (HIVE-18808) Make compaction more robust when stats update fails
[
https://issues.apache.org/jira/browse/HIVE-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377892#comment-16377892
]
Hive QA commented on HIVE-18808:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
34s{color} | {color:red} ql: The patch generated 2 new + 9 unchanged - 4 fixed
= 11 total (was 13) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
25s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 53s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-9377/dev-support/hive-personality.sh
|
| git revision | master / 4b22fcb |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9377/yetus/diff-checkstyle-ql.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9377/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-9377/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Make compaction more robust when stats update fails
> ---
>
> Key: HIVE-18808
> URL: https://issues.apache.org/jira/browse/HIVE-18808
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
>Affects Versions: 1.0.0
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
>Priority: Major
> Attachments: HIVE-18808.01.patch
>
>
>
> Worker.gatherStats() runs a "analyze table..." command to update stats which
> requires SessionState. SessionState objects are cached in ThreadLocal. If
> for some reason Session init fails, it may still get attached to the thread
> which then causes a subsequent request that uses the same tread to gather
> stats fail because it has a bad session object. HIVE-15658 describes the
> same issue in a different context.
> There is currently no way to recycle a session from outside HMS.
> Failure to gather stats should not kill a compaction job which then prevents
> Cleaner from running.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
