[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384709#comment-16384709 ] Hive QA commented on HIVE-18848: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12912809/HIVE-18848.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 90 failed/errored test(s), 13455 tests executed *Failed tests:* {noformat} TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=94)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384685#comment-16384685 ] Hive QA commented on HIVE-18848: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 38s{color} | {color:red} ql: The patch generated 40 new + 37 unchanged - 1 fixed = 77 total (was 38) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 12s{color} | {color:red} The patch generated 49 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 7s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9458/dev-support/hive-personality.sh | | git revision | master / 53980ba | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9458/yetus/diff-checkstyle-ql.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9458/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9458/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.01.patch, HIVE-18848.02.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384502#comment-16384502 ] Hive QA commented on HIVE-18848: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12912809/HIVE-18848.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 85 failed/errored test(s), 13451 tests executed *Failed tests:* {noformat} TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=94)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384489#comment-16384489 ] Hive QA commented on HIVE-18848: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 36s{color} | {color:red} ql: The patch generated 40 new + 37 unchanged - 1 fixed = 77 total (was 38) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 21s{color} | {color:red} The patch generated 49 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 39s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9451/dev-support/hive-personality.sh | | git revision | master / 1a3090f | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9451/yetus/diff-checkstyle-ql.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9451/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9451/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.01.patch, HIVE-18848.02.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384487#comment-16384487 ] Hive QA commented on HIVE-18848: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12912809/HIVE-18848.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 88 failed/errored test(s), 13451 tests executed *Failed tests:* {noformat} TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=94)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384462#comment-16384462 ] Hive QA commented on HIVE-18848: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 38s{color} | {color:red} ql: The patch generated 40 new + 37 unchanged - 1 fixed = 77 total (was 38) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 19s{color} | {color:red} The patch generated 49 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 51s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9450/dev-support/hive-personality.sh | | git revision | master / 1a3090f | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9450/yetus/diff-checkstyle-ql.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9450/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9450/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.01.patch, HIVE-18848.02.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384455#comment-16384455 ] Hive QA commented on HIVE-18848: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12912809/HIVE-18848.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 85 failed/errored test(s), 13054 tests executed *Failed tests:* {noformat} TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=93)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384442#comment-16384442 ] Hive QA commented on HIVE-18848: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 39s{color} | {color:red} ql: The patch generated 40 new + 37 unchanged - 1 fixed = 77 total (was 38) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 49 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 12s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9449/dev-support/hive-personality.sh | | git revision | master / a4198f5 | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9449/yetus/diff-checkstyle-ql.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9449/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9449/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.01.patch, HIVE-18848.02.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384008#comment-16384008 ] Sergey Shelukhin commented on HIVE-18848: - Less than ten, the value must be... > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.01.patch, HIVE-18848.02.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383949#comment-16383949 ] Jesus Camacho Rodriguez commented on HIVE-18848: Thanks [~gopalv], I will apply the change. I expect a 'few' q file changes :) > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.01.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383105#comment-16383105 ] Gopal V commented on HIVE-18848: Almost missed the return from the middle, when reading this code {code} return visitCall((RexCall) RexUtil.invert(rexBuilder, call)); {code} Put the other branch in an else, so that it pops up easily when you read it? +1 tests pending > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.01.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18848) Improve readability of filter conditions in explain plan when CBO is run
[ https://issues.apache.org/jira/browse/HIVE-18848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383025#comment-16383025 ] Jesus Camacho Rodriguez commented on HIVE-18848: Cc [~gopalv] > Improve readability of filter conditions in explain plan when CBO is run > > > Key: HIVE-18848 > URL: https://issues.apache.org/jira/browse/HIVE-18848 > Project: Hive > Issue Type: Improvement > Components: CBO >Affects Versions: 3.0.0 >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Minor > Attachments: HIVE-18848.patch > > > CBO might return comparison operands in any non-deterministic order. Try to > show {{ }} when possible, i.e., {{c < 10}} rather > than {{10 > c}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)