[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415162#comment-16415162
]
ASF GitHub Bot commented on HIVE-18925:
---
Github user findepi closed the pull request at:
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414903#comment-16414903
]
Hive QA commented on HIVE-18925:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414846#comment-16414846
]
Hive QA commented on HIVE-18925:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414647#comment-16414647
]
Ashutosh Chauhan commented on HIVE-18925:
-
+1
> Hive doesn't work when JVM is
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414081#comment-16414081
]
Piotr Findeisen commented on HIVE-18925:
thanks [~lirui]! I deleted the wrongly named file to
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413785#comment-16413785
]
Rui Li commented on HIVE-18925:
---
BTW, the patch should be named {{HIVE-18925.2.patch}}. [~findepi] please
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413779#comment-16413779
]
Rui Li commented on HIVE-18925:
---
Thanks [~findepi] for the update. Currently we don't have a way to prevent
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412816#comment-16412816
]
Piotr Findeisen commented on HIVE-18925:
[~lirui] ,
- [~ashutoshc] expressed thought that
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411192#comment-16411192
]
Rui Li commented on HIVE-18925:
---
I tried TestTimestampParser#testPattern2. We parsed {{05:06:07 (of pattern
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410156#comment-16410156
]
Piotr Findeisen commented on HIVE-18925:
if this all is ok, how do i proceed to have the patch
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406534#comment-16406534
]
Piotr Findeisen commented on HIVE-18925:
oh, thanks!
should
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405584#comment-16405584
]
Ashutosh Chauhan commented on HIVE-18925:
-
This is only used to parse timestamp not dates. So,
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405529#comment-16405529
]
Sergey Shelukhin commented on HIVE-18925:
-
Hmm... I'm not familiar enough with this code to tell.
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405524#comment-16405524
]
Piotr Findeisen commented on HIVE-18925:
[~sershe] could you please check if this is a correct fix
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401241#comment-16401241
]
Piotr Findeisen commented on HIVE-18925:
[~hiveqa] ,
i think all you're saying is that the test
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401183#comment-16401183
]
Ashutosh Chauhan commented on HIVE-18925:
-
+1
> Hive doesn't work when JVM is
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401147#comment-16401147
]
Hive QA commented on HIVE-18925:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401080#comment-16401080
]
Hive QA commented on HIVE-18925:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398313#comment-16398313
]
Rui Li commented on HIVE-18925:
---
Hi [~findepi], the patch looks good to me. You need to press submit patch
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398216#comment-16398216
]
Piotr Findeisen commented on HIVE-18925:
I'm concerned that the patch (diff) doesn't convey the
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398215#comment-16398215
]
Piotr Findeisen commented on HIVE-18925:
Thanks [~sershe], [^HIVE-18925.patch] attached
> Hive
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396409#comment-16396409
]
Sergey Shelukhin commented on HIVE-18925:
-
[~findepi] can you attach a patch file named e.g.
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393721#comment-16393721
]
Piotr Findeisen commented on HIVE-18925:
i created a PR with this change.
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393720#comment-16393720
]
ASF GitHub Bot commented on HIVE-18925:
---
GitHub user findepi opened a pull request:
[
https://issues.apache.org/jira/browse/HIVE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393711#comment-16393711
]
Piotr Findeisen commented on HIVE-18925:
I think it should be sufficient to replace
{code:java}
25 matches
Mail list logo