[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465973#comment-16465973
]
Peter Vary commented on HIVE-19212:
---
Thanks for the patch [~stakiar]! Good to have this online :D
> Fix
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464040#comment-16464040
]
Sahil Takiar commented on HIVE-19212:
-
Pushed to master, but it looks like I have to run
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462546#comment-16462546
]
Peter Vary commented on HIVE-19212:
---
+1
> Fix findbugs yetus pre-commit checks
>
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457638#comment-16457638
]
Hive QA commented on HIVE-19212:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457630#comment-16457630
]
Hive QA commented on HIVE-19212:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456835#comment-16456835
]
Sahil Takiar commented on HIVE-19212:
-
[~szita] addressed your comments.
[~pvary] could you take a
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456469#comment-16456469
]
Adam Szita commented on HIVE-19212:
---
[~stakiar] the latest patch looks good, one small thing: can you
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453071#comment-16453071
]
Sahil Takiar commented on HIVE-19212:
-
[~szita] attached an updated patch that downloads the FindBugs
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452344#comment-16452344
]
Adam Szita commented on HIVE-19212:
---
[~stakiar] for temp dir you could use
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443318#comment-16443318
]
Hive QA commented on HIVE-19212:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443271#comment-16443271
]
Hive QA commented on HIVE-19212:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438454#comment-16438454
]
Sahil Takiar commented on HIVE-19212:
-
Looks like this is the cause -
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438450#comment-16438450
]
Sahil Takiar commented on HIVE-19212:
-
hmm thats odd, its definitely not working on the ptest machines
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438209#comment-16438209
]
Peter Vary commented on HIVE-19212:
---
I have tried your patch locally without the {{--dirty-workspace}}
[
https://issues.apache.org/jira/browse/HIVE-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437877#comment-16437877
]
Sahil Takiar commented on HIVE-19212:
-
[~pvary] lets try this again :)
It looks like when I was
15 matches
Mail list logo