[jira] [Commented] (HIVE-19477) Hiveserver2 in http mode not emitting metric default.General.open_connections

2018-05-14 Thread Dinesh Chitlangia (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474797#comment-16474797
 ] 

Dinesh Chitlangia commented on HIVE-19477:
--

[~jcamachorodriguez] thank you for fixing this!

> Hiveserver2 in http mode not emitting metric default.General.open_connections
> -
>
> Key: HIVE-19477
> URL: https://issues.apache.org/jira/browse/HIVE-19477
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Dinesh Chitlangia
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HIVE-19477.01.patch, HIVE-19477.patch
>
>
> Instances in binary mode are emitting the metric 
> _default.General.open_connections_ but the instances operating in http mode 
> are not emitting this metric.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19477) Hiveserver2 in http mode not emitting metric default.General.open_connections

2018-05-11 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471816#comment-16471816
 ] 

Hive QA commented on HIVE-19477:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12922712/HIVE-19477.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 34 failed/errored test(s), 13574 tests 
executed
*Failed tests:*
{noformat}
TestDbNotificationListener - did not produce a TEST-*.xml file (likely timed 
out) (batchId=247)
TestHCatHiveCompatibility - did not produce a TEST-*.xml file (likely timed 
out) (batchId=247)
TestNegativeCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=95)

[jira] [Commented] (HIVE-19477) Hiveserver2 in http mode not emitting metric default.General.open_connections

2018-05-11 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471753#comment-16471753
 ] 

Hive QA commented on HIVE-19477:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
37s{color} | {color:blue} service in master has 50 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} service: The patch generated 0 new + 5 unchanged - 2 
fixed = 5 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
13s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 32s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10822/dev-support/hive-personality.sh
 |
| git revision | master / 68b66a6 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-10822/yetus/patch-asflicense-problems.txt
 |
| modules | C: service U: service |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-10822/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Hiveserver2 in http mode not emitting metric default.General.open_connections
> -
>
> Key: HIVE-19477
> URL: https://issues.apache.org/jira/browse/HIVE-19477
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Dinesh Chitlangia
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-19477.01.patch, HIVE-19477.patch
>
>
> Instances in binary mode are emitting the metric 
> _default.General.open_connections_ but the instances operating in http mode 
> are not emitting this metric.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19477) Hiveserver2 in http mode not emitting metric default.General.open_connections

2018-05-09 Thread Vaibhav Gumashta (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469393#comment-16469393
 ] 

Vaibhav Gumashta commented on HIVE-19477:
-

+1

> Hiveserver2 in http mode not emitting metric default.General.open_connections
> -
>
> Key: HIVE-19477
> URL: https://issues.apache.org/jira/browse/HIVE-19477
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Dinesh Chitlangia
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-19477.01.patch, HIVE-19477.patch
>
>
> Instances in binary mode are emitting the metric 
> _default.General.open_connections_ but the instances operating in http mode 
> are not emitting this metric.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19477) Hiveserver2 in http mode not emitting metric default.General.open_connections

2018-05-09 Thread Vaibhav Gumashta (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469359#comment-16469359
 ] 

Vaibhav Gumashta commented on HIVE-19477:
-

[~jcamachorodriguez] Patch looks good, but the LOG message should be change to 
reflect that we are capturing metrics for HS2 open/close connections and not 
JDO.

> Hiveserver2 in http mode not emitting metric default.General.open_connections
> -
>
> Key: HIVE-19477
> URL: https://issues.apache.org/jira/browse/HIVE-19477
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Dinesh Chitlangia
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-19477.patch
>
>
> Instances in binary mode are emitting the metric 
> _default.General.open_connections_ but the instances operating in http mode 
> are not emitting this metric.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19477) Hiveserver2 in http mode not emitting metric default.General.open_connections

2018-05-09 Thread Dinesh Chitlangia (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469126#comment-16469126
 ] 

Dinesh Chitlangia commented on HIVE-19477:
--

[~jcamachorodriguez] - Thanks for opening this jira.

> Hiveserver2 in http mode not emitting metric default.General.open_connections
> -
>
> Key: HIVE-19477
> URL: https://issues.apache.org/jira/browse/HIVE-19477
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Dinesh Chitlangia
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-19477.patch
>
>
> Instances in binary mode are emitting the metric 
> _default.General.open_connections_ but the instances operating in http mode 
> are not emitting this metric.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19477) Hiveserver2 in http mode not emitting metric default.General.open_connections

2018-05-09 Thread Jesus Camacho Rodriguez (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-19477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469100#comment-16469100
 ] 

Jesus Camacho Rodriguez commented on HIVE-19477:


[~thejas], could you take a look to confirm approach is correct? Thanks

> Hiveserver2 in http mode not emitting metric default.General.open_connections
> -
>
> Key: HIVE-19477
> URL: https://issues.apache.org/jira/browse/HIVE-19477
> Project: Hive
>  Issue Type: Bug
>  Components: HiveServer2
>Reporter: Dinesh Chitlangia
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Attachments: HIVE-19477.patch
>
>
> Instances in binary mode are emitting the metric 
> _default.General.open_connections_ but the instances operating in http mode 
> are not emitting this metric.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)