[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488418#comment-16488418
]
Hive QA commented on HIVE-19557:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12924791/HIVE-19557.04.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14395 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11172/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11172/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11172/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12924791 - PreCommit-HIVE-Build
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-19557.01.patch, HIVE-19557.02.patch,
> HIVE-19557.03.patch, HIVE-19557.04.patch, HIVE-19557.04.patch
>
>
> in StatsRulesProcFactory
> [https://github.com/apache/hive/blob/ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L754|dates
> are assumed to be an integer]; however this is currently not true - and the
> resulting exception is handled as a default case... for N/3
> {code}
> set hive.explain.user=true;
> create table d1(d date);
> -- tblproperties('transactional'='false');
> insert into d1 values
> ('2010-10-01'),
> ('2010-10-02'),
> ('2010-10-03'),
> ('2010-10-04'),
> ('2010-10-05'),
> ('2010-10-06'),
> ('2010-10-07'),
> ('2010-10-08'),
> ('2010-10-09'),
> ('2010-10-10');
> analyze table d1 compute statistics for columns;
> desc formatted d1;
> desc formatted d1 d;
> explain
> select 'stats: FIL ~0 read',count(1) from d1 where d < '2010-03-01';
> explain
> select 'stats: FIL estimate some read',count(1) from d1 where d <
> '2010-10-03';
> explain
> select 'stats: FIL estimate all read',count(1) from d1 where d < '2010-11-03';
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488399#comment-16488399
]
Hive QA commented on HIVE-19557:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
51s{color} | {color:blue} ql in master has 2322 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
38s{color} | {color:red} ql: The patch generated 1 new + 39 unchanged - 0 fixed
= 40 total (was 39) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 10 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
2s{color} | {color:red} ql generated 1 new + 2322 unchanged - 0 fixed = 2323
total (was 2322) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Comparison of String objects using == or != in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule.evaluateComparator(Statistics,
ExprNodeGenericFuncDesc, long) At StatsRulesProcFactory.java:== or != in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule.evaluateComparator(Statistics,
ExprNodeGenericFuncDesc, long) At StatsRulesProcFactory.java:[line 757] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11172/dev-support/hive-personality.sh
|
| git revision | master / 29e4f3b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11172/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11172/yetus/whitespace-tabs.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11172/yetus/new-findbugs-ql.html
|
| modules | C: itests ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11172/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-19557.01.patch,
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487612#comment-16487612
]
Jesus Camacho Rodriguez commented on HIVE-19557:
[~kgyrtkirk], is there any special reason why this patch went in without a
clean QA run? If there is not, I will revert it.
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-19557.01.patch, HIVE-19557.02.patch,
> HIVE-19557.03.patch, HIVE-19557.04.patch
>
>
> in StatsRulesProcFactory
> [https://github.com/apache/hive/blob/ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L754|dates
> are assumed to be an integer]; however this is currently not true - and the
> resulting exception is handled as a default case... for N/3
> {code}
> set hive.explain.user=true;
> create table d1(d date);
> -- tblproperties('transactional'='false');
> insert into d1 values
> ('2010-10-01'),
> ('2010-10-02'),
> ('2010-10-03'),
> ('2010-10-04'),
> ('2010-10-05'),
> ('2010-10-06'),
> ('2010-10-07'),
> ('2010-10-08'),
> ('2010-10-09'),
> ('2010-10-10');
> analyze table d1 compute statistics for columns;
> desc formatted d1;
> desc formatted d1 d;
> explain
> select 'stats: FIL ~0 read',count(1) from d1 where d < '2010-03-01';
> explain
> select 'stats: FIL estimate some read',count(1) from d1 where d <
> '2010-10-03';
> explain
> select 'stats: FIL estimate all read',count(1) from d1 where d < '2010-11-03';
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487205#comment-16487205
]
Hive QA commented on HIVE-19557:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12924616/HIVE-19557.04.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14344 tests
executed
*Failed tests:*
{noformat}
TestBeeLineWithArgs - did not produce a TEST-*.xml file (likely timed out)
(batchId=237)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[sample6] (batchId=69)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11157/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11157/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11157/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12924616 - PreCommit-HIVE-Build
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-19557.01.patch, HIVE-19557.02.patch,
> HIVE-19557.03.patch, HIVE-19557.04.patch
>
>
> in StatsRulesProcFactory
> [https://github.com/apache/hive/blob/ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L754|dates
> are assumed to be an integer]; however this is currently not true - and the
> resulting exception is handled as a default case... for N/3
> {code}
> set hive.explain.user=true;
> create table d1(d date);
> -- tblproperties('transactional'='false');
> insert into d1 values
> ('2010-10-01'),
> ('2010-10-02'),
> ('2010-10-03'),
> ('2010-10-04'),
> ('2010-10-05'),
> ('2010-10-06'),
> ('2010-10-07'),
> ('2010-10-08'),
> ('2010-10-09'),
> ('2010-10-10');
> analyze table d1 compute statistics for columns;
> desc formatted d1;
> desc formatted d1 d;
> explain
> select 'stats: FIL ~0 read',count(1) from d1 where d < '2010-03-01';
> explain
> select 'stats: FIL estimate some read',count(1) from d1 where d <
> '2010-10-03';
> explain
> select 'stats: FIL estimate all read',count(1) from d1 where d < '2010-11-03';
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487154#comment-16487154
]
Hive QA commented on HIVE-19557:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
45s{color} | {color:blue} ql in master has 2322 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
37s{color} | {color:red} ql: The patch generated 1 new + 39 unchanged - 0 fixed
= 40 total (was 39) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 10 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
4s{color} | {color:red} ql generated 1 new + 2322 unchanged - 0 fixed = 2323
total (was 2322) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Comparison of String objects using == or != in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule.evaluateComparator(Statistics,
ExprNodeGenericFuncDesc, long) At StatsRulesProcFactory.java:== or != in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule.evaluateComparator(Statistics,
ExprNodeGenericFuncDesc, long) At StatsRulesProcFactory.java:[line 757] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11157/dev-support/hive-personality.sh
|
| git revision | master / 4f789cc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11157/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11157/yetus/whitespace-tabs.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11157/yetus/new-findbugs-ql.html
|
| modules | C: itests ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11157/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-19557.01.patch, HIVE-19557.02.patch,
>
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1640#comment-1640
]
Ashutosh Chauhan commented on HIVE-19557:
-
+1
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-19557.01.patch, HIVE-19557.02.patch
>
>
> in StatsRulesProcFactory
> [https://github.com/apache/hive/blob/ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L754|dates
> are assumed to be an integer]; however this is currently not true - and the
> resulting exception is handled as a default case... for N/3
> {code}
> set hive.explain.user=true;
> create table d1(d date);
> -- tblproperties('transactional'='false');
> insert into d1 values
> ('2010-10-01'),
> ('2010-10-02'),
> ('2010-10-03'),
> ('2010-10-04'),
> ('2010-10-05'),
> ('2010-10-06'),
> ('2010-10-07'),
> ('2010-10-08'),
> ('2010-10-09'),
> ('2010-10-10');
> analyze table d1 compute statistics for columns;
> desc formatted d1;
> desc formatted d1 d;
> explain
> select 'stats: FIL ~0 read',count(1) from d1 where d < '2010-03-01';
> explain
> select 'stats: FIL estimate some read',count(1) from d1 where d <
> '2010-10-03';
> explain
> select 'stats: FIL estimate all read',count(1) from d1 where d < '2010-11-03';
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477703#comment-16477703
]
Hive QA commented on HIVE-19557:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12923609/HIVE-19557.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 14396 tests
executed
*Failed tests:*
{noformat}
TestMinimrCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=94)
[infer_bucket_sort_num_buckets.q,infer_bucket_sort_reducers_power_two.q,parallel_orderby.q,bucket_num_reducers_acid.q,scriptfile1.q,infer_bucket_sort_map_operators.q,infer_bucket_sort_merge.q,root_dir_external_table.q,infer_bucket_sort_dyn_part.q,udf_using.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_cross_product_check_2]
(batchId=21)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[d1] (batchId=6)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_4]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_between_in]
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat]
(batchId=183)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/10991/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10991/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10991/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12923609 - PreCommit-HIVE-Build
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-19557.01.patch, HIVE-19557.02.patch
>
>
> in StatsRulesProcFactory
> [https://github.com/apache/hive/blob/ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L754|dates
> are assumed to be an integer]; however this is currently not true - and the
> resulting exception is handled as a default case... for N/3
> {code}
> set hive.explain.user=true;
> create table d1(d date);
> -- tblproperties('transactional'='false');
> insert into d1 values
> ('2010-10-01'),
> ('2010-10-02'),
> ('2010-10-03'),
> ('2010-10-04'),
> ('2010-10-05'),
> ('2010-10-06'),
> ('2010-10-07'),
> ('2010-10-08'),
> ('2010-10-09'),
> ('2010-10-10');
> analyze table d1 compute statistics for columns;
> desc formatted d1;
> desc formatted d1 d;
> explain
> select 'stats: FIL ~0 read',count(1) from d1 where d < '2010-03-01';
> explain
> select 'stats: FIL estimate some read',count(1) from d1 where d <
> '2010-10-03';
> explain
> select 'stats: FIL estimate all read',count(1) from d1 where d < '2010-11-03';
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477621#comment-16477621
]
Hive QA commented on HIVE-19557:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
49s{color} | {color:blue} ql in master has 2320 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
36s{color} | {color:red} ql: The patch generated 1 new + 39 unchanged - 0 fixed
= 40 total (was 39) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 10 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
7s{color} | {color:red} ql generated 1 new + 2320 unchanged - 0 fixed = 2321
total (was 2320) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 50s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Comparison of String objects using == or != in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule.evaluateComparator(Statistics,
ExprNodeGenericFuncDesc, long) At StatsRulesProcFactory.java:== or != in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule.evaluateComparator(Statistics,
ExprNodeGenericFuncDesc, long) At StatsRulesProcFactory.java:[line 757] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10991/dev-support/hive-personality.sh
|
| git revision | master / bd9264f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10991/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10991/yetus/whitespace-tabs.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10991/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10991/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-19557.01.patch, HIVE-19557.02.patch
>
>
> in StatsRulesProcFactory
> [https://github.com/apache/hive/blob/ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L754|dates
> are assumed to be an integer]; however this is currently not true - and the
> resulting exception
[jira] [Commented] (HIVE-19557) stats: filters for dates are not taking advantage of min/max values
[
https://issues.apache.org/jira/browse/HIVE-19557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476983#comment-16476983
]
Hive QA commented on HIVE-19557:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12923503/HIVE-19557.01.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/10983/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10983/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10983/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-05-16 07:43:50.688
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-10983/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-05-16 07:43:50.691
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 38c757c HIVE-19495: Arrow SerDe itest failure (Teddy Choi,
reviewed by Matt McCline)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 38c757c HIVE-19495: Arrow SerDe itest failure (Teddy Choi,
reviewed by Matt McCline)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-05-16 07:43:52.006
+ rm -rf ../yetus_PreCommit-HIVE-Build-10983
+ mkdir ../yetus_PreCommit-HIVE-Build-10983
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-10983
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-10983/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java:106
error: repository lacks the necessary blob to fall back on 3-way merge.
error:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java:
patch does not apply
error:
src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java:
does not exist in index
error:
java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java:
does not exist in index
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12923503 - PreCommit-HIVE-Build
> stats: filters for dates are not taking advantage of min/max values
> ---
>
> Key: HIVE-19557
> URL: https://issues.apache.org/jira/browse/HIVE-19557
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-19557.01.patch
>
>
> in StatsRulesProcFactory
> [https://github.com/apache/hive/blob/ab189f54047bbf6beeeaf8d0dcfd5fbe92e465fb/ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java#L754|dates
> are assumed to be an integer]; however this is currently not true - and the
> resulting exception is handled as a default case... for N/3
> {code}
> set hive.explain.user=true;
> create table d1(d date);
> -- tblproperties('transactional'='false');
> insert into d1 values
> ('2010-10-01'),
> ('2010-10-02'),
> ('2010-10-03'),
> ('2010-10-04'),
> ('2010-10-05'),
> ('2010-10-06'),
> ('2010-10-07'),
> ('2010-10-08'),
> ('2010-10-09'),
> ('2010-10-10');
> analyze table d1 compute statistics for columns;
> desc formatted d1;
> desc
