[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616733#comment-16616733 ] Hive QA commented on HIVE-19685: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16616618#comment-16616618 ] Prasanth Jayachandran commented on HIVE-19685: -- Looks like the patch needs another rebase..

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503472#comment-16503472 ] Hive QA commented on HIVE-19685: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502634#comment-16502634 ] Alexander Kolbasov commented on HIVE-19685: --- [~tlipcon] can you add reviewboard link for your

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502374#comment-16502374 ] Todd Lipcon commented on HIVE-19685: Thanks Vihang, was OOO yesterday. > OpenTracing support for HMS

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500864#comment-16500864 ] Vihang Karajgaonkar commented on HIVE-19685: Looks like Todd is busy. Rebased the patch and

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498832#comment-16498832 ] Prasanth Jayachandran commented on HIVE-19685: -- looks like the patch needs rebase >

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496987#comment-16496987 ] Hive QA commented on HIVE-19685: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493771#comment-16493771 ] Todd Lipcon commented on HIVE-19685: OK, re-uploaded. > OpenTracing support for HMS >

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492350#comment-16492350 ] Prasanth Jayachandran commented on HIVE-19685: -- There is a test failure although doesn't look

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491467#comment-16491467 ] Hive QA commented on HIVE-19685: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491453#comment-16491453 ] Hive QA commented on HIVE-19685: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491100#comment-16491100 ] Prasanth Jayachandran commented on HIVE-19685: -- [~tlipcon] Your patch is already in the queue

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491000#comment-16491000 ] Todd Lipcon commented on HIVE-19685: Thanks for the review [~prasanth_j]. Is there something I need to

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490284#comment-16490284 ] Prasanth Jayachandran commented on HIVE-19685: -- lgtm, +1 > OpenTracing support for HMS >

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488158#comment-16488158 ] Prasanth Jayachandran commented on HIVE-19685: -- {quote}if you drop one of the tracer

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488142#comment-16488142 ] Todd Lipcon commented on HIVE-19685: [~prasanth_j] sorry, didn't see your question as it came while I

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488139#comment-16488139 ] Todd Lipcon commented on HIVE-19685: Before working on a patch against trunk, wanted to run a summary

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488136#comment-16488136 ] Prasanth Jayachandran commented on HIVE-19685: -- Where does trace data gets stored? Is traces

[jira] [Commented] (HIVE-19685) OpenTracing support for HMS

[ https://issues.apache.org/jira/browse/HIVE-19685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488129#comment-16488129 ] Todd Lipcon commented on HIVE-19685: Following is a screenshot of the trace view for the simple