[jira] [Commented] (HIVE-20177) Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
[ https://issues.apache.org/jira/browse/HIVE-20177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554862#comment-16554862 ] Matt McCline commented on HIVE-20177: - +1 LGTM. > Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode > - > > Key: HIVE-20177 > URL: https://issues.apache.org/jira/browse/HIVE-20177 > Project: Hive > Issue Type: Bug > Components: Vectorization >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Labels: performance > Attachments: HIVE-20177.01.patch, HIVE-20177.WIP.patch > > > The streaming mode for VectorGroupBy allocates a large number of arrays due > to VectorKeyHashWrapper::duplicateTo() > Since the vectors can't be mutated in-place while a single batch is being > processed, this operation can be cut by 1000x by allocating a streaming key > at the end of the loop, instead of reallocating within the loop. > {code} > for(int i = 0; i < batch.size; ++i) { > if (!batchKeys[i].equals(streamingKey)) { > // We've encountered a new key, must save current one > // We can't forward yet, the aggregators have not been evaluated > rowsToFlush[flushMark] = currentStreamingAggregators; > if (keysToFlush[flushMark] == null) { > keysToFlush[flushMark] = (VectorHashKeyWrapper) > streamingKey.copyKey(); > } else { > streamingKey.duplicateTo(keysToFlush[flushMark]); > } > currentStreamingAggregators = > streamAggregationBufferRowPool.getFromPool(); > batchKeys[i].duplicateTo(streamingKey); > ++flushMark; > } > {code} > The duplicateTo can be pushed out of the loop since there only one to truly > keep a copy of is the last unique key in the VRB. > The actual byte[] values within the keys are safely copied out by - > VectorHashKeyWrapperBatch.assignRowColumn() which calls setVal() and not > setRef(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20177) Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
[ https://issues.apache.org/jira/browse/HIVE-20177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553690#comment-16553690 ] Gopal V commented on HIVE-20177: [~mmccline]: this is a perf fix for very large gbys - clean test-run. > Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode > - > > Key: HIVE-20177 > URL: https://issues.apache.org/jira/browse/HIVE-20177 > Project: Hive > Issue Type: Bug > Components: Vectorization >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Labels: performance > Attachments: HIVE-20177.01.patch, HIVE-20177.WIP.patch > > > The streaming mode for VectorGroupBy allocates a large number of arrays due > to VectorKeyHashWrapper::duplicateTo() > Since the vectors can't be mutated in-place while a single batch is being > processed, this operation can be cut by 1000x by allocating a streaming key > at the end of the loop, instead of reallocating within the loop. > {code} > for(int i = 0; i < batch.size; ++i) { > if (!batchKeys[i].equals(streamingKey)) { > // We've encountered a new key, must save current one > // We can't forward yet, the aggregators have not been evaluated > rowsToFlush[flushMark] = currentStreamingAggregators; > if (keysToFlush[flushMark] == null) { > keysToFlush[flushMark] = (VectorHashKeyWrapper) > streamingKey.copyKey(); > } else { > streamingKey.duplicateTo(keysToFlush[flushMark]); > } > currentStreamingAggregators = > streamAggregationBufferRowPool.getFromPool(); > batchKeys[i].duplicateTo(streamingKey); > ++flushMark; > } > {code} > The duplicateTo can be pushed out of the loop since there only one to truly > keep a copy of is the last unique key in the VRB. > The actual byte[] values within the keys are safely copied out by - > VectorHashKeyWrapperBatch.assignRowColumn() which calls setVal() and not > setRef(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20177) Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
[ https://issues.apache.org/jira/browse/HIVE-20177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546056#comment-16546056 ] Hive QA commented on HIVE-20177: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12931841/HIVE-20177.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14661 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12649/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12649/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12649/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12931841 - PreCommit-HIVE-Build > Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode > - > > Key: HIVE-20177 > URL: https://issues.apache.org/jira/browse/HIVE-20177 > Project: Hive > Issue Type: Bug > Components: Vectorization >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-20177.01.patch, HIVE-20177.WIP.patch > > > The streaming mode for VectorGroupBy allocates a large number of arrays due > to VectorKeyHashWrapper::duplicateTo() > Since the vectors can't be mutated in-place while a single batch is being > processed, this operation can be cut by 1000x by allocating a streaming key > at the end of the loop, instead of reallocating within the loop. > {code} > for(int i = 0; i < batch.size; ++i) { > if (!batchKeys[i].equals(streamingKey)) { > // We've encountered a new key, must save current one > // We can't forward yet, the aggregators have not been evaluated > rowsToFlush[flushMark] = currentStreamingAggregators; > if (keysToFlush[flushMark] == null) { > keysToFlush[flushMark] = (VectorHashKeyWrapper) > streamingKey.copyKey(); > } else { > streamingKey.duplicateTo(keysToFlush[flushMark]); > } > currentStreamingAggregators = > streamAggregationBufferRowPool.getFromPool(); > batchKeys[i].duplicateTo(streamingKey); > ++flushMark; > } > {code} > The duplicateTo can be pushed out of the loop since there only one to truly > keep a copy of is the last unique key in the VRB. > The actual byte[] values within the keys are safely copied out by - > VectorHashKeyWrapperBatch.assignRowColumn() which calls setVal() and not > setRef(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20177) Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
[ https://issues.apache.org/jira/browse/HIVE-20177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546038#comment-16546038 ] Hive QA commented on HIVE-20177: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 28s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 17s{color} | {color:blue} ql in master has 2273 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 29s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12649/dev-support/hive-personality.sh | | git revision | master / 85a3dd7 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12649/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode > - > > Key: HIVE-20177 > URL: https://issues.apache.org/jira/browse/HIVE-20177 > Project: Hive > Issue Type: Bug > Components: Vectorization >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-20177.01.patch, HIVE-20177.WIP.patch > > > The streaming mode for VectorGroupBy allocates a large number of arrays due > to VectorKeyHashWrapper::duplicateTo() > Since the vectors can't be mutated in-place while a single batch is being > processed, this operation can be cut by 1000x by allocating a streaming key > at the end of the loop, instead of reallocating within the loop. > {code} > for(int i = 0; i < batch.size; ++i) { > if (!batchKeys[i].equals(streamingKey)) { > // We've encountered a new key, must save current one > // We can't forward yet, the aggregators have not been evaluated > rowsToFlush[flushMark] = currentStreamingAggregators; > if (keysToFlush[flushMark] == null) { > keysToFlush[flushMark] = (VectorHashKeyWrapper) > streamingKey.copyKey(); > } else { > streamingKey.duplicateTo(keysToFlush[flushMark]); > } > currentStreamingAggregators = > streamAggregationBufferRowPool.getFromPool(); > batchKeys[i].duplicateTo(streamingKey); > ++flushMark; > } > {code} > The duplicateTo can be pushed out of the loop since there only one to truly > keep a copy of is the last unique key in the VRB. >
[jira] [Commented] (HIVE-20177) Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
[ https://issues.apache.org/jira/browse/HIVE-20177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544523#comment-16544523 ] Hive QA commented on HIVE-20177: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12931695/HIVE-20177.WIP.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14649 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12623/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12623/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12623/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12931695 - PreCommit-HIVE-Build > Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode > - > > Key: HIVE-20177 > URL: https://issues.apache.org/jira/browse/HIVE-20177 > Project: Hive > Issue Type: Bug > Components: Vectorization >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-20177.WIP.patch > > > The streaming mode for VectorGroupBy allocates a large number of arrays due > to VectorKeyHashWrapper::duplicateTo() > Since the vectors can't be mutated in-place while a single batch is being > processed, this operation can be cut by 1000x by allocating a streaming key > at the end of the loop, instead of reallocating within the loop. > {code} > for(int i = 0; i < batch.size; ++i) { > if (!batchKeys[i].equals(streamingKey)) { > // We've encountered a new key, must save current one > // We can't forward yet, the aggregators have not been evaluated > rowsToFlush[flushMark] = currentStreamingAggregators; > if (keysToFlush[flushMark] == null) { > keysToFlush[flushMark] = (VectorHashKeyWrapper) > streamingKey.copyKey(); > } else { > streamingKey.duplicateTo(keysToFlush[flushMark]); > } > currentStreamingAggregators = > streamAggregationBufferRowPool.getFromPool(); > batchKeys[i].duplicateTo(streamingKey); > ++flushMark; > } > {code} > The duplicateTo can be pushed out of the loop since there only one to truly > keep a copy of is the last unique key in the VRB. > The actual byte[] values within the keys are safely copied out by - > VectorHashKeyWrapperBatch.assignRowColumn() which calls setVal() and not > setRef(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20177) Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode
[ https://issues.apache.org/jira/browse/HIVE-20177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544509#comment-16544509 ] Hive QA commented on HIVE-20177: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 12s{color} | {color:blue} ql in master has 2291 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12623/dev-support/hive-personality.sh | | git revision | master / 1b5903b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-12623/yetus/whitespace-eol.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12623/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Vectorization: Reduce KeyWrapper allocation in GroupBy Streaming mode > - > > Key: HIVE-20177 > URL: https://issues.apache.org/jira/browse/HIVE-20177 > Project: Hive > Issue Type: Bug > Components: Vectorization >Reporter: Gopal V >Assignee: Gopal V >Priority: Major > Attachments: HIVE-20177.WIP.patch > > > The streaming mode for VectorGroupBy allocates a large number of arrays due > to VectorKeyHashWrapper::duplicateTo() > Since the vectors can't be mutated in-place while a single batch is being > processed, this operation can be cut by 1000x by allocating a streaming key > at the end of the loop, instead of reallocating within the loop. > {code} > for(int i = 0; i < batch.size; ++i) { > if (!batchKeys[i].equals(streamingKey)) { > // We've encountered a new key, must save current one > // We can't forward yet, the aggregators have not been evaluated > rowsToFlush[flushMark] = currentStreamingAggregators; > if (keysToFlush[flushMark] == null) { > keysToFlush[flushMark] = (VectorHashKeyWrapper) > streamingKey.copyKey(); > } else { > streamingKey.duplicateTo(keysToFlush[flushMark]); > } > currentStreamingAggregators = > streamAggregationBufferRowPool.getFromPool(); > batchKeys[i].duplicateTo(streamingKey); >