[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703714#comment-16703714
]
Naveen Gangam commented on HIVE-20740:
--
Looks good to me. +1
> Remove global lock in
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700701#comment-16700701
]
Andrew Sherman commented on HIVE-20740:
---
+1 LGTM
> Remove global lock in ObjectStore.setConf
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700013#comment-16700013
]
Vihang Karajgaonkar commented on HIVE-20740:
Finally a green run. [~asherman] Updated the RB
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699886#comment-16699886
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699869#comment-16699869
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699624#comment-16699624
]
Vihang Karajgaonkar commented on HIVE-20740:
cbo_limit.q failure is unrelated to this patch.
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699601#comment-16699601
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699576#comment-16699576
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699559#comment-16699559
]
Vihang Karajgaonkar commented on HIVE-20740:
The test failures occur only on the precommit
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684538#comment-16684538
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684487#comment-16684487
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682159#comment-16682159
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680304#comment-16680304
]
Vihang Karajgaonkar commented on HIVE-20740:
The error logs say this :(
{noformat}
[INFO]
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678616#comment-16678616
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678580#comment-16678580
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677490#comment-16677490
]
Vihang Karajgaonkar commented on HIVE-20740:
These tests are working for me locally and
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674205#comment-16674205
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674188#comment-16674188
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673729#comment-16673729
]
Vihang Karajgaonkar commented on HIVE-20740:
Test is working for me locally. I will create a
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673025#comment-16673025
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673002#comment-16673002
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671953#comment-16671953
]
Vihang Karajgaonkar commented on HIVE-20740:
Reattached the last patch since precommit queue
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667061#comment-16667061
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667016#comment-16667016
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1680#comment-1680
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1647#comment-1647
]
Hive QA commented on HIVE-20740:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1237#comment-1237
]
Vihang Karajgaonkar commented on HIVE-20740:
Spent some more time on this. Based on what I
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659247#comment-16659247
]
Vihang Karajgaonkar commented on HIVE-20740:
Okay, so looks like there is more to this than
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657839#comment-16657839
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657829#comment-16657829
]
Hive QA commented on HIVE-20740:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654441#comment-16654441
]
Vihang Karajgaonkar commented on HIVE-20740:
Test failures may be related. Taking a look.
>
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653606#comment-16653606
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653146#comment-16653146
]
Hive QA commented on HIVE-20740:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653078#comment-16653078
]
Hive QA commented on HIVE-20740:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652889#comment-16652889
]
Alan Gates commented on HIVE-20740:
---
Will be a couple of days before I have time to look at it.
cc
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652579#comment-16652579
]
Vihang Karajgaonkar commented on HIVE-20740:
v2 patch includes suggested changes from
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652576#comment-16652576
]
Vihang Karajgaonkar commented on HIVE-20740:
Added review board link.
> Remove global lock
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652401#comment-16652401
]
Vihang Karajgaonkar commented on HIVE-20740:
[~asherman] [~pvary] Can you please help review?
[
https://issues.apache.org/jira/browse/HIVE-20740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652282#comment-16652282
]
Vihang Karajgaonkar commented on HIVE-20740:
Turns out there was a race condition as well in
39 matches
Mail list logo
