[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675473#comment-16675473
]
Vineet Garg commented on HIVE-20839:
+1
Can you open a jira to add tests once HIVE-20833 is in?
>
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674760#comment-16674760
]
Jason Dere commented on HIVE-20839:
---
Hey [~vgarg], ptests went through, is this patch good to commit?
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674314#comment-16674314
]
Hive QA commented on HIVE-20839:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674309#comment-16674309
]
Hive QA commented on HIVE-20839:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672616#comment-16672616
]
Hive QA commented on HIVE-20839:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672589#comment-16672589
]
Hive QA commented on HIVE-20839:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670446#comment-16670446
]
Jason Dere commented on HIVE-20839:
---
Thanks [~vgarg]. Attaching new patch using .equals() rather than
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669460#comment-16669460
]
Vineet Garg commented on HIVE-20839:
Equal will work here because Join key seems to be referring to
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669459#comment-16669459
]
Vineet Garg commented on HIVE-20839:
[~jdere] Went through the patch. This will fix the constant
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669107#comment-16669107
]
Jason Dere commented on HIVE-20839:
---
Patch to fix the issue by checking for the folded-from column in
[
https://issues.apache.org/jira/browse/HIVE-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669100#comment-16669100
]
Jason Dere commented on HIVE-20839:
---
Issue seems to be that there are several column expressions that
11 matches
Mail list logo