[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-27 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700254#comment-16700254 ] Teddy Choi commented on HIVE-20873: --- Pushed to master. Thanks, [~bslim] and [~gopalv]! > Use Murmur

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-25 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698475#comment-16698475 ] Gopal V commented on HIVE-20873: [~teddy.choi]: this is good to go into Apache - has been tested and

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680922#comment-16680922 ] Hive QA commented on HIVE-20873: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680894#comment-16680894 ] Hive QA commented on HIVE-20873: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678881#comment-16678881 ] Hive QA commented on HIVE-20873: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-08 Thread slim bouguerra (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680050#comment-16680050 ] slim bouguerra commented on HIVE-20873: --- Still unclear to me why are we using Murmur, there is a

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-07 Thread slim bouguerra (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678844#comment-16678844 ] slim bouguerra commented on HIVE-20873: --- [~teddy.choi] Thanks, am not trying by any mean to waste

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-07 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678852#comment-16678852 ] Gopal V commented on HIVE-20873: [~bslim]: Teddy & I have a UDF for the hash function, which we use to

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-07 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678877#comment-16678877 ] Gopal V commented on HIVE-20873: LGTM - +1 tests pending. TestHashCodeUtil.java needs ASF license. >

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-07 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678817#comment-16678817 ] Hive QA commented on HIVE-20873: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-07 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677804#comment-16677804 ] Teddy Choi commented on HIVE-20873: --- In my case, TPC-H query 21 and TPC-DS query 16 seem related with

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-06 Thread slim bouguerra (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677129#comment-16677129 ] slim bouguerra commented on HIVE-20873: --- [~teddy.choi] Am wondering did you get chance to perform

[jira] [Commented] (HIVE-20873) Use Murmur hash for VectorHashKeyWrapperTwoLong to reduce hash collision

2018-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677097#comment-16677097 ] ASF GitHub Bot commented on HIVE-20873: --- GitHub user pudidic opened a pull request: