[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762905#comment-16762905 ] Eugene Koifman commented on HIVE-21177: --- failures not related committed to master thanks Prasanth for the review > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch, > HIVE-21177.03.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762413#comment-16762413 ] Hive QA commented on HIVE-21177: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12957848/HIVE-21177.03.patch {color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 15721 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat.org.apache.hadoop.hive.ql.parse.TestReplWithJsonMessageFormat (batchId=244) org.apache.hive.beeline.hs2connection.TestBeelineWithUserHs2ConnectionFile.testBeelineConnectionNoAuth (batchId=256) org.apache.hive.service.auth.TestLdapAuthenticationProviderImpl.testAuthenticateWithBindInCredentialFilePasses (batchId=232) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15981/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15981/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15981/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12957848 - PreCommit-HIVE-Build > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch, > HIVE-21177.03.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762401#comment-16762401 ] Hive QA commented on HIVE-21177: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 57s{color} | {color:blue} ql in master has 2298 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 47s{color} | {color:red} ql: The patch generated 8 new + 720 unchanged - 5 fixed = 728 total (was 725) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 12s{color} | {color:red} ql generated 1 new + 2297 unchanged - 1 fixed = 2298 total (was 2298) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 28s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | org.apache.hadoop.hive.ql.io.AcidUtils$ParsedDeltaLight defines compareTo(AcidUtils$ParsedDeltaLight) and uses Object.equals() At AcidUtils.java:Object.equals() At AcidUtils.java:[lines 915-943] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15981/dev-support/hive-personality.sh | | git revision | master / 0e4d16b | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15981/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15981/yetus/new-findbugs-ql.html | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-15981/yetus/patch-asflicense-problems.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15981/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch, > HIVE-21177.03.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762302#comment-16762302 ] Eugene Koifman commented on HIVE-21177: --- patch 3 - some more refactoring to use Path rather than FileStatus > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch, > HIVE-21177.03.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762308#comment-16762308 ] Prasanth Jayachandran commented on HIVE-21177: -- lgtm, +1. Pending tests. > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch, > HIVE-21177.03.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756510#comment-16756510 ] Prasanth Jayachandran commented on HIVE-21177: -- Looks like only path is used inside ParsedDeltaLight. So this fs.getFileStatus() call can be avoided? One less fs operation. > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16756350#comment-16756350 ] Eugene Koifman commented on HIVE-21177: --- ParsedDeltaLight pd = ParsedDeltaLight.parse(fs.getFileStatus(baseOrDeltaDir)); {{fs.getFileStatus(baseOrDeltaDir)}} is counted - it wasn't performed before. I removed some of the comments since they were clearly out of date (even before the current patch) > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755782#comment-16755782 ] Prasanth Jayachandran commented on HIVE-21177: -- Any reason why the #readOps jumped for test case testACIDReaderFooterSerializeWithDeltas (for 2 of the asserts)? Would be good to list those 2 new calls in the comment for reference. > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755778#comment-16755778 ] Hive QA commented on HIVE-21177: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12956826/HIVE-21177.02.patch {color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 15720 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfDefault (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfDefaultEmptyString (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfOverridden (batchId=230) org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfUnknownPreperty (batchId=230) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15835/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15835/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15835/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12956826 - PreCommit-HIVE-Build > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755740#comment-16755740 ] Hive QA commented on HIVE-21177: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 41s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 39s{color} | {color:blue} ql in master has 2304 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 43s{color} | {color:red} ql: The patch generated 6 new + 518 unchanged - 5 fixed = 524 total (was 523) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 1s{color} | {color:red} ql generated 1 new + 2303 unchanged - 1 fixed = 2304 total (was 2304) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 36s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | org.apache.hadoop.hive.ql.io.AcidUtils$ParsedDeltaLight defines compareTo(AcidUtils$ParsedDeltaLight) and uses Object.equals() At AcidUtils.java:Object.equals() At AcidUtils.java:[lines 915-943] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15835/dev-support/hive-personality.sh | | git revision | master / dfc4b8e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15835/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15835/yetus/new-findbugs-ql.html | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15835/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755600#comment-16755600 ] Eugene Koifman commented on HIVE-21177: --- fixed tests - all were test issues all TestTriggersTezSessionPoolManager pass locally - not sure what the issue is - there is some Infra issue where https://builds.apache.org/job/PreCommit-HIVE-Build/15828/testReport is blank [~prasanth_j]/[~gopalv] could you review please > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch, HIVE-21177.02.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755528#comment-16755528 ] Hive QA commented on HIVE-21177: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12956802/HIVE-21177.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 15720 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_delimited] (batchId=275) org.apache.hadoop.hive.ql.io.TestAcidUtils.testParsing (batchId=297) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDReaderFooterSerializeWithDeltas (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testACIDReaderNoFooterSerializeWithDeltas (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testSplitGenReadOps (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testSplitGenReadOpsLocalCache (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testSplitGenReadOpsLocalCacheChangeFileLen (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestInputOutputFormat.testSplitGenReadOpsLocalCacheChangeModificationTime (batchId=300) org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testGetLogicalLength (batchId=301) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitions (batchId=264) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitionsUnionAll (batchId=264) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighShuffleBytes (batchId=264) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/15828/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/15828/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-15828/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12956802 - PreCommit-HIVE-Build > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21177) Optimize AcidUtils.getLogicalLength()
[ https://issues.apache.org/jira/browse/HIVE-21177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755496#comment-16755496 ] Hive QA commented on HIVE-21177: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 42s{color} | {color:blue} ql in master has 2304 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 38s{color} | {color:red} ql: The patch generated 5 new + 174 unchanged - 4 fixed = 179 total (was 178) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 57s{color} | {color:red} ql generated 1 new + 2303 unchanged - 1 fixed = 2304 total (was 2304) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 41s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | org.apache.hadoop.hive.ql.io.AcidUtils$ParsedDeltaLight defines compareTo(AcidUtils$ParsedDeltaLight) and uses Object.equals() At AcidUtils.java:Object.equals() At AcidUtils.java:[lines 915-943] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-15828/dev-support/hive-personality.sh | | git revision | master / dfc4b8e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-15828/yetus/diff-checkstyle-ql.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-15828/yetus/new-findbugs-ql.html | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-15828/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Optimize AcidUtils.getLogicalLength() > - > > Key: HIVE-21177 > URL: https://issues.apache.org/jira/browse/HIVE-21177 > Project: Hive > Issue Type: Bug > Components: Transactions >Affects Versions: 3.0.0 >Reporter: Eugene Koifman >Assignee: Eugene Koifman >Priority: Major > Attachments: HIVE-21177.01.patch > > > {{AcidUtils.getLogicalLength()}} - tries look for the side file > {{OrcAcidUtils.getSideFile()}} on the file system even when the file couldn't > possibly be there, e.g. when the path is delta_x_x or base_x. It could only > be there in delta_x_y, x != y. -- This message was sent by Atlassian JIRA (v7.6.3#76005)