[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-03-04 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784015#comment-16784015 ] Rajesh Balamohan commented on HIVE-21312: - Thanks [~kgyrtkirk], [~gopalv].   Committed to

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-03-04 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783163#comment-16783163 ] Zoltan Haindrich commented on HIVE-21312: - +1 > FSStatsAggregator::connect is slow >

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-03-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782918#comment-16782918 ] Hive QA commented on HIVE-21312: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-03-03 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782913#comment-16782913 ] Hive QA commented on HIVE-21312: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-03-01 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781555#comment-16781555 ] Hive QA commented on HIVE-21312: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-03-01 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781531#comment-16781531 ] Hive QA commented on HIVE-21312: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-28 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781388#comment-16781388 ] Zoltan Haindrich commented on HIVE-21312: - with this declaration {code} private Queue>>

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-28 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781209#comment-16781209 ] Rajesh Balamohan commented on HIVE-21312: - - Made the fix to retain old behavior of returning

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781194#comment-16781194 ] Hive QA commented on HIVE-21312: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781154#comment-16781154 ] Hive QA commented on HIVE-21312: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-28 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780724#comment-16780724 ] Zoltan Haindrich commented on HIVE-21312: - {quote} is intentional and hence returning null.

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-28 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780555#comment-16780555 ] Rajesh Balamohan commented on HIVE-21312: - Thanks for the review [~kgyrtkirk]. Attaching the

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-28 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780241#comment-16780241 ] Zoltan Haindrich commented on HIVE-21312: - it looks good so far, I've collected some notes: *

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-27 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780047#comment-16780047 ] Rajesh Balamohan commented on HIVE-21312: - Kryo readObject classtype was missing earlier causing

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779720#comment-16779720 ] Hive QA commented on HIVE-21312: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-27 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779677#comment-16779677 ] Hive QA commented on HIVE-21312: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-26 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778755#comment-16778755 ] Rajesh Balamohan commented on HIVE-21312: - Sure. I will look into this today. >

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-26 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777824#comment-16777824 ] Zoltan Haindrich commented on HIVE-21312: - It seems like the patch broke 2037 tests - from a

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-26 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777816#comment-16777816 ] Rajesh Balamohan commented on HIVE-21312: - Thanks for creating

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-26 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1657#comment-1657 ] Zoltan Haindrich commented on HIVE-21312: - [~rajesh.balamohan]: we definetly need this ticket -

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-26 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1652#comment-1652 ] Rajesh Balamohan commented on HIVE-21312: - [~kgyrtkirk]: Also, patch would would help with other

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-26 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1632#comment-1632 ] Gopal V commented on HIVE-21312:

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-26 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1629#comment-1629 ] Zoltan Haindrich commented on HIVE-21312: - [~gopalv]: very interesting; I didn't know that -

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-25 Thread Gopal V (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777108#comment-16777108 ] Gopal V commented on HIVE-21312: bq. use Tez counters to haul this data. That was what used to exist

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-24 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776465#comment-16776465 ] Hive QA commented on HIVE-21312: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-24 Thread Rajesh Balamohan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776457#comment-16776457 ] Rajesh Balamohan commented on HIVE-21312: - Thanks [~kgyrtkirk]. I have made it as threadsafe

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-24 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776271#comment-16776271 ] Hive QA commented on HIVE-21312: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-21312) FSStatsAggregator::connect is slow

2019-02-24 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776255#comment-16776255 ] Zoltan Haindrich commented on HIVE-21312: - is {{statsList.add(stats)}} threadsafe? I think its a