[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[ https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783777#comment-16783777 ] Jason Dere commented on HIVE-21362: --- +1 > Add an input format and serde to read from protobuf files. > -- > > Key: HIVE-21362 > URL: https://issues.apache.org/jira/browse/HIVE-21362 > Project: Hive > Issue Type: Task > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Critical > Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch, > HIVE-21362.03.patch, HIVE-21362.04.patch, HIVE-21362.05.patch > > > Logs are being generated using the HiveProtoLoggingHook and tez > ProtoHistoryLoggingService. These are sequence files written using > ProtobufMessageWritable. > Implement a SerDe and input format to be able to create tables using these > files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[ https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783184#comment-16783184 ] Harish Jaiprakash commented on HIVE-21362: -- Test failures not related, it has cleared once earlier. Only fixes were for codestyle errors after that. 'whitespace' errors are in generated file. Not sure how to exclude that. > Add an input format and serde to read from protobuf files. > -- > > Key: HIVE-21362 > URL: https://issues.apache.org/jira/browse/HIVE-21362 > Project: Hive > Issue Type: Task > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Critical > Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch, > HIVE-21362.03.patch, HIVE-21362.04.patch, HIVE-21362.05.patch > > > Logs are being generated using the HiveProtoLoggingHook and tez > ProtoHistoryLoggingService. These are sequence files written using > ProtobufMessageWritable. > Implement a SerDe and input format to be able to create tables using these > files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783132#comment-16783132
]
Hive QA commented on HIVE-21362:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960957/HIVE-21362.05.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15823 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16322/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16322/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16322/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12960957 - PreCommit-HIVE-Build
> Add an input format and serde to read from protobuf files.
> --
>
> Key: HIVE-21362
> URL: https://issues.apache.org/jira/browse/HIVE-21362
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
>Reporter: Harish Jaiprakash
>Assignee: Harish Jaiprakash
>Priority: Critical
> Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch,
> HIVE-21362.03.patch, HIVE-21362.04.patch, HIVE-21362.05.patch
>
>
> Logs are being generated using the HiveProtoLoggingHook and tez
> ProtoHistoryLoggingService. These are sequence files written using
> ProtobufMessageWritable.
> Implement a SerDe and input format to be able to create tables using these
> files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783096#comment-16783096
]
Hive QA commented on HIVE-21362:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
21s{color} | {color:blue} standalone-metastore/metastore-server in master has
179 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
27s{color} | {color:blue} contrib in master has 10 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
49s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 15
unchanged - 0 fixed = 16 total (was 15) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch has 32 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16322/dev-support/hive-personality.sh
|
| git revision | master / f51f108 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16322/yetus/diff-checkstyle-itests_hive-unit.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16322/yetus/whitespace-eol.txt
|
| modules | C: standalone-metastore/metastore-server contrib itests/hive-unit
U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16322/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add an input format and serde to read from protobuf files.
> --
>
> Key: HIVE-21362
> URL: https://issues.apache.org/jira/browse/HIVE-21362
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
>Reporter: Harish Jaiprakash
>Assignee: Harish Jaiprakash
>Priority: Critical
> Attachments: HIVE-21362.01.patch,
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783004#comment-16783004
]
Hive QA commented on HIVE-21362:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960945/HIVE-21362.04.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 15808 tests
executed
*Failed tests:*
{noformat}
TestMiniLlapCliDriver - did not produce a TEST-*.xml file (likely timed out)
(batchId=155)
[intersect_all.q,unionDistinct_1.q,table_nonprintable.q,orc_llap_counters1.q,mm_cttas.q,whroot_external1.q,global_limit.q,cte_2.q,rcfile_createas1.q,dynamic_partition_pruning_2.q,intersect_merge.q,results_cache_diff_fs.q,cttl.q,parallel_colstats.q,load_hdfs_file_with_space_in_the_name.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz_2]
(batchId=86)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16321/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16321/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16321/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12960945 - PreCommit-HIVE-Build
> Add an input format and serde to read from protobuf files.
> --
>
> Key: HIVE-21362
> URL: https://issues.apache.org/jira/browse/HIVE-21362
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
>Reporter: Harish Jaiprakash
>Assignee: Harish Jaiprakash
>Priority: Critical
> Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch,
> HIVE-21362.03.patch, HIVE-21362.04.patch
>
>
> Logs are being generated using the HiveProtoLoggingHook and tez
> ProtoHistoryLoggingService. These are sequence files written using
> ProtobufMessageWritable.
> Implement a SerDe and input format to be able to create tables using these
> files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782985#comment-16782985
]
Hive QA commented on HIVE-21362:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
20s{color} | {color:blue} standalone-metastore/metastore-server in master has
179 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
27s{color} | {color:blue} contrib in master has 10 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
50s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} contrib: The patch generated 4 new + 0 unchanged - 0
fixed = 4 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
18s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 15
unchanged - 0 fixed = 16 total (was 15) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch has 32 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16321/dev-support/hive-personality.sh
|
| git revision | master / f51f108 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16321/yetus/diff-checkstyle-contrib.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16321/yetus/diff-checkstyle-itests_hive-unit.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16321/yetus/whitespace-eol.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16321/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore/metastore-server contrib itests/hive-unit
U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16321/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add an input format and serde to read from protobuf files.
>
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782962#comment-16782962
]
Hive QA commented on HIVE-21362:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960944/HIVE-21362.03.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16320/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16320/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16320/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-03-04 04:53:22.070
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-16320/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-03-04 04:53:22.073
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at f51f108 HIVE-21255: Remove QueryConditionBuilder in
JdbcStorageHandler (Daniel Dai, reviewed by Jesus Camacho Rodriguez)
+ git clean -f -d
Removing ${project.basedir}/
Removing itests/${project.basedir}/
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at f51f108 HIVE-21255: Remove QueryConditionBuilder in
JdbcStorageHandler (Daniel Dai, reviewed by Jesus Camacho Rodriguez)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-03-04 04:53:23.284
+ rm -rf ../yetus_PreCommit-HIVE-Build-16320
+ mkdir ../yetus_PreCommit-HIVE-Build-16320
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-16320
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-16320/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: a/contrib/pom.xml: does not exist in index
error:
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/package-info.java:
does not exist in index
Going to apply patch with: git apply -p1
/data/hiveptest/working/scratch/build.patch:246: trailing whitespace.
com.google.protobuf.ByteString bs =
/data/hiveptest/working/scratch/build.patch:262: trailing whitespace.
com.google.protobuf.ByteString b =
/data/hiveptest/working/scratch/build.patch:289: trailing whitespace.
com.google.protobuf.ByteString bs =
/data/hiveptest/working/scratch/build.patch:305: trailing whitespace.
com.google.protobuf.ByteString b =
/data/hiveptest/working/scratch/build.patch:592: trailing whitespace.
com.google.protobuf.ByteString b =
warning: squelched 27 whitespace errors
warning: 32 lines add whitespace errors.
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc7737364458282723599.exe, --version]
libprotoc 2.5.0
protoc-jar: executing: [/tmp/protoc7737364458282723599.exe,
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore,
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources,
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator Version 3.5.2
protoc-jar: executing: [/tmp/protoc7905016354169601518.exe, --version]
libprotoc 2.5.0
ANTLR Parser Generator Version 3.5.2
Output file
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[ https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782953#comment-16782953 ] Harish Jaiprakash commented on HIVE-21362: -- Rename file name from TestProtos to SampleProtos since the generated file was being considered as a Test. > Add an input format and serde to read from protobuf files. > -- > > Key: HIVE-21362 > URL: https://issues.apache.org/jira/browse/HIVE-21362 > Project: Hive > Issue Type: Task > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Critical > Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch, > HIVE-21362.03.patch > > > Logs are being generated using the HiveProtoLoggingHook and tez > ProtoHistoryLoggingService. These are sequence files written using > ProtobufMessageWritable. > Implement a SerDe and input format to be able to create tables using these > files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[ https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782929#comment-16782929 ] Harish Jaiprakash commented on HIVE-21362: -- I'm getting 404 while trying to access checkstyle errors. The whitespace errors and asflicense missing are from the generated file. How do I exclude generated file from these checks? Or should I fix the generated file? > Add an input format and serde to read from protobuf files. > -- > > Key: HIVE-21362 > URL: https://issues.apache.org/jira/browse/HIVE-21362 > Project: Hive > Issue Type: Task > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Critical > Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch > > > Logs are being generated using the HiveProtoLoggingHook and tez > ProtoHistoryLoggingService. These are sequence files written using > ProtobufMessageWritable. > Implement a SerDe and input format to be able to create tables using these > files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782321#comment-16782321
]
Hive QA commented on HIVE-21362:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960861/HIVE-21362.02.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15823 tests
executed
*Failed tests:*
{noformat}
TestProtos - did not produce a TEST-*.xml file (likely timed out) (batchId=196)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16317/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16317/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16317/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12960861 - PreCommit-HIVE-Build
> Add an input format and serde to read from protobuf files.
> --
>
> Key: HIVE-21362
> URL: https://issues.apache.org/jira/browse/HIVE-21362
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
>Reporter: Harish Jaiprakash
>Assignee: Harish Jaiprakash
>Priority: Critical
> Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch
>
>
> Logs are being generated using the HiveProtoLoggingHook and tez
> ProtoHistoryLoggingService. These are sequence files written using
> ProtobufMessageWritable.
> Implement a SerDe and input format to be able to create tables using these
> files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782313#comment-16782313
]
Hive QA commented on HIVE-21362:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
58s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
21s{color} | {color:blue} standalone-metastore/metastore-server in master has
179 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
27s{color} | {color:blue} contrib in master has 10 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
48s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} contrib: The patch generated 4 new + 0 unchanged - 0
fixed = 4 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 15
unchanged - 0 fixed = 16 total (was 15) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 32 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16317/dev-support/hive-personality.sh
|
| git revision | master / f51f108 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16317/yetus/diff-checkstyle-contrib.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16317/yetus/diff-checkstyle-itests_hive-unit.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16317/yetus/whitespace-eol.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16317/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore/metastore-server contrib itests/hive-unit
U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16317/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add an input format and serde to read from protobuf files.
>
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[ https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782302#comment-16782302 ] Harish Jaiprakash commented on HIVE-21362: -- * Fixing code review comments. * Fixing checkstyle warnings. * Added another implementation to load protobuf from BytesWritable. > Add an input format and serde to read from protobuf files. > -- > > Key: HIVE-21362 > URL: https://issues.apache.org/jira/browse/HIVE-21362 > Project: Hive > Issue Type: Task > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Critical > Attachments: HIVE-21362.01.patch, HIVE-21362.02.patch > > > Logs are being generated using the HiveProtoLoggingHook and tez > ProtoHistoryLoggingService. These are sequence files written using > ProtobufMessageWritable. > Implement a SerDe and input format to be able to create tables using these > files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781268#comment-16781268
]
Hive QA commented on HIVE-21362:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960642/HIVE-21362.01.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 15 failed/errored test(s), 15828 tests
executed
*Failed tests:*
{noformat}
TestProtos - did not produce a TEST-*.xml file (likely timed out) (batchId=196)
org.apache.hadoop.hive.metastore.TestObjectStore.catalogs (batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testDatabaseOps (batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testDeprecatedConfigIsOverwritten
(batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropParitionsCleanup
(batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropPartitionsCacheCrossSession
(batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSqlErrorMetrics
(batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testEmptyTrustStoreProps
(batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testMasterKeyOps (batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testMaxEventResponse
(batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testPartitionOps (batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testQueryCloseOnError
(batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testRoleOps (batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testTableOps (batchId=230)
org.apache.hadoop.hive.metastore.TestObjectStore.testUseSSLProperty
(batchId=230)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16302/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16302/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16302/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 15 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12960642 - PreCommit-HIVE-Build
> Add an input format and serde to read from protobuf files.
> --
>
> Key: HIVE-21362
> URL: https://issues.apache.org/jira/browse/HIVE-21362
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
>Reporter: Harish Jaiprakash
>Assignee: Harish Jaiprakash
>Priority: Critical
> Attachments: HIVE-21362.01.patch
>
>
> Logs are being generated using the HiveProtoLoggingHook and tez
> ProtoHistoryLoggingService. These are sequence files written using
> ProtobufMessageWritable.
> Implement a SerDe and input format to be able to create tables using these
> files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781246#comment-16781246
]
Hive QA commented on HIVE-21362:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
3s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m
23s{color} | {color:blue} standalone-metastore/metastore-server in master has
179 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
26s{color} | {color:blue} contrib in master has 10 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
51s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} contrib: The patch generated 49 new + 0 unchanged - 0
fixed = 49 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
20s{color} | {color:red} itests/hive-unit: The patch generated 1 new + 15
unchanged - 0 fixed = 16 total (was 15) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 32 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16302/dev-support/hive-personality.sh
|
| git revision | master / 6831b08 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16302/yetus/diff-checkstyle-contrib.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16302/yetus/diff-checkstyle-itests_hive-unit.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16302/yetus/whitespace-eol.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16302/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore/metastore-server contrib itests/hive-unit
U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16302/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Add an input format and serde to read from protobuf files.
>
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[
https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781212#comment-16781212
]
Harish Jaiprakash commented on HIVE-21362:
--
Thanks, [~jdere].
{noformat}
Is there a RB for this somewhere?
{noformat}
Created one forgot to link: https://reviews.apache.org/r/70075
{noformat}
Does ProtoMessageSerDe.createStructObjectInspector() need to handle repeated
struct fields like createObjectInspector() does?
{noformat}
It does, createStructObjectInspector calls createObjectInspector which in turn
calls createStructObjectInspect for struct types.
{noformat}
Also createObjectInspector() has a call to System.out.println(), please remove
that or convert to debug logging.
{noformat}
Will remove this, was debugging code.
{noformat}
I don't quite get the proto.maptypes property - is this just some special
condition due to the data format you are trying to read, or is this the only
way to specify that a field is of Map type? If the latter, doesn't the
descriptor have a way to specify a map type?
{noformat}
Proto 2 compiler does not support map types. This is a way to configure
conversion of repeated struct(key, value) into map. That makes it
easier to process in hive too, no explode followed by a filter is required for
this and easier to extract several values from the map without joins.
> Add an input format and serde to read from protobuf files.
> --
>
> Key: HIVE-21362
> URL: https://issues.apache.org/jira/browse/HIVE-21362
> Project: Hive
> Issue Type: Task
> Components: HiveServer2
>Reporter: Harish Jaiprakash
>Assignee: Harish Jaiprakash
>Priority: Critical
> Attachments: HIVE-21362.01.patch
>
>
> Logs are being generated using the HiveProtoLoggingHook and tez
> ProtoHistoryLoggingService. These are sequence files written using
> ProtobufMessageWritable.
> Implement a SerDe and input format to be able to create tables using these
> files.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21362) Add an input format and serde to read from protobuf files.
[ https://issues.apache.org/jira/browse/HIVE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780832#comment-16780832 ] Jason Dere commented on HIVE-21362: --- Is there a RB for this somewhere? Does ProtoMessageSerDe.createStructObjectInspector() need to handle repeated struct fields like createObjectInspector() does? Also createObjectInspector() has a call to System.out.println(), please remove that or convert to debug logging. I don't quite get the proto.maptypes property - is this just some special condition due to the data format you are trying to read, or is this the only way to specify that a field is of Map type? If the latter, doesn't the descriptor have a way to specify a map type? > Add an input format and serde to read from protobuf files. > -- > > Key: HIVE-21362 > URL: https://issues.apache.org/jira/browse/HIVE-21362 > Project: Hive > Issue Type: Task > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Critical > Attachments: HIVE-21362.01.patch > > > Logs are being generated using the HiveProtoLoggingHook and tez > ProtoHistoryLoggingService. These are sequence files written using > ProtobufMessageWritable. > Implement a SerDe and input format to be able to create tables using these > files. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
