[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-15 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793983#comment-16793983 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-15 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793952#comment-16793952 ] Hive QA commented on HIVE-21382: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793372#comment-16793372 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793344#comment-16793344 ] Hive QA commented on HIVE-21382: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-14 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792997#comment-16792997 ] Vineet Garg commented on HIVE-21382: Thanks for reviewing [~jcamachorodriguez]. I hav

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-14 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792827#comment-16792827 ] Jesus Camacho Rodriguez commented on HIVE-21382: Left a minor comment on

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792599#comment-16792599 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792566#comment-16792566 ] Hive QA commented on HIVE-21382: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-12 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791025#comment-16791025 ] Vineet Garg commented on HIVE-21382: [~jcamachorodriguez] Can you take a look:  https

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-12 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790288#comment-16790288 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-11 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790265#comment-16790265 ] Hive QA commented on HIVE-21382: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-11 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790224#comment-16790224 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787709#comment-16787709 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787706#comment-16787706 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787678#comment-16787678 ] Hive QA commented on HIVE-21382: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786050#comment-16786050 ] Hive QA commented on HIVE-21382: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785996#comment-16785996 ] Hive QA commented on HIVE-21382: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-05 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785156#comment-16785156 ] Vineet Garg commented on HIVE-21382: This patch also fixes HIVE-21387 > Group by key

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-05 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785155#comment-16785155 ] Vineet Garg commented on HIVE-21382: Challenge with query23 is that group by has expr

[jira] [Commented] (HIVE-21382) Group by keys reduction optimization - keys are not reduced in query23

2019-03-04 Thread Vineet Garg (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783947#comment-16783947 ] Vineet Garg commented on HIVE-21382: Current logic of Group by reduction only works i