[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794026#comment-16794026 ] Ashutosh Chauhan commented on HIVE-21385: - +1 > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.01.patch, > HIVE-21385.02.patch, HIVE-21385.02.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793319#comment-16793319 ] Hive QA commented on HIVE-21385: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12962511/HIVE-21385.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15828 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16519/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16519/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16519/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12962511 - PreCommit-HIVE-Build > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.01.patch, > HIVE-21385.02.patch, HIVE-21385.02.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793311#comment-16793311 ] Hive QA commented on HIVE-21385: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 53s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 36s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 13s{color} | {color:blue} ql in master has 2257 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 16s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} The patch common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} ql: The patch generated 0 new + 168 unchanged - 3 fixed = 168 total (was 171) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 14s{color} | {color:red} The patch generated 2 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 30m 33s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16519/dev-support/hive-personality.sh | | git revision | master / 3f02ce4 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-16519/yetus/patch-asflicense-problems.txt | | modules | C: common ql itests U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16519/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.01.patch, > HIVE-21385.02.patch, HIVE-21385.02.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787444#comment-16787444 ] Hive QA commented on HIVE-21385: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12961608/HIVE-21385.01.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16397/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16397/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16397/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-03-08 02:00:47.239 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-16397/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-03-08 02:00:47.242 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at bd95a2f HIVE-21376: Incompatible change in Hive bucket computation (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan) + git clean -f -d Removing ${project.basedir}/ Removing itests/${project.basedir}/ Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at bd95a2f HIVE-21376: Incompatible change in Hive bucket computation (Jesus Camacho Rodriguez, reviewed by Ashutosh Chauhan) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-03-08 02:00:49.384 + rm -rf ../yetus_PreCommit-HIVE-Build-16397 + mkdir ../yetus_PreCommit-HIVE-Build-16397 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-16397 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-16397/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java: does not exist in index error: a/itests/src/test/resources/testconfiguration.properties: does not exist in index error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java: does not exist in index Going to apply patch with: git apply -p1 /data/hiveptest/working/scratch/build.patch:393: trailing whitespace. Map 1 /data/hiveptest/working/scratch/build.patch:417: trailing whitespace. Map 3 /data/hiveptest/working/scratch/build.patch:441: trailing whitespace. Reducer 2 /data/hiveptest/working/scratch/build.patch:505: trailing whitespace. Map 1 /data/hiveptest/working/scratch/build.patch:523: trailing whitespace. Map 3 warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven protoc-jar: executing: [/tmp/protoc4467477092565910603.exe, --version] libprotoc 2.5.0 protoc-jar: executing: [/tmp/protoc4467477092565910603.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore, --java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources, /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto] ANTLR Parser Generator Version 3.5.2 protoc-jar: executing: [/tmp/protoc2606360822513530397.exe, --version] libprotoc 2.5.0 ANTLR Parser Generator Version 3.5.2 Output file
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787278#comment-16787278 ] Daniel Dai commented on HIVE-21385: --- Discussed offline, I am fine to use a on/off button, with a vague name suggest this is just a workaround to push less computation to jdbc. Maybe "hive.jdbc.pushdown.safe"? > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.01.patch, > HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787098#comment-16787098 ] Jesus Camacho Rodriguez commented on HIVE-21385: [~daijy], we do not want to go into that direction making per operator rules configurable. I believe an on/off button is easier to understand and will not create any false expectations, e.g., that anything in that list will actually be pushed. Cc [~ashutoshc] > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.01.patch, > HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786031#comment-16786031 ] Daniel Dai commented on HIVE-21385: --- How about make a list config parameter? By default, we can put join/union/aggregation/sort, but user can remove anything he don't want to pushdown. > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785857#comment-16785857 ] Jesus Camacho Rodriguez commented on HIVE-21385: Maybe in addition to having these two global variables, it can make sense to being able to enable/disable them on a per-table basis setting it in the table properties. What do you think? I can create a follow-up for that. > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785855#comment-16785855 ] Jesus Camacho Rodriguez commented on HIVE-21385: I would say it depends. For instance, Aggregate may not increase data size, but it may not reduce it much, and we would prevent reading in parallel using JDBC. The advantage of keeping those operators in the Hive plan is that we can read in parallel and compute aggregation/sort/union using Hive parallel operators too. For the time being, I believe disabling pushdown completely (already there) and disabling operators that may prevent reading in parallel gives the user enough flexibility. > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785264#comment-16785264 ] Daniel Dai commented on HIVE-21385: --- I think we do want to disable join as it will explode data exponentially. However, aggregation/sort/union might be ok. How do you think? > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785199#comment-16785199 ] Hive QA commented on HIVE-21385: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12961190/HIVE-21385.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15818 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testSingleSourceMultipleFiltersOrdering1 (batchId=319) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16353/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16353/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16353/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12961190 - PreCommit-HIVE-Build > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785184#comment-16785184 ] Hive QA commented on HIVE-21385: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 4s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 44s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 35s{color} | {color:blue} ql in master has 2251 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} The patch common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s{color} | {color:green} ql: The patch generated 0 new + 168 unchanged - 3 fixed = 168 total (was 171) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 34m 8s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16353/dev-support/hive-personality.sh | | git revision | master / 9dc28db | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: common ql itests U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16353/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.01.patch, HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784196#comment-16784196 ] Hive QA commented on HIVE-21385: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12961078/HIVE-21385.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15818 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniDruidKafkaCliDriver.testCliDriver[druidkafkamini_basic] (batchId=275) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16337/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16337/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16337/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12961078 - PreCommit-HIVE-Build > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784181#comment-16784181 ] Hive QA commented on HIVE-21385: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 56s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 38s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 30s{color} | {color:blue} ql in master has 2251 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 23s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} The patch common passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 46s{color} | {color:green} ql: The patch generated 0 new + 168 unchanged - 3 fixed = 168 total (was 171) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 32m 0s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16337/dev-support/hive-personality.sh | | git revision | master / fc3eefa | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: common ql itests U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16337/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21385) Allow disabling pushdown of non-splittable computation to JDBC sources
[ https://issues.apache.org/jira/browse/HIVE-21385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783939#comment-16783939 ] Jesus Camacho Rodriguez commented on HIVE-21385: [~daijy], could you take a look? Thanks > Allow disabling pushdown of non-splittable computation to JDBC sources > -- > > Key: HIVE-21385 > URL: https://issues.apache.org/jira/browse/HIVE-21385 > Project: Hive > Issue Type: Improvement > Components: CBO, StorageHandler >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-21385.patch > > > Until pushdown is cost-based decision, we will be able to enable / disable > pushdown of operators that prevent reading results from the JDBC connection > in parallel. -- This message was sent by Atlassian JIRA (v7.6.3#76005)