[jira] [Commented] (HIVE-21526) JSONDropDatabaseMessage needs to have the full database object.

2019-03-28 Thread Vihang Karajgaonkar (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804250#comment-16804250
 ] 

Vihang Karajgaonkar commented on HIVE-21526:


Looks good to me. +1

> JSONDropDatabaseMessage needs to have the full database object.
> ---
>
> Key: HIVE-21526
> URL: https://issues.apache.org/jira/browse/HIVE-21526
> Project: Hive
>  Issue Type: Improvement
>Reporter: Bharathkrishna Guruvayoor Murali
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
> Attachments: HIVE-21526.1.patch
>
>
> The metastore notification event DROP_DATABASE does not provide full-thrift 
> objects as of now.
> We have added CREATION_TIME to databases in HIVE-21077, and metadata like 
> this would be useful in notification processing. One of the use-cases is 
> IMPALA-8338.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21526) JSONDropDatabaseMessage needs to have the full database object.

2019-03-28 Thread Bharathkrishna Guruvayoor Murali (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804191#comment-16804191
 ] 

Bharathkrishna Guruvayoor Murali commented on HIVE-21526:
-

Tests are passing. I guess the checkstyle error reported can be ignored. ASF 
License errors are unrelated.
[~vihangk1] can you take a final look?

> JSONDropDatabaseMessage needs to have the full database object.
> ---
>
> Key: HIVE-21526
> URL: https://issues.apache.org/jira/browse/HIVE-21526
> Project: Hive
>  Issue Type: Improvement
>Reporter: Bharathkrishna Guruvayoor Murali
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
> Attachments: HIVE-21526.1.patch
>
>
> The metastore notification event DROP_DATABASE does not provide full-thrift 
> objects as of now.
> We have added CREATION_TIME to databases in HIVE-21077, and metadata like 
> this would be useful in notification processing. One of the use-cases is 
> IMPALA-8338.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21526) JSONDropDatabaseMessage needs to have the full database object.

2019-03-27 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803596#comment-16803596
 ] 

Hive QA commented on HIVE-21526:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12963923/HIVE-21526.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15876 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/16724/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16724/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16724/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12963923 - PreCommit-HIVE-Build

> JSONDropDatabaseMessage needs to have the full database object.
> ---
>
> Key: HIVE-21526
> URL: https://issues.apache.org/jira/browse/HIVE-21526
> Project: Hive
>  Issue Type: Improvement
>Reporter: Bharathkrishna Guruvayoor Murali
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
> Attachments: HIVE-21526.1.patch
>
>
> The metastore notification event DROP_DATABASE does not provide full-thrift 
> objects as of now.
> We have added CREATION_TIME to databases in HIVE-21077, and metadata like 
> this would be useful in notification processing. One of the use-cases is 
> IMPALA-8338.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21526) JSONDropDatabaseMessage needs to have the full database object.

2019-03-27 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803576#comment-16803576
 ] 

Hive QA commented on HIVE-21526:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
49s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
19s{color} | {color:blue} standalone-metastore/metastore-server in master has 
179 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
18s{color} | {color:red} standalone-metastore/metastore-server: The patch 
generated 4 new + 15 unchanged - 3 fixed = 19 total (was 18) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
15s{color} | {color:red} The patch generated 7 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m  5s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16724/dev-support/hive-personality.sh
 |
| git revision | master / ddb0f4f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-16724/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
 |
| asflicense | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-16724/yetus/patch-asflicense-problems.txt
 |
| modules | C: standalone-metastore/metastore-server itests/hcatalog-unit U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-16724/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> JSONDropDatabaseMessage needs to have the full database object.
> ---
>
> Key: HIVE-21526
> URL: https://issues.apache.org/jira/browse/HIVE-21526
> Project: Hive
>  Issue Type: Improvement
>Reporter: Bharathkrishna Guruvayoor Murali
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
> Attachments: HIVE-21526.1.patch
>
>
> The metastore notification event DROP_DATABASE does not provide full-thrift 
> objects as of now.
> We have added CREATION_TIME to databases in HIVE-21077, and metadata like 
> this would be useful in notification processing. One of the use-cases is 
> IMPALA-8338.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21526) JSONDropDatabaseMessage needs to have the full database object.

2019-03-27 Thread Vihang Karajgaonkar (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803181#comment-16803181
 ] 

Vihang Karajgaonkar commented on HIVE-21526:


Patch looks good to me. +1 (pending tests)

> JSONDropDatabaseMessage needs to have the full database object.
> ---
>
> Key: HIVE-21526
> URL: https://issues.apache.org/jira/browse/HIVE-21526
> Project: Hive
>  Issue Type: Improvement
>Reporter: Bharathkrishna Guruvayoor Murali
>Assignee: Bharathkrishna Guruvayoor Murali
>Priority: Major
> Attachments: HIVE-21526.1.patch
>
>
> The metastore notification event DROP_DATABASE does not provide full-thrift 
> objects as of now.
> We have added CREATION_TIME to databases in HIVE-21077, and metadata like 
> this would be useful in notification processing. One of the use-cases is 
> IMPALA-8338.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)