[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-07-08 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880790#comment-16880790 ] Owen O'Malley commented on HIVE-21848: -- [~sha...@uber.com], I think the appropriate response is to

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-28 Thread Xinli Shang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875247#comment-16875247 ] Xinli Shang commented on HIVE-21848: Hi [~owen.omalley], yes, I looked at the HadoopShims.java

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-24 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871852#comment-16871852 ] Owen O'Malley commented on HIVE-21848: -- You might also want to look at the ORC KeyProvider API since

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-24 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871532#comment-16871532 ] Owen O'Malley commented on HIVE-21848: -- For ORC, given a structure like: {code} table Customers (

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-24 Thread Gidon Gershinsky (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871510#comment-16871510 ] Gidon Gershinsky commented on HIVE-21848: - I'm also fine with this variant. Since key ids can be

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-24 Thread Xinli Shang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871480#comment-16871480 ] Xinli Shang commented on HIVE-21848: I am OK with this variant of #2 overall. The only

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-24 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871405#comment-16871405 ] Owen O'Malley commented on HIVE-21848: -- How about a variant of #2 that looks like:

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-19 Thread Gidon Gershinsky (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868263#comment-16868263 ] Gidon Gershinsky commented on HIVE-21848: - Yep, agreed, this seems to be the minimum common set.

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-19 Thread Xinli Shang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867960#comment-16867960 ] Xinli Shang commented on HIVE-21848: [~gershinsky], thanks for sharing out the timing concern. How

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-19 Thread Gidon Gershinsky (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867785#comment-16867785 ] Gidon Gershinsky commented on HIVE-21848: - [~sha...@uber.com], a few comments: * for either

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-19 Thread Xinli Shang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867767#comment-16867767 ] Xinli Shang commented on HIVE-21848: Thanks Owen! I Just have a slight different thinking for

[jira] [Commented] (HIVE-21848) Table property name definition between ORC and Parquet encrytion

2019-06-17 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-21848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866205#comment-16866205 ] Owen O'Malley commented on HIVE-21848: -- These are the user facing properties, so we should make them