[jira] [Commented] (HIVE-22219) Bringing a node manager down blocks restart of LLAP service
[
https://issues.apache.org/jira/browse/HIVE-22219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935025#comment-16935025
]
Hive QA commented on HIVE-22219:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12980947/HIVE-22219.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 16833 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18679/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18679/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18679/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12980947 - PreCommit-HIVE-Build
> Bringing a node manager down blocks restart of LLAP service
> ---
>
> Key: HIVE-22219
> URL: https://issues.apache.org/jira/browse/HIVE-22219
> Project: Hive
> Issue Type: Bug
> Components: llap
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-22219.patch, HIVE-22219.patch
>
>
> For YARN service, when number of running instances != number of desired
> instances, the service state may be in STARTED or FLEX (instead of STABLE).
> For Hive LLAP side, there is a config to control the threshold of service
> health check. The Hive LLAP code misses checking these states, which can
> result in the service not coming up even if the threshold is met.
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java#L382
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22219) Bringing a node manager down blocks restart of LLAP service
[
https://issues.apache.org/jira/browse/HIVE-22219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935000#comment-16935000
]
Hive QA commented on HIVE-22219:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
43s{color} | {color:blue} llap-server in master has 90 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18679/dev-support/hive-personality.sh
|
| git revision | master / 8b571ea |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: llap-server U: llap-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18679/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Bringing a node manager down blocks restart of LLAP service
> ---
>
> Key: HIVE-22219
> URL: https://issues.apache.org/jira/browse/HIVE-22219
> Project: Hive
> Issue Type: Bug
> Components: llap
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-22219.patch, HIVE-22219.patch
>
>
> For YARN service, when number of running instances != number of desired
> instances, the service state may be in STARTED or FLEX (instead of STABLE).
> For Hive LLAP side, there is a config to control the threshold of service
> health check. The Hive LLAP code misses checking these states, which can
> result in the service not coming up even if the threshold is met.
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java#L382
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22219) Bringing a node manager down blocks restart of LLAP service
[
https://issues.apache.org/jira/browse/HIVE-22219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934734#comment-16934734
]
Hive QA commented on HIVE-22219:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12980840/HIVE-22219.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16801 tests
executed
*Failed tests:*
{noformat}
TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed
out) (batchId=233)
TestObjectStore - did not produce a TEST-*.xml file (likely timed out)
(batchId=233)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18666/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18666/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18666/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12980840 - PreCommit-HIVE-Build
> Bringing a node manager down blocks restart of LLAP service
> ---
>
> Key: HIVE-22219
> URL: https://issues.apache.org/jira/browse/HIVE-22219
> Project: Hive
> Issue Type: Bug
> Components: llap
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-22219.patch
>
>
> For YARN service, when number of running instances != number of desired
> instances, the service state may be in STARTED or FLEX (instead of STABLE).
> For Hive LLAP side, there is a config to control the threshold of service
> health check. The Hive LLAP code misses checking these states, which can
> result in the service not coming up even if the threshold is met.
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java#L382
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22219) Bringing a node manager down blocks restart of LLAP service
[
https://issues.apache.org/jira/browse/HIVE-22219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934691#comment-16934691
]
Hive QA commented on HIVE-22219:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
43s{color} | {color:blue} llap-server in master has 90 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18666/dev-support/hive-personality.sh
|
| git revision | master / 1278bf1 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: llap-server U: llap-server |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18666/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Bringing a node manager down blocks restart of LLAP service
> ---
>
> Key: HIVE-22219
> URL: https://issues.apache.org/jira/browse/HIVE-22219
> Project: Hive
> Issue Type: Bug
> Components: llap
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Major
> Attachments: HIVE-22219.patch
>
>
> For YARN service, when number of running instances != number of desired
> instances, the service state may be in STARTED or FLEX (instead of STABLE).
> For Hive LLAP side, there is a config to control the threshold of service
> health check. The Hive LLAP code misses checking these states, which can
> result in the service not coming up even if the threshold is met.
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java#L382
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22219) Bringing a node manager down blocks restart of LLAP service
[ https://issues.apache.org/jira/browse/HIVE-22219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934474#comment-16934474 ] slim bouguerra commented on HIVE-22219: --- +1 > Bringing a node manager down blocks restart of LLAP service > --- > > Key: HIVE-22219 > URL: https://issues.apache.org/jira/browse/HIVE-22219 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22219.patch > > > For YARN service, when number of running instances != number of desired > instances, the service state may be in STARTED or FLEX (instead of STABLE). > For Hive LLAP side, there is a config to control the threshold of service > health check. The Hive LLAP code misses checking these states, which can > result in the service not coming up even if the threshold is met. > https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java#L382 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22219) Bringing a node manager down blocks restart of LLAP service
[ https://issues.apache.org/jira/browse/HIVE-22219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934111#comment-16934111 ] Jesus Camacho Rodriguez commented on HIVE-22219: [~bslim], could you review this? Thanks > Bringing a node manager down blocks restart of LLAP service > --- > > Key: HIVE-22219 > URL: https://issues.apache.org/jira/browse/HIVE-22219 > Project: Hive > Issue Type: Bug > Components: llap >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22219.patch > > > For YARN service, when number of running instances != number of desired > instances, the service state may be in STARTED or FLEX (instead of STABLE). > For Hive LLAP side, there is a config to control the threshold of service > health check. The Hive LLAP code misses checking these states, which can > result in the service not coming up even if the threshold is met. > https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/cli/status/LlapStatusServiceDriver.java#L382 -- This message was sent by Atlassian Jira (v8.3.4#803005)
