[jira] [Commented] (HIVE-22246) Beeline reflector should handle map types
[
https://issues.apache.org/jira/browse/HIVE-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943262#comment-16943262
]
Rajesh Balamohan commented on HIVE-22246:
-
Thanks [~gopalv] . Committed to master.
> Beeline reflector should handle map types
> -
>
> Key: HIVE-22246
> URL: https://issues.apache.org/jira/browse/HIVE-22246
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Reporter: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-22246.1.patch, HIVE-22246.2.patch
>
>
> Since beeline {{Reflector}} is not handling Map types, it ends up converting
> values from {{beeline.properties}} to "null" and throws NPE with {{"}}beeline
> --hivevar x=1 --hivevar y=1".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22246) Beeline reflector should handle map types
[
https://issues.apache.org/jira/browse/HIVE-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939685#comment-16939685
]
Hive QA commented on HIVE-22246:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981503/HIVE-22246.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17009 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18763/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18763/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18763/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12981503 - PreCommit-HIVE-Build
> Beeline reflector should handle map types
> -
>
> Key: HIVE-22246
> URL: https://issues.apache.org/jira/browse/HIVE-22246
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Reporter: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-22246.1.patch, HIVE-22246.2.patch
>
>
> Since beeline {{Reflector}} is not handling Map types, it ends up converting
> values from {{beeline.properties}} to "null" and throws NPE with {{"}}beeline
> --hivevar x=1 --hivevar y=1".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22246) Beeline reflector should handle map types
[
https://issues.apache.org/jira/browse/HIVE-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939635#comment-16939635
]
Hive QA commented on HIVE-22246:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
32s{color} | {color:blue} beeline in master has 48 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18763/dev-support/hive-personality.sh
|
| git revision | master / b53521a |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: beeline U: beeline |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18763/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Beeline reflector should handle map types
> -
>
> Key: HIVE-22246
> URL: https://issues.apache.org/jira/browse/HIVE-22246
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Reporter: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-22246.1.patch, HIVE-22246.2.patch
>
>
> Since beeline {{Reflector}} is not handling Map types, it ends up converting
> values from {{beeline.properties}} to "null" and throws NPE with {{"}}beeline
> --hivevar x=1 --hivevar y=1".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22246) Beeline reflector should handle map types
[
https://issues.apache.org/jira/browse/HIVE-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938897#comment-16938897
]
Gopal Vijayaraghavan commented on HIVE-22246:
-
{code}
2019-09-26T11:02:02,410 INFO [main] txn.TxnHandler: Non-retryable error in
commitTxn(CommitTxnRequest(txnid:1)) : Table/View
'MATERIALIZATION_REBUILD_LOCKS' does not exist. (SQLState=42X05,
ErrorCode=2)
2019-09-26T11:02:02,413 ERROR [main] metastore.RetryingHMSHandler:
MetaException(message:Unable to update transaction database
java.sql.SQLSyntaxErrorException: Table/View 'MATERIALIZATION_REBUILD_LOCKS'
does not exist.
at
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown
Source)
{code}
failures look incidental.
> Beeline reflector should handle map types
> -
>
> Key: HIVE-22246
> URL: https://issues.apache.org/jira/browse/HIVE-22246
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Reporter: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-22246.1.patch
>
>
> Since beeline {{Reflector}} is not handling Map types, it ends up converting
> values from {{beeline.properties}} to "null" and throws NPE with {{"}}beeline
> --hivevar x=1 --hivevar y=1".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22246) Beeline reflector should handle map types
[
https://issues.apache.org/jira/browse/HIVE-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938862#comment-16938862
]
Hive QA commented on HIVE-22246:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981421/HIVE-22246.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 40 failed/errored test(s), 16975 tests
executed
*Failed tests:*
{noformat}
TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed
out) (batchId=233)
TestObjectStore - did not produce a TEST-*.xml file (likely timed out)
(batchId=233)
org.apache.hadoop.hive.ql.TestTxnCommands2.testACIDwithSchemaEvolutionAndCompaction
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testAcidOrcWritePreservesFieldNames
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testAcidWithSchemaEvolution
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testAlterTable (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testBucketCodec (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testBucketizedInputFormat
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testCleanerForTxnToWriteId
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testCompactWithDelete (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testDeleteEventsCompaction
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testDeleteIn (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testDynamicPartitionsMerge
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testDynamicPartitionsMerge2
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testETLSplitStrategyForACID
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testEmptyInTblproperties
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testFailHeartbeater (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testFailureOnAlteringTransactionalProperties
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testFileSystemUnCaching (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testInitiatorWithMultipleFailedCompactions
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite1 (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite2 (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwriteWithSelfJoin
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMerge (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMerge2 (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMerge3 (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMergeWithPredicate (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMmTableCompaction (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMultiInsert (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMultiInsertStatement
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidInsert (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion02
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testOpenTxnsCounter (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testOrcNoPPD (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testOrcPPD (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testOriginalFileReaderWhenNonAcidConvertedToAcid
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testUpdateMixedCase (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.testValidTxnsBookkeeping
(batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.updateDeletePartitioned (batchId=334)
org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner
(batchId=334)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18750/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18750/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18750/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 40 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12981421 - PreCommit-HIVE-Build
> Beeline reflector should handle map types
> -
>
> Key: HIVE-22246
> URL: https://issues.apache.org/jira/browse/HIVE-22246
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Reporter: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-22246.1.patch
>
>
> Since beeline {{Reflector}} is not handling Map types, it
[jira] [Commented] (HIVE-22246) Beeline reflector should handle map types
[
https://issues.apache.org/jira/browse/HIVE-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938827#comment-16938827
]
Gopal Vijayaraghavan commented on HIVE-22246:
-
Change to split("=",2), so that the strings can contain their own =.
LGTM - +1
> Beeline reflector should handle map types
> -
>
> Key: HIVE-22246
> URL: https://issues.apache.org/jira/browse/HIVE-22246
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Reporter: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-22246.1.patch
>
>
> Since beeline {{Reflector}} is not handling Map types, it ends up converting
> values from {{beeline.properties}} to "null" and throws NPE with {{"}}beeline
> --hivevar x=1 --hivevar y=1".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22246) Beeline reflector should handle map types
[
https://issues.apache.org/jira/browse/HIVE-22246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938821#comment-16938821
]
Hive QA commented on HIVE-22246:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
27s{color} | {color:blue} beeline in master has 48 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18750/dev-support/hive-personality.sh
|
| git revision | master / be1d957 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: beeline U: beeline |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18750/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Beeline reflector should handle map types
> -
>
> Key: HIVE-22246
> URL: https://issues.apache.org/jira/browse/HIVE-22246
> Project: Hive
> Issue Type: Bug
> Components: Beeline
>Reporter: Rajesh Balamohan
>Priority: Trivial
> Attachments: HIVE-22246.1.patch
>
>
> Since beeline {{Reflector}} is not handling Map types, it ends up converting
> values from {{beeline.properties}} to "null" and throws NPE with {{"}}beeline
> --hivevar x=1 --hivevar y=1".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
